* [Qemu-trivial] [PATCH] configure: fix seccomp check
@ 2012-09-06 20:40 ` Yann E. MORIN
0 siblings, 0 replies; 6+ messages in thread
From: Yann E. MORIN @ 2012-09-06 20:40 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Yann E. MORIN
Currently, if libseccomp is missing but the user explicitly requested
seccomp support using --enable-seccomp, configure silently ignores the
situation and disables seccomp support.
This is unlike all other tests that explicitly fail in such situation.
Fix that.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
configure | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/configure b/configure
index c5888fa..23abb46 100755
--- a/configure
+++ b/configure
@@ -1429,10 +1429,10 @@ if test "$seccomp" != "no" ; then
LIBS=`$pkg_config --libs libseccomp`
seccomp="yes"
else
- seccomp="no"
if test "$seccomp" = "yes"; then
feature_not_found "libseccomp"
fi
+ seccomp="no"
fi
fi
##########################################
--
1.7.2.5
^ permalink raw reply related [flat|nested] 6+ messages in thread* [Qemu-devel] [PATCH] configure: fix seccomp check
@ 2012-09-06 20:40 ` Yann E. MORIN
0 siblings, 0 replies; 6+ messages in thread
From: Yann E. MORIN @ 2012-09-06 20:40 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Yann E. MORIN
Currently, if libseccomp is missing but the user explicitly requested
seccomp support using --enable-seccomp, configure silently ignores the
situation and disables seccomp support.
This is unlike all other tests that explicitly fail in such situation.
Fix that.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
configure | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/configure b/configure
index c5888fa..23abb46 100755
--- a/configure
+++ b/configure
@@ -1429,10 +1429,10 @@ if test "$seccomp" != "no" ; then
LIBS=`$pkg_config --libs libseccomp`
seccomp="yes"
else
- seccomp="no"
if test "$seccomp" = "yes"; then
feature_not_found "libseccomp"
fi
+ seccomp="no"
fi
fi
##########################################
--
1.7.2.5
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [Qemu-trivial] [Qemu-devel] [PATCH] configure: fix seccomp check
2012-09-06 20:40 ` [Qemu-devel] " Yann E. MORIN
@ 2012-09-07 14:41 ` Andreas Färber
-1 siblings, 0 replies; 6+ messages in thread
From: Andreas Färber @ 2012-09-07 14:41 UTC (permalink / raw)
To: Yann E. MORIN; +Cc: qemu-trivial, qemu-devel
Am 06.09.2012 22:40, schrieb Yann E. MORIN:
> Currently, if libseccomp is missing but the user explicitly requested
> seccomp support using --enable-seccomp, configure silently ignores the
> situation and disables seccomp support.
>
> This is unlike all other tests that explicitly fail in such situation.
>
> Fix that.
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Reviewed-by: Andreas Färber <afaerber@suse.de>
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] configure: fix seccomp check
@ 2012-09-07 14:41 ` Andreas Färber
0 siblings, 0 replies; 6+ messages in thread
From: Andreas Färber @ 2012-09-07 14:41 UTC (permalink / raw)
To: Yann E. MORIN; +Cc: qemu-trivial, qemu-devel
Am 06.09.2012 22:40, schrieb Yann E. MORIN:
> Currently, if libseccomp is missing but the user explicitly requested
> seccomp support using --enable-seccomp, configure silently ignores the
> situation and disables seccomp support.
>
> This is unlike all other tests that explicitly fail in such situation.
>
> Fix that.
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Reviewed-by: Andreas Färber <afaerber@suse.de>
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-trivial] [PATCH] configure: fix seccomp check
2012-09-06 20:40 ` [Qemu-devel] " Yann E. MORIN
@ 2012-09-14 7:46 ` Stefan Hajnoczi
-1 siblings, 0 replies; 6+ messages in thread
From: Stefan Hajnoczi @ 2012-09-14 7:46 UTC (permalink / raw)
To: Yann E. MORIN; +Cc: qemu-trivial, qemu-devel
On Thu, Sep 06, 2012 at 10:40:30PM +0200, Yann E. MORIN wrote:
> Currently, if libseccomp is missing but the user explicitly requested
> seccomp support using --enable-seccomp, configure silently ignores the
> situation and disables seccomp support.
>
> This is unlike all other tests that explicitly fail in such situation.
>
> Fix that.
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> ---
> configure | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches
Stefan
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: fix seccomp check
@ 2012-09-14 7:46 ` Stefan Hajnoczi
0 siblings, 0 replies; 6+ messages in thread
From: Stefan Hajnoczi @ 2012-09-14 7:46 UTC (permalink / raw)
To: Yann E. MORIN; +Cc: qemu-trivial, qemu-devel
On Thu, Sep 06, 2012 at 10:40:30PM +0200, Yann E. MORIN wrote:
> Currently, if libseccomp is missing but the user explicitly requested
> seccomp support using --enable-seccomp, configure silently ignores the
> situation and disables seccomp support.
>
> This is unlike all other tests that explicitly fail in such situation.
>
> Fix that.
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> ---
> configure | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches
Stefan
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-09-14 7:47 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-06 20:40 [Qemu-trivial] [PATCH] configure: fix seccomp check Yann E. MORIN
2012-09-06 20:40 ` [Qemu-devel] " Yann E. MORIN
2012-09-07 14:41 ` [Qemu-trivial] " Andreas Färber
2012-09-07 14:41 ` Andreas Färber
2012-09-14 7:46 ` [Qemu-trivial] " Stefan Hajnoczi
2012-09-14 7:46 ` [Qemu-devel] " Stefan Hajnoczi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.