[RFC v1] gatchat: Print error message if opening tun failes

[RFC v1] gatchat: Print error message if opening tun failes

[Daniel Wagner]

[-- Attachment #1: Type: text/plain, Size: 1015 bytes --]

From: Daniel Wagner <daniel.wagner@bmw-carit.de>

This is a very common misstake. Let's help the users to
configure their system correctly.
---
Hi,

I was not able to find out why the check in at_grps_context_prope() does not
hit when the tun module is not loaded. Therefore, this on gets only
an RFC state...

cheers,
daniel

 gatchat/ppp_net.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/gatchat/ppp_net.c b/gatchat/ppp_net.c
index 1609b99..813ed9b 100644
--- a/gatchat/ppp_net.c
+++ b/gatchat/ppp_net.c
@@ -155,8 +155,12 @@ struct ppp_net *ppp_net_new(GAtPPP *ppp, int fd)
 	if (fd < 0) {
 		/* open a tun interface */
 		fd = open("/dev/net/tun", O_RDWR);
-		if (fd < 0)
+		if (fd < 0) {
+			ppp_debug(ppp, "Couldn't open tun device. "
+					"Do you run oFono as root and do you "
+					"have the TUN module loaded?");
 			goto error;
+		}
 
 		ifr.ifr_flags = IFF_TUN | IFF_NO_PI;
 		strcpy(ifr.ifr_name, "ppp%d");
-- 
1.7.12.rc1.16.g05a20c8

Re: [RFC v1] gatchat: Print error message if opening tun failes

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 583 bytes --]

Hi Daniel,

On 08/24/2012 07:16 AM, Daniel Wagner wrote:
> From: Daniel Wagner<daniel.wagner@bmw-carit.de>
>
> This is a very common misstake. Let's help the users to
> configure their system correctly.
> ---
> Hi,
>
> I was not able to find out why the check in at_grps_context_prope() does not
> hit when the tun module is not loaded. Therefore, this on gets only
> an RFC state...
>
> cheers,
> daniel
>
>   gatchat/ppp_net.c | 6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)
>

I went ahead and applied this patch, thanks.

Regards,
-Denis

Re: [RFC v1] gatchat: Print error message if opening tun failes

[Daniel Wagner]

[-- Attachment #1: Type: text/plain, Size: 820 bytes --]

Hi Denis,

On 08/31/2012 12:07 AM, Denis Kenzior wrote:
> On 08/24/2012 07:16 AM, Daniel Wagner wrote:
>> From: Daniel Wagner<daniel.wagner@bmw-carit.de>
>>
>> This is a very common misstake. Let's help the users to
>> configure their system correctly.
>> ---
>> Hi,
>>
>> I was not able to find out why the check in at_grps_context_prope() 
>> does not
>> hit when the tun module is not loaded. Therefore, this on gets only
>> an RFC state...
>>
>> cheers,
>> daniel
>>
>>   gatchat/ppp_net.c | 6 +++++-
>>   1 file changed, 5 insertions(+), 1 deletion(-)
>>
> 
> I went ahead and applied this patch, thanks.

I wonder if we should do something like this here

http://git.kernel.org/?p=network/connman/connman.git;a=commitdiff;h=4fe07dfed4f720136ee142e56a9d43242c8c78dc

cheers,
daniel