[2011.03-maintenance][PATCH] gtk+_2.20.1: Depend on gdk-pixbuf-native

[2011.03-maintenance][PATCH] gtk+_2.20.1: Depend on gdk-pixbuf-native

[Khem Raj]

also BBCLASSEXTEND gdk-pixbuf recipes to provide
native version

Newer distros which ship glib-2.0 version 2.32+
there are some missing symbols that gtk+ 2.20
will complain about. So we create own gdk-pixbuf
so it does not link to library from host system

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 recipes/gtk+/gdk-pixbuf_2.10.14.bb |    1 +
 recipes/gtk+/gtk+_2.20.1.bb        |    4 ++--
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/recipes/gtk+/gdk-pixbuf_2.10.14.bb b/recipes/gtk+/gdk-pixbuf_2.10.14.bb
index e41f9e0..c41a2be 100644
--- a/recipes/gtk+/gdk-pixbuf_2.10.14.bb
+++ b/recipes/gtk+/gdk-pixbuf_2.10.14.bb
@@ -64,6 +64,7 @@ do_install() {
 	cd gdk-pixbuf && oe_runmake install DESTDIR=${D}
 }
 
+BBCLASSEXTEND = "native"
 
 SRC_URI[md5sum] = "018d7dd0fa7de01cfdb77c7c55e7ba26"
 SRC_URI[sha256sum] = "d02344239d048390ba02fcfd7de4f9efc0dfb51e7b06dfa46a6314d666ea4de2"
diff --git a/recipes/gtk+/gtk+_2.20.1.bb b/recipes/gtk+/gtk+_2.20.1.bb
index 62f2f3c..4d801f1 100644
--- a/recipes/gtk+/gtk+_2.20.1.bb
+++ b/recipes/gtk+/gtk+_2.20.1.bb
@@ -13,13 +13,13 @@ SRC_URI_append = "file://gtk-dnd-grab-deadlock-fix.patch \
 SRC_URI[gtk.md5sum] = "53e6f3a93bd22934878fc4a4a34c68aa"
 SRC_URI[gtk.sha256sum] = "0e081731d21e34ff45c82199490c2889504fa8b3c7e117c043e82ababaec0f65"
 
-PR = "${INC_PR}.5"
+PR = "${INC_PR}.6"
 
 BBCLASSEXTEND = "native"
 
 ARM_INSTRUCTION_SET = "arm"
 
-DEPENDS_virtclass-native = "libpng-native atk-native pango-native cairo-native libxrender-native libxext-native libgcrypt-native"
+DEPENDS_virtclass-native = "gdk-pixbuf-native libpng-native atk-native pango-native cairo-native libxrender-native libxext-native libgcrypt-native"
 PROVIDES_virtclass-native = "gdk-pixbuf-csource-native"
 
 # Enable xkb selectively
-- 
1.7.9.5

Re: [2011.03-maintenance][PATCH] gtk+_2.20.1: Depend on gdk-pixbuf-native

[Tom Rini]

On Mon, Aug 27, 2012 at 03:50:54PM -0700, Khem Raj wrote:

> also BBCLASSEXTEND gdk-pixbuf recipes to provide
> native version
> 
> Newer distros which ship glib-2.0 version 2.32+
> there are some missing symbols that gtk+ 2.20
> will complain about. So we create own gdk-pixbuf
> so it does not link to library from host system
> 
> Signed-off-by: Khem Raj <raj.khem@gmail.com>

Applied to 2011.03-maintenance branch.

-- 
Tom

Re: [2011.03-maintenance][PATCH] gtk+_2.20.1: Depend on gdk-pixbuf-native

[Steffen Sledz]

On 28.08.2012 00:50, Khem Raj wrote:
> also BBCLASSEXTEND gdk-pixbuf recipes to provide
> native version
> 
> Newer distros which ship glib-2.0 version 2.32+
> there are some missing symbols that gtk+ 2.20
> will complain about. So we create own gdk-pixbuf
> so it does not link to library from host system

It seems that the dependencies are incomplete.

-----------> snip <-----------
...
| checking for BASE_DEPENDENCIES... configure: error: Package requirements (glib-2.0 >= 2.12.0    atk >= 1.9.0    pango >= 1.12.0    cairo >= 1.2.0) were not met:
|
| No package 'atk' found
| No package 'pango' found
| No package 'cairo' found
|
| Consider adjusting the PKG_CONFIG_PATH environment variable if you
| installed software in a non-standard prefix.
|
| Alternatively, you may set the environment variables BASE_DEPENDENCIES_CFLAGS
| and BASE_DEPENDENCIES_LIBS to avoid the need to call pkg-config.
| See the pkg-config man page for more details.
|
NOTE: package gdk-pixbuf-native-2.10.14-r2: task do_configure: Failed
-----------> snip <-----------

Steffen

-- 
DResearch Fahrzeugelektronik GmbH
Otto-Schmirgal-Str. 3, 10319 Berlin, Germany
Tel: +49 30 515932-237 mailto:sledz@dresearch-fe.de
Fax: +49 30 515932-299
Geschäftsführer: Dr. Michael Weber, Werner Mögle;
Amtsgericht Berlin Charlottenburg; HRB 130120 B;
Ust.-IDNr. DE273952058

Re: [2011.03-maintenance][PATCH] gtk+_2.20.1: Depend on gdk-pixbuf-native

[Steffen Sledz]

On 06.09.2012 14:17, Steffen Sledz wrote:
> On 28.08.2012 00:50, Khem Raj wrote:
>> also BBCLASSEXTEND gdk-pixbuf recipes to provide
>> native version
>>
>> Newer distros which ship glib-2.0 version 2.32+
>> there are some missing symbols that gtk+ 2.20
>> will complain about. So we create own gdk-pixbuf
>> so it does not link to library from host system
> 
> It seems that the dependencies are incomplete.
> 
> -----------> snip <-----------
> ...
> | checking for BASE_DEPENDENCIES... configure: error: Package requirements (glib-2.0 >= 2.12.0    atk >= 1.9.0    pango >= 1.12.0    cairo >= 1.2.0) were not met:
> |
> | No package 'atk' found
> | No package 'pango' found
> | No package 'cairo' found
> |
> | Consider adjusting the PKG_CONFIG_PATH environment variable if you
> | installed software in a non-standard prefix.
> |
> | Alternatively, you may set the environment variables BASE_DEPENDENCIES_CFLAGS
> | and BASE_DEPENDENCIES_LIBS to avoid the need to call pkg-config.
> | See the pkg-config man page for more details.
> |
> NOTE: package gdk-pixbuf-native-2.10.14-r2: task do_configure: Failed
> -----------> snip <-----------

Ping!

-- 
DResearch Fahrzeugelektronik GmbH
Otto-Schmirgal-Str. 3, 10319 Berlin, Germany
Tel: +49 30 515932-237 mailto:sledz@dresearch-fe.de
Fax: +49 30 515932-299
Geschäftsführer: Dr. Michael Weber, Werner Mögle;
Amtsgericht Berlin Charlottenburg; HRB 130120 B;
Ust.-IDNr. DE273952058

[2011.03-maintenance][PATCH] gdk-pixbuf: add missing dependencies

[Steffen Sledz]

This fixes an error in do_configure step for target and native build.

| checking for BASE_DEPENDENCIES... configure: error: Package requirements (glib-2.0 >= 2.12.0    atk >= 1.9.0    pango >= 1.12.0    cairo >= 1.2.0) were not met:
|
| No package 'atk' found
| No package 'pango' found
| No package 'cairo' found

Signed-off-by: Steffen Sledz <sledz@dresearch-fe.de>
---
 recipes/gtk+/gdk-pixbuf_2.10.14.bb |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/recipes/gtk+/gdk-pixbuf_2.10.14.bb b/recipes/gtk+/gdk-pixbuf_2.10.14.bb
index c41a2be..e9493f9 100644
--- a/recipes/gtk+/gdk-pixbuf_2.10.14.bb
+++ b/recipes/gtk+/gdk-pixbuf_2.10.14.bb
@@ -4,7 +4,7 @@ HOMEPAGE = "http://www.gtk.org/"
 SECTION = "libs"
 LICENSE = "LGPL"
 PRIORITY = "optional"
-DEPENDS = "libpng gettext glib-2.0"
+DEPENDS = "libpng gettext glib-2.0 atk pango cairo"
 PR = "r2"
 
 S = "${WORKDIR}/gtk+-${PV}"
-- 
1.7.10.4

Re: [2011.03-maintenance][PATCH] gdk-pixbuf: add missing dependencies

[Burton, Ross]

On 11 September 2012 13:42, Steffen Sledz <sledz@dresearch-fe.de> wrote:
> | No package 'atk' found
> | No package 'pango' found
> | No package 'cairo' found

Those are spurious dependencies in a very old version of gdk-pixbuf.

oe-core master has 2.24.1 at the moment, is there a good reason why
meta-oe is hanging onto 2.10.14?

Ross

Re: [2011.03-maintenance][PATCH] gdk-pixbuf: add missing dependencies

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 517 bytes --]

On Tue, Sep 11, 2012 at 01:59:21PM +0100, Burton, Ross wrote:
> On 11 September 2012 13:42, Steffen Sledz <sledz@dresearch-fe.de> wrote:
> > | No package 'atk' found
> > | No package 'pango' found
> > | No package 'cairo' found
> 
> Those are spurious dependencies in a very old version of gdk-pixbuf.
> 
> oe-core master has 2.24.1 at the moment, is there a good reason why
> meta-oe is hanging onto 2.10.14?

2011.03-maintenance != meta-oe

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

Re: [2011.03-maintenance][PATCH] gdk-pixbuf: add missing dependencies

[Paul Eggleton]

On Tuesday 11 September 2012 13:59:21 Burton, Ross wrote:
> On 11 September 2012 13:42, Steffen Sledz <sledz@dresearch-fe.de> wrote:
> > | No package 'atk' found
> > | No package 'pango' found
> > | No package 'cairo' found
> 
> Those are spurious dependencies in a very old version of gdk-pixbuf.
> 
> oe-core master has 2.24.1 at the moment, is there a good reason why
> meta-oe is hanging onto 2.10.14?

This is the OE-Classic 2011.03-maintenance branch. I was surprised too until I 
realised where this was :)

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre

Re: [2011.03-maintenance][PATCH] gdk-pixbuf: add missing dependencies

[Burton, Ross]

On 11 September 2012 14:03, Paul Eggleton <paul.eggleton@linux.intel.com> wrote:
>> oe-core master has 2.24.1 at the moment, is there a good reason why
>> meta-oe is hanging onto 2.10.14?
>
> This is the OE-Classic 2011.03-maintenance branch. I was surprised too until I
> realised where this was :)

Oh, wow.  In that case I recommend either patching out those
dependencies instead, or upgrading to a more modern version of
gdk-pixbuf.

Ross

Re: [2011.03-maintenance][PATCH] gdk-pixbuf: add missing dependencies

[Steffen Sledz]

On 11.09.2012 15:39, Burton, Ross wrote:
> On 11 September 2012 14:03, Paul Eggleton <paul.eggleton@linux.intel.com> wrote:
>>> oe-core master has 2.24.1 at the moment, is there a good reason why
>>> meta-oe is hanging onto 2.10.14?
>>
>> This is the OE-Classic 2011.03-maintenance branch. I was surprised too until I
>> realised where this was :)
> 
> Oh, wow.  In that case I recommend either patching out those
> dependencies instead, or upgrading to a more modern version of
> gdk-pixbuf.

This is a maintenance branch. Tom normally does not accept upgrade patches if there's no critical problem it fixes.

I just wanted to fix a build problem introduced with Khem's commit.

Steffen

-- 
DResearch Fahrzeugelektronik GmbH
Otto-Schmirgal-Str. 3, 10319 Berlin, Germany
Tel: +49 30 515932-237 mailto:sledz@dresearch-fe.de
Fax: +49 30 515932-299
Geschäftsführer: Dr. Michael Weber, Werner Mögle;
Amtsgericht Berlin Charlottenburg; HRB 130120 B;
Ust.-IDNr. DE273952058

Re: [2011.03-maintenance][PATCH] gdk-pixbuf: add missing dependencies

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 494 bytes --]

On Tue, Sep 11, 2012 at 02:42:54PM +0200, Steffen Sledz wrote:

> This fixes an error in do_configure step for target and native build.
> 
> | checking for BASE_DEPENDENCIES... configure: error: Package requirements (glib-2.0 >= 2.12.0    atk >= 1.9.0    pango >= 1.12.0    cairo >= 1.2.0) were not met:
> |
> | No package 'atk' found
> | No package 'pango' found
> | No package 'cairo' found
> 
> Signed-off-by: Steffen Sledz <sledz@dresearch-fe.de>

Applied, thanks!

-- 
Tom

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]