* [PATCH 2/2] backlight: add new lm3639 backlight driver
@ 2012-09-10 3:16 G.Shark Jeong
2012-09-10 5:28 ` Randy Dunlap
0 siblings, 1 reply; 3+ messages in thread
From: G.Shark Jeong @ 2012-09-10 3:16 UTC (permalink / raw)
To: Andrew Morton, Richard Purdie; +Cc: Daniel Jeong, linux-kernel, G.Shark Jeong
From: "G.Shark Jeong" <gshark.jeong@gmail.com>
This driver is a general version for LM3639 backlgiht driver chip of TI.
Put NEW_LEDS and LEDS_CLASS into Kconfig file to reduce additional configuration works in LEDs.
www.ti.com
Signed-off-by: G.Shark Jeong <gshark.jeong@gmail.com>
---
drivers/video/backlight/Kconfig | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig
index 2ed68bd..e6c78cd 100644
--- a/drivers/video/backlight/Kconfig
+++ b/drivers/video/backlight/Kconfig
@@ -356,6 +356,8 @@ config BACKLIGHT_LM3639
tristate "Backlight Driver for LM3639"
depends on BACKLIGHT_CLASS_DEVICE && I2C
select REGMAP_I2C
+ select NEW_LEDS
+ select LEDS_CLASS
help
This supports TI LM3639 Backlight + 1.5A Flash LED Driver
--
1.7.5.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 2/2] backlight: add new lm3639 backlight driver
2012-09-10 3:16 [PATCH 2/2] backlight: add new lm3639 backlight driver G.Shark Jeong
@ 2012-09-10 5:28 ` Randy Dunlap
2012-09-10 7:13 ` gshark
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2012-09-10 5:28 UTC (permalink / raw)
To: G.Shark Jeong; +Cc: Andrew Morton, Richard Purdie, Daniel Jeong, linux-kernel
On 09/09/2012 08:16 PM, G.Shark Jeong wrote:
> From: "G.Shark Jeong" <gshark.jeong@gmail.com>
>
> This driver is a general version for LM3639 backlgiht driver chip of TI.
>
> Put NEW_LEDS and LEDS_CLASS into Kconfig file to reduce additional configuration works in LEDs.
>
> www.ti.com
eh?
>
> Signed-off-by: G.Shark Jeong <gshark.jeong@gmail.com>
Linus has asked patch committers to use Reported-by when appropriate.
Reported-by: Randy Dunlap <rdunlap@xenotime.net>
Acked-by: Randy Dunlap <rdunlap@xenotime.net>
> ---
> drivers/video/backlight/Kconfig | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig
> index 2ed68bd..e6c78cd 100644
> --- a/drivers/video/backlight/Kconfig
> +++ b/drivers/video/backlight/Kconfig
> @@ -356,6 +356,8 @@ config BACKLIGHT_LM3639
> tristate "Backlight Driver for LM3639"
> depends on BACKLIGHT_CLASS_DEVICE && I2C
> select REGMAP_I2C
> + select NEW_LEDS
> + select LEDS_CLASS
> help
> This supports TI LM3639 Backlight + 1.5A Flash LED Driver
>
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2/2] backlight: add new lm3639 backlight driver
2012-09-10 5:28 ` Randy Dunlap
@ 2012-09-10 7:13 ` gshark
0 siblings, 0 replies; 3+ messages in thread
From: gshark @ 2012-09-10 7:13 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Andrew Morton, Richard Purdie, Daniel Jeong, linux-kernel
LM3639 has not only pins for backlihgt but also pins for LEDs. So it
uses functions in led_class and led_core file.
When I see your config file, "randconig", you set CONFIG_NEW_LEDS=y but
you didn't set CONFIG_LEDS_CLASS.
We need to set CONFIG_NEW_LEDS and CONFIG_LEDS_CLASS both to compile it.
To fix it, I added two reverse dependencies "select NEW_LEDS" and
"select CONFIG_LEDS_CLASS".
2012년 09월 10일 14:28, Randy Dunlap 쓴 글:
> On 09/09/2012 08:16 PM, G.Shark Jeong wrote:
>
>> From: "G.Shark Jeong" <gshark.jeong@gmail.com>
>>
>> This driver is a general version for LM3639 backlgiht driver chip of TI.
>>
>> Put NEW_LEDS and LEDS_CLASS into Kconfig file to reduce additional configuration works in LEDs.
>>
>> www.ti.com
>
> eh?
>
>> Signed-off-by: G.Shark Jeong <gshark.jeong@gmail.com>
>
> Linus has asked patch committers to use Reported-by when appropriate.
>
> Reported-by: Randy Dunlap <rdunlap@xenotime.net>
> Acked-by: Randy Dunlap <rdunlap@xenotime.net>
>
>
>> ---
>> drivers/video/backlight/Kconfig | 2 ++
>> 1 files changed, 2 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig
>> index 2ed68bd..e6c78cd 100644
>> --- a/drivers/video/backlight/Kconfig
>> +++ b/drivers/video/backlight/Kconfig
>> @@ -356,6 +356,8 @@ config BACKLIGHT_LM3639
>> tristate "Backlight Driver for LM3639"
>> depends on BACKLIGHT_CLASS_DEVICE && I2C
>> select REGMAP_I2C
>> + select NEW_LEDS
>> + select LEDS_CLASS
>> help
>> This supports TI LM3639 Backlight + 1.5A Flash LED Driver
>>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-09-10 7:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-10 3:16 [PATCH 2/2] backlight: add new lm3639 backlight driver G.Shark Jeong
2012-09-10 5:28 ` Randy Dunlap
2012-09-10 7:13 ` gshark
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.