From: Florian Vaussard <florian.vaussard-p8DiymsW2f8@public.gmane.org>
To: Benoit Cousson <b-cousson-l0cyMroinI0@public.gmane.org>
Cc: Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 1/2] gpio/twl4030: get platform data from device tree
Date: Mon, 10 Sep 2012 10:40:06 +0200 [thread overview]
Message-ID: <504DA766.1080304@epfl.ch> (raw)
In-Reply-To: <504DA503.5050901-l0cyMroinI0@public.gmane.org>
Hello Benoit,
>>
>> I fixed them since it was trivial, but next time you should ensure
>> that the patch pass checkpatch before posting.
>> Sorry for these errors. I however checked my patches before submitting,
>> and had no such warnings. I redone, and remarked that these warnings
>> appear only with the "--strict" option, which is not enabled by default.
>> Is this the recommended guideline? Thus why not enabling it by default?
> That's a pretty good question :-)
>
> Maybe the --strict is more a nice to have than a strong requirement?
> Anyway, we'd better run checkpatch with --strict and thus fix any
> cosmetic details that might be in the patch.
Good to know, I will use --strict for the next submissions.
> Cool, I love chocolate. That being said, I'm not sure how tasteful
> will be the *virtual* chocolate. Regards, Benoit
Even *virtual*, Swiss chocolate will be the most tasteful (hope no Belgium
friends will see this thread) :-)
Regards,
Florian
WARNING: multiple messages have this Message-ID (diff)
From: florian.vaussard@epfl.ch (Florian Vaussard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] gpio/twl4030: get platform data from device tree
Date: Mon, 10 Sep 2012 10:40:06 +0200 [thread overview]
Message-ID: <504DA766.1080304@epfl.ch> (raw)
In-Reply-To: <504DA503.5050901@ti.com>
Hello Benoit,
>>
>> I fixed them since it was trivial, but next time you should ensure
>> that the patch pass checkpatch before posting.
>> Sorry for these errors. I however checked my patches before submitting,
>> and had no such warnings. I redone, and remarked that these warnings
>> appear only with the "--strict" option, which is not enabled by default.
>> Is this the recommended guideline? Thus why not enabling it by default?
> That's a pretty good question :-)
>
> Maybe the --strict is more a nice to have than a strong requirement?
> Anyway, we'd better run checkpatch with --strict and thus fix any
> cosmetic details that might be in the patch.
Good to know, I will use --strict for the next submissions.
> Cool, I love chocolate. That being said, I'm not sure how tasteful
> will be the *virtual* chocolate. Regards, Benoit
Even *virtual*, Swiss chocolate will be the most tasteful (hope no Belgium
friends will see this thread) :-)
Regards,
Florian
next prev parent reply other threads:[~2012-09-10 8:40 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-05 7:46 [PATCH v2 0/2] gpio-twl4030: add new device tree properties Florian Vaussard
2012-09-05 7:46 ` Florian Vaussard
2012-09-05 7:46 ` [PATCH 1/2] gpio/twl4030: get platform data from device tree Florian Vaussard
2012-09-05 7:46 ` Florian Vaussard
[not found] ` <1346831186-29947-2-git-send-email-florian.vaussard-p8DiymsW2f8@public.gmane.org>
2012-09-07 17:33 ` Benoit Cousson
2012-09-07 17:33 ` Benoit Cousson
2012-09-10 8:17 ` Florian Vaussard
2012-09-10 8:17 ` Florian Vaussard
2012-09-10 8:29 ` Benoit Cousson
2012-09-10 8:29 ` Benoit Cousson
[not found] ` <504DA503.5050901-l0cyMroinI0@public.gmane.org>
2012-09-10 8:40 ` Florian Vaussard [this message]
2012-09-10 8:40 ` Florian Vaussard
2012-09-05 7:46 ` [PATCH 2/2] ARM: dts: omap3: Add gpio-twl4030 properties for BeagleBoard and omap3-EVM Florian Vaussard
2012-09-05 7:46 ` Florian Vaussard
2012-09-05 14:41 ` [PATCH v2 0/2] gpio-twl4030: add new device tree properties Benoit Cousson
2012-09-05 14:41 ` Benoit Cousson
2012-09-06 20:51 ` Tony Lindgren
2012-09-06 20:51 ` Tony Lindgren
2012-09-07 8:55 ` Benoit Cousson
2012-09-07 8:55 ` Benoit Cousson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=504DA766.1080304@epfl.ch \
--to=florian.vaussard-p8diymsw2f8@public.gmane.org \
--cc=b-cousson-l0cyMroinI0@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.