From: Jan Kiszka <jan.kiszka@siemens.com>
To: Avi Kivity <avi@redhat.com>
Cc: Liu Sheng <liusheng@linux.vnet.ibm.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"mtosatti@redhat.com" <mtosatti@redhat.com>,
"xiaoguangrong@linux.vnet.ibm.com"
<xiaoguangrong@linux.vnet.ibm.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"aliguori@us.ibm.com" <aliguori@us.ibm.com>
Subject: Re: [PATCH 3/3] support readonly memory feature in qemu
Date: Mon, 10 Sep 2012 11:25:38 +0200 [thread overview]
Message-ID: <504DB212.3000908@siemens.com> (raw)
In-Reply-To: <504CB9B3.8010408@redhat.com>
On 2012-09-09 17:45, Avi Kivity wrote:
> On 09/07/2012 11:50 AM, Jan Kiszka wrote:
>>
>>> + } else {
>>> + cpu_physical_memory_rw(run->mmio.phys_addr,
>>> + run->mmio.data,
>>> + run->mmio.len,
>>> + run->mmio.is_write);
>>> + }
>>> +
>>> ret = 0;
>>> break;
>>> case KVM_EXIT_IRQ_WINDOW_OPEN:
>>>
>>
>> Great to see this feature for KVM finally! I'm just afraid that this
>> will finally break good old isapc - due to broken Seabios. KVM used to
>> "unbreak" it as it didn't respect write protections. ;)
>
> Can you describe the breakage?
Try "qemu -machine isapc [-enable-kvm]". Seabios is writing to some
read-only marked area. Don't recall where precisely.
Jan
--
Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
Corporate Competence Center Embedded Linux
WARNING: multiple messages have this Message-ID (diff)
From: Jan Kiszka <jan.kiszka@siemens.com>
To: Avi Kivity <avi@redhat.com>
Cc: "aliguori@us.ibm.com" <aliguori@us.ibm.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"mtosatti@redhat.com" <mtosatti@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"xiaoguangrong@linux.vnet.ibm.com"
<xiaoguangrong@linux.vnet.ibm.com>,
Liu Sheng <liusheng@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH 3/3] support readonly memory feature in qemu
Date: Mon, 10 Sep 2012 11:25:38 +0200 [thread overview]
Message-ID: <504DB212.3000908@siemens.com> (raw)
In-Reply-To: <504CB9B3.8010408@redhat.com>
On 2012-09-09 17:45, Avi Kivity wrote:
> On 09/07/2012 11:50 AM, Jan Kiszka wrote:
>>
>>> + } else {
>>> + cpu_physical_memory_rw(run->mmio.phys_addr,
>>> + run->mmio.data,
>>> + run->mmio.len,
>>> + run->mmio.is_write);
>>> + }
>>> +
>>> ret = 0;
>>> break;
>>> case KVM_EXIT_IRQ_WINDOW_OPEN:
>>>
>>
>> Great to see this feature for KVM finally! I'm just afraid that this
>> will finally break good old isapc - due to broken Seabios. KVM used to
>> "unbreak" it as it didn't respect write protections. ;)
>
> Can you describe the breakage?
Try "qemu -machine isapc [-enable-kvm]". Seabios is writing to some
read-only marked area. Don't recall where precisely.
Jan
--
Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2012-09-10 9:25 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-07 8:26 [PATCH 0/3] support kvm readonly memory slot in qemu Liu Sheng
2012-09-07 8:26 ` [Qemu-devel] " Liu Sheng
2012-09-07 8:26 ` [PATCH 1/3] set the readonly property of rom memory region in pc Liu Sheng
2012-09-07 8:26 ` [Qemu-devel] " Liu Sheng
2012-09-07 8:26 ` [PATCH 2/3] update kvm related the head file from kernel Liu Sheng
2012-09-07 8:26 ` [Qemu-devel] " Liu Sheng
2012-09-07 8:49 ` Jan Kiszka
2012-09-07 8:49 ` [Qemu-devel] " Jan Kiszka
2012-09-07 9:39 ` Xiao Guangrong
2012-09-07 9:39 ` [Qemu-devel] " Xiao Guangrong
2012-09-07 10:17 ` Jan Kiszka
2012-09-07 10:17 ` [Qemu-devel] " Jan Kiszka
2012-09-07 8:26 ` [PATCH 3/3] support readonly memory feature in qemu Liu Sheng
2012-09-07 8:26 ` [Qemu-devel] " Liu Sheng
2012-09-07 8:50 ` Jan Kiszka
2012-09-07 8:50 ` [Qemu-devel] " Jan Kiszka
2012-09-09 15:45 ` Avi Kivity
2012-09-09 15:45 ` [Qemu-devel] " Avi Kivity
2012-09-10 9:25 ` Jan Kiszka [this message]
2012-09-10 9:25 ` Jan Kiszka
2012-09-11 3:02 ` Kevin O'Connor
2012-09-11 3:02 ` [Qemu-devel] " Kevin O'Connor
2012-09-11 15:31 ` Jan Kiszka
2012-09-11 15:31 ` [Qemu-devel] " Jan Kiszka
2012-09-11 16:15 ` Anthony Liguori
2012-09-11 16:15 ` [Qemu-devel] " Anthony Liguori
2012-09-11 16:33 ` Jan Kiszka
2012-09-11 16:33 ` [Qemu-devel] " Jan Kiszka
2012-09-12 0:01 ` Kevin O'Connor
2012-09-12 0:01 ` [Qemu-devel] " Kevin O'Connor
2012-09-09 15:42 ` Avi Kivity
2012-09-09 15:42 ` [Qemu-devel] " Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=504DB212.3000908@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=aliguori@us.ibm.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=liusheng@linux.vnet.ibm.com \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=xiaoguangrong@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.