From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Xie Shaohui-B21989 <B21989@freescale.com>
Cc: Kumar Gala <galak@kernel.crashing.org>,
"jgarzik@pobox.com" <jgarzik@pobox.com>,
"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Bhartiya Anju-B07263 <B07263@freescale.com>
Subject: Re: [PATCH][v3] sata_fsl: add workaround for data length mismatch on freescale V2 controller
Date: Mon, 10 Sep 2012 14:21:49 +0400 [thread overview]
Message-ID: <504DBF3D.2000102@mvista.com> (raw)
In-Reply-To: <ED492CCEAF882048BC2237DE806547C9079D9AB9@039-SN2MPN1-012.039d.mgd.msft.net>
Hello.
On 10-09-2012 6:53, Xie Shaohui-B21989 wrote:
>>> + /* Workaround for data length mismatch errata */
>>> + if (unlikely(hstatus & INT_ON_DATA_LENGTH_MISMATCH)) {
>>> + for (tag = 0; tag < ATA_MAX_QUEUE; tag++) {
>>> + qc = ata_qc_from_tag(ap, tag);
>>> + if (qc && ata_is_atapi(qc->tf.protocol)) {
>>> + u32 hcontrol;
>>> +#define HCONTROL_CLEAR_ERROR (1 << 27)
>> shouldn't we have this #define be part of the enum that the other
>> HCONTROL_ bits/flags are part of?
> [S.H] do you mean this?
Apparently not. He said *enum*, not #define.
> #ifdef SATA_FSL_XXX_ERRATUAM
We don't need that at all.
> #define HCONTROL_CLEAR_ERROR (1 << 27)
> #endif
MBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Xie Shaohui-B21989 <B21989@freescale.com>
Cc: "jgarzik@pobox.com" <jgarzik@pobox.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
Bhartiya Anju-B07263 <B07263@freescale.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH][v3] sata_fsl: add workaround for data length mismatch on freescale V2 controller
Date: Mon, 10 Sep 2012 14:21:49 +0400 [thread overview]
Message-ID: <504DBF3D.2000102@mvista.com> (raw)
In-Reply-To: <ED492CCEAF882048BC2237DE806547C9079D9AB9@039-SN2MPN1-012.039d.mgd.msft.net>
Hello.
On 10-09-2012 6:53, Xie Shaohui-B21989 wrote:
>>> + /* Workaround for data length mismatch errata */
>>> + if (unlikely(hstatus & INT_ON_DATA_LENGTH_MISMATCH)) {
>>> + for (tag = 0; tag < ATA_MAX_QUEUE; tag++) {
>>> + qc = ata_qc_from_tag(ap, tag);
>>> + if (qc && ata_is_atapi(qc->tf.protocol)) {
>>> + u32 hcontrol;
>>> +#define HCONTROL_CLEAR_ERROR (1 << 27)
>> shouldn't we have this #define be part of the enum that the other
>> HCONTROL_ bits/flags are part of?
> [S.H] do you mean this?
Apparently not. He said *enum*, not #define.
> #ifdef SATA_FSL_XXX_ERRATUAM
We don't need that at all.
> #define HCONTROL_CLEAR_ERROR (1 << 27)
> #endif
MBR, Sergei
next prev parent reply other threads:[~2012-09-10 10:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-07 10:01 [PATCH][v3] sata_fsl: add workaround for data length mismatch on freescale V2 controller Shaohui Xie
2012-09-07 10:01 ` Shaohui Xie
2012-09-07 10:01 ` Shaohui Xie
2012-09-07 12:37 ` Kumar Gala
2012-09-07 12:37 ` Kumar Gala
2012-09-07 12:37 ` Kumar Gala
2012-09-10 2:53 ` Xie Shaohui-B21989
2012-09-10 2:53 ` Xie Shaohui-B21989
2012-09-10 2:53 ` Xie Shaohui-B21989
2012-09-10 10:21 ` Sergei Shtylyov [this message]
2012-09-10 10:21 ` Sergei Shtylyov
2012-09-10 10:45 ` Xie Shaohui-B21989
2012-09-10 10:45 ` Xie Shaohui-B21989
2012-09-10 10:45 ` Xie Shaohui-B21989
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=504DBF3D.2000102@mvista.com \
--to=sshtylyov@mvista.com \
--cc=B07263@freescale.com \
--cc=B21989@freescale.com \
--cc=galak@kernel.crashing.org \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.