From: Glauber Costa <glommer@parallels.com>
To: Fengguang Wu <fengguang.wu@intel.com>
Cc: kernel-janitors@vger.kernel.org,
Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: [glommer-memcg:kmemcg-slab 57/62] drivers/video/riva/fbdev.c:281:9: sparse: preprocessor token M
Date: Mon, 10 Sep 2012 12:58:02 +0000 [thread overview]
Message-ID: <504DE3DA.7000802@parallels.com> (raw)
In-Reply-To: <20120910125759.GA11808@localhost>
On 09/10/2012 04:57 PM, Fengguang Wu wrote:
> Glauber,
>
> The patch entitled
>
> sl[au]b: Allocate objects from memcg cache
>
> changes
>
> include/linux/slub_def.h | 15 ++++++++++-----
>
> which triggers this warning:
>
> drivers/video/riva/fbdev.c:281:9: sparse: preprocessor token MAX_LEVEL redefined
>
> It's the MAX_LEVEL that is defined in include/linux/idr.h.
>
> MAX_LEVEL is obviously too generic. Better adding some prefix to it?
>
I don't see any MAX_LEVEL definition in this patch. You say it is
defined in include/linux/idr.h, and as the diffstat shows, I am not
touching this file.
I think this needs patching independently.
WARNING: multiple messages have this Message-ID (diff)
From: Glauber Costa <glommer@parallels.com>
To: Fengguang Wu <fengguang.wu@intel.com>
Cc: kernel-janitors@vger.kernel.org,
Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: [glommer-memcg:kmemcg-slab 57/62] drivers/video/riva/fbdev.c:281:9: sparse: preprocessor token MAX_LEVEL redefined
Date: Mon, 10 Sep 2012 16:58:02 +0400 [thread overview]
Message-ID: <504DE3DA.7000802@parallels.com> (raw)
In-Reply-To: <20120910125759.GA11808@localhost>
On 09/10/2012 04:57 PM, Fengguang Wu wrote:
> Glauber,
>
> The patch entitled
>
> sl[au]b: Allocate objects from memcg cache
>
> changes
>
> include/linux/slub_def.h | 15 ++++++++++-----
>
> which triggers this warning:
>
> drivers/video/riva/fbdev.c:281:9: sparse: preprocessor token MAX_LEVEL redefined
>
> It's the MAX_LEVEL that is defined in include/linux/idr.h.
>
> MAX_LEVEL is obviously too generic. Better adding some prefix to it?
>
I don't see any MAX_LEVEL definition in this patch. You say it is
defined in include/linux/idr.h, and as the diffstat shows, I am not
touching this file.
I think this needs patching independently.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-09-10 12:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-10 11:16 [glommer-memcg:kmemcg-slab 53/62] mm/memcontrol.c:755:6: sparse: symbol 'memcg_flush_cache_create_qu Fengguang Wu
2012-09-10 12:57 ` [glommer-memcg:kmemcg-slab 57/62] drivers/video/riva/fbdev.c:281:9: sparse: preprocessor token MAX_L Fengguang Wu
2012-09-10 12:57 ` [glommer-memcg:kmemcg-slab 57/62] drivers/video/riva/fbdev.c:281:9: sparse: preprocessor token MAX_LEVEL redefined Fengguang Wu
2012-09-10 12:58 ` Glauber Costa [this message]
2012-09-10 12:58 ` Glauber Costa
2012-09-10 13:06 ` [glommer-memcg:kmemcg-slab 57/62] drivers/video/riva/fbdev.c:281:9: sparse: preprocessor token M Fengguang Wu
2012-09-10 13:06 ` [glommer-memcg:kmemcg-slab 57/62] drivers/video/riva/fbdev.c:281:9: sparse: preprocessor token MAX_LEVEL redefined Fengguang Wu
2012-09-10 14:02 ` [glommer-memcg:kmemcg-slab 57/62] drivers/video/riva/fbdev.c:281:9: sparse: preprocessor token M Glauber Costa
2012-09-10 14:02 ` [glommer-memcg:kmemcg-slab 57/62] drivers/video/riva/fbdev.c:281:9: sparse: preprocessor token MAX_LEVEL redefined Glauber Costa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=504DE3DA.7000802@parallels.com \
--to=glommer@parallels.com \
--cc=fengguang.wu@intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.