From: Benoit Cousson <b-cousson@ti.com>
To: florian.vaussard@epfl.ch
Cc: Tony Lindgren <tony@atomide.com>,
Steve Sakoman <steve@sakoman.com>,
linux-omap@vger.kernel.org, devicetree-discuss@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/1] ARM: dts: OMAP3: Add gpio-twl4030 properties for Overo
Date: Mon, 10 Sep 2012 15:40:04 +0200 [thread overview]
Message-ID: <504DEDB4.1070804@ti.com> (raw)
In-Reply-To: <504DEC36.4020704@epfl.ch>
On 09/10/2012 03:33 PM, Florian Vaussard wrote:
>>> Support the blue LED connected to the LEDB pin of the TWL4030
>>> on the Gumstix Overo.
>>>
>>> Signed-off-by: Florian Vaussard <florian.vaussard@epfl.ch>
>>> ---
>>> arch/arm/boot/dts/omap3-overo.dtsi | 15 +++++++++++++++
>>> 1 files changed, 15 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/arch/arm/boot/dts/omap3-overo.dtsi
>>> b/arch/arm/boot/dts/omap3-overo.dtsi
>>> index d6cc5e2..89808ce 100644
>>> --- a/arch/arm/boot/dts/omap3-overo.dtsi
>>> +++ b/arch/arm/boot/dts/omap3-overo.dtsi
>>> @@ -13,6 +13,17 @@
>>>
>>> /include/ "omap3.dtsi"
>>>
>>> +/ {
>>
>> BTW, I'm just wondering. Cannot we use overo without tobi?
>>
>> In that case, the model and compatible should probably be used as well:
>>
>> model = "TI OMAP3 Gumstix Overo";
>> compatible = "ti,omap3-overo", "ti,omap3";
>
> No, it cannot. The Overo needs to be plugged into an expansion board, at
> least to get the power. Hence the absence of model and compatible in
> omap3-overo.dtsi.
OK, cool. I was wondering because we already have a board-overo.c in the
kernel, and there is no mention of tobi.
OK, I'm adding that patch on top of the other then.
Regards,
Benoit
WARNING: multiple messages have this Message-ID (diff)
From: b-cousson@ti.com (Benoit Cousson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/1] ARM: dts: OMAP3: Add gpio-twl4030 properties for Overo
Date: Mon, 10 Sep 2012 15:40:04 +0200 [thread overview]
Message-ID: <504DEDB4.1070804@ti.com> (raw)
In-Reply-To: <504DEC36.4020704@epfl.ch>
On 09/10/2012 03:33 PM, Florian Vaussard wrote:
>>> Support the blue LED connected to the LEDB pin of the TWL4030
>>> on the Gumstix Overo.
>>>
>>> Signed-off-by: Florian Vaussard <florian.vaussard@epfl.ch>
>>> ---
>>> arch/arm/boot/dts/omap3-overo.dtsi | 15 +++++++++++++++
>>> 1 files changed, 15 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/arch/arm/boot/dts/omap3-overo.dtsi
>>> b/arch/arm/boot/dts/omap3-overo.dtsi
>>> index d6cc5e2..89808ce 100644
>>> --- a/arch/arm/boot/dts/omap3-overo.dtsi
>>> +++ b/arch/arm/boot/dts/omap3-overo.dtsi
>>> @@ -13,6 +13,17 @@
>>>
>>> /include/ "omap3.dtsi"
>>>
>>> +/ {
>>
>> BTW, I'm just wondering. Cannot we use overo without tobi?
>>
>> In that case, the model and compatible should probably be used as well:
>>
>> model = "TI OMAP3 Gumstix Overo";
>> compatible = "ti,omap3-overo", "ti,omap3";
>
> No, it cannot. The Overo needs to be plugged into an expansion board, at
> least to get the power. Hence the absence of model and compatible in
> omap3-overo.dtsi.
OK, cool. I was wondering because we already have a board-overo.c in the
kernel, and there is no mention of tobi.
OK, I'm adding that patch on top of the other then.
Regards,
Benoit
next prev parent reply other threads:[~2012-09-10 13:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-10 13:16 [PATCH 0/1] ARM: dts: OMAP3: Add gpio-twl4030 properties for Overo Florian Vaussard
2012-09-10 13:16 ` Florian Vaussard
2012-09-10 13:16 ` [PATCH 1/1] " Florian Vaussard
2012-09-10 13:16 ` Florian Vaussard
[not found] ` <1347282996-31190-2-git-send-email-florian.vaussard-p8DiymsW2f8@public.gmane.org>
2012-09-10 13:25 ` Benoit Cousson
2012-09-10 13:25 ` Benoit Cousson
2012-09-10 13:33 ` Florian Vaussard
2012-09-10 13:33 ` Florian Vaussard
2012-09-10 13:40 ` Benoit Cousson [this message]
2012-09-10 13:40 ` Benoit Cousson
[not found] ` <504DEDB4.1070804-l0cyMroinI0@public.gmane.org>
2012-09-10 13:49 ` Benoit Cousson
2012-09-10 13:49 ` Benoit Cousson
2012-09-10 14:07 ` Florian Vaussard
2012-09-10 14:07 ` Florian Vaussard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=504DEDB4.1070804@ti.com \
--to=b-cousson@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=florian.vaussard@epfl.ch \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=steve@sakoman.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.