All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Fengguang Wu <fengguang.wu@intel.com>
Cc: kernel-janitors@vger.kernel.org, Felipe Balbi <balbi@ti.com>,
	linux-omap@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [balbi-usb:gadget 58/62] drivers/usb/gadget/ether.c:113:1: error: expected ')' before '.' token
Date: Mon, 10 Sep 2012 14:06:48 +0000	[thread overview]
Message-ID: <504DF3F8.6080208@linutronix.de> (raw)
In-Reply-To: <20120910135441.GA12990@localhost>

On 09/10/2012 03:54 PM, Fengguang Wu wrote:
> tree:   git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git gadget
> head:   7a7322b0a5d984025dd4faea9098b8fef07f8d8f
> commit: 721e2e91945bc2520d57d795dfe1b502ecec567c [58/62] usb: gadget: libcomposite: move composite.c into libcomposite
> config: x86_64-randconfig-s284 (attached as .config)
>
> All related error/warning messages:
>
> In file included from drivers/usb/gadget/ether.c:110:0:
> drivers/usb/gadget/u_ether.c:87:21: error: expected ')' before 'uint'

That is the problem. u_ether.c lacks a "#include <linux/module.h>". It
built here because I had rndis & EEM which included that file…

Thanks for finding this so quickly.

Felipe, patch on top or do fix up this commit?

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Fengguang Wu <fengguang.wu@intel.com>
Cc: kernel-janitors@vger.kernel.org, Felipe Balbi <balbi@ti.com>,
	linux-omap@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [balbi-usb:gadget 58/62] drivers/usb/gadget/ether.c:113:1: error: expected ')' before '.' token
Date: Mon, 10 Sep 2012 16:06:48 +0200	[thread overview]
Message-ID: <504DF3F8.6080208@linutronix.de> (raw)
In-Reply-To: <20120910135441.GA12990@localhost>

On 09/10/2012 03:54 PM, Fengguang Wu wrote:
> tree:   git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git gadget
> head:   7a7322b0a5d984025dd4faea9098b8fef07f8d8f
> commit: 721e2e91945bc2520d57d795dfe1b502ecec567c [58/62] usb: gadget: libcomposite: move composite.c into libcomposite
> config: x86_64-randconfig-s284 (attached as .config)
>
> All related error/warning messages:
>
> In file included from drivers/usb/gadget/ether.c:110:0:
> drivers/usb/gadget/u_ether.c:87:21: error: expected ')' before 'uint'

That is the problem. u_ether.c lacks a "#include <linux/module.h>". It
built here because I had rndis & EEM which included that file…

Thanks for finding this so quickly.

Felipe, patch on top or do fix up this commit?

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2012-09-10 14:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-10 13:54 [balbi-usb:gadget 58/62] drivers/usb/gadget/ether.c:113:1: error: expected ')' before '.' token Fengguang Wu
2012-09-10 13:54 ` Fengguang Wu
2012-09-10 14:06 ` Sebastian Andrzej Siewior [this message]
2012-09-10 14:06   ` Sebastian Andrzej Siewior
2012-09-10 14:18   ` Felipe Balbi
2012-09-10 14:18     ` Felipe Balbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=504DF3F8.6080208@linutronix.de \
    --to=bigeasy@linutronix.de \
    --cc=balbi@ti.com \
    --cc=fengguang.wu@intel.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.