From: Adam Jackson <ajax@redhat.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915: rip out edp special case from dp_link_down
Date: Mon, 10 Sep 2012 12:15:40 -0400 [thread overview]
Message-ID: <504E122C.6070707@redhat.com> (raw)
In-Reply-To: <1347213536-20340-1-git-send-email-daniel.vetter@ffwll.ch>
On 9/9/12 1:58 PM, Daniel Vetter wrote:
> The really interesting question is how this special cases survived
> this long in the code. The first step is declaring the pch port D as
> eDP if it's used for an internal panel:
>
> commit b329530ca7cdf6bf014f2124efd983e01265d623
> Author: Adam Jackson <ajax@redhat.com>
> Date: Fri Jul 16 14:46:28 2010 -0400
>
> drm/i915/dp: Correctly report eDP in the core connector type
>
> This commit unfortunately failed to notice that not all edp ports are
> created equal. Then follow a flurry of refactorings, culminating in a
> patch from Keith Packard which resulted in the current logic (by
> making it "correct" for all platforms that have edp):
The motivation for this patch was simply making eDP connectors be
reported as eDP, since that has the same "probably special" properties
as LVDS (correlation with lid state, probably the primary if no better
guidance given, etc).
- ajax
next prev parent reply other threads:[~2012-09-10 16:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-09 17:58 [PATCH] drm/i915: rip out edp special case from dp_link_down Daniel Vetter
2012-09-10 16:15 ` Adam Jackson [this message]
2012-09-13 22:17 ` Paulo Zanoni
2012-09-14 16:33 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=504E122C.6070707@redhat.com \
--to=ajax@redhat.com \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.