All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ryan Mallon <rmallon@gmail.com>
To: Jingoo Han <jg1.han@samsung.com>
Cc: "'Grant Likely'" <grant.likely@secretlab.ca>,
	"'Linus Walleij'" <linus.walleij@linaro.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gpio: samsung: use pr_* instead of printk
Date: Tue, 11 Sep 2012 16:08:31 +1000	[thread overview]
Message-ID: <504ED55F.9060701@gmail.com> (raw)
In-Reply-To: <002f01cd8f4b$b1100a30$13301e90$%han@samsung.com>

On 10/09/12 21:59, Jingoo Han wrote:
> This patch uses pr_* instead of printk.
> 
> Signed-off-by: Jingoo Han <jg1.han@samsung.com> --- 
> drivers/gpio/gpio-samsung.c |    6 +++--- 1 files changed, 3
> insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpio/gpio-samsung.c
> b/drivers/gpio/gpio-samsung.c index ba126cc..e38d990 100644 ---
> a/drivers/gpio/gpio-samsung.c +++ b/drivers/gpio/gpio-samsung.c @@
> -45,7 +45,7 @@ #ifndef DEBUG_GPIO #define gpio_dbg(x...) do { } while
> (0) #else -#define gpio_dbg(x...) printk(KERN_DEBUG x) +#define
> gpio_dbg(x...) pr_debug(x)

This is a functional change since pr_debug compiles away to nothing
unless DEBUG is defined, so now you need to define both DEBUG and
DEBUG_GPIO for this to print.

A better fix would be to just replace calls to gpio_dbg with pr_debug.

~Ryan

  reply	other threads:[~2012-09-11  6:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-10 11:59 [PATCH] gpio: samsung: use pr_* instead of printk Jingoo Han
2012-09-11  6:08 ` Ryan Mallon [this message]
2012-09-11  6:35   ` Jingoo Han
2012-09-11  6:30 ` Felipe Balbi
2012-09-11  6:39   ` Jingoo Han
2012-09-11  6:48     ` Ryan Mallon
2012-09-11  7:02       ` Jingoo Han
2012-09-11 11:57         ` Felipe Balbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=504ED55F.9060701@gmail.com \
    --to=rmallon@gmail.com \
    --cc=grant.likely@secretlab.ca \
    --cc=jg1.han@samsung.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.