All of lore.kernel.org
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: Alexander Graf <agraf@suse.de>
Cc: "Wood Scott-B07421" <B07421@freescale.com>,
	"qemu-ppc@nongnu.org" <qemu-ppc@nongnu.org>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	"Andreas Färber" <afaerber@suse.de>,
	"Bhushan Bharat-R65777" <R65777@freescale.com>
Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH: RFC] Adding BAR0 for e500 PCI controller
Date: Tue, 11 Sep 2012 14:05:19 -0500	[thread overview]
Message-ID: <504F8B6F.3040608@freescale.com> (raw)
In-Reply-To: <504F217C.80408@suse.de>

On 09/11/2012 06:33 AM, Alexander Graf wrote:
> On 09/07/2012 08:58 PM, Scott Wood wrote:
>> I wasn't suggesting that they be different devices.  I was suggesting
>> that this isn't a property of the PCI controller, but rather of some
>> other entity to which the PCI controller connects.  So maybe a reference
>> to the associated CCSR object would be a qdev parameter, but not the
>> size of that CCSR.
> 
> The first common place of information we get is the machine description.
> So here we can do:
> 
>   create_device(e500_ccsr, CCSR_SIZE);
>   create_device(e500_pci_host_controller, CCSR_SIZE);
> 
> Obviously code-wise this would look quite different from above, as
> object constructor parameters go through qdev properties.

Keep in mind that in order to make MSIs work we need the BAR to actually
be hooked up to CCSR, not just sized properly.  If qdev properties are
really stable API as you indicated recently, we want to get this right
and not introduce a short-term hack.

-Scott

  reply	other threads:[~2012-09-11 19:20 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-14 12:50 [Qemu-devel] [PATCH: RFC] Adding BAR0 for e500 PCI controller Bharat Bhushan
2012-08-15  1:29 ` [Qemu-devel] [Qemu-ppc] " Scott Wood
2012-08-15  2:40   ` Bhushan Bharat-R65777
2012-09-03  6:44   ` Bhushan Bharat-R65777
2012-09-06 23:15     ` Scott Wood
2012-09-07  8:08       ` Alexander Graf
2012-09-07 18:58         ` Scott Wood
2012-09-11 11:33           ` Alexander Graf
2012-09-11 19:05             ` Scott Wood [this message]
2012-09-11 20:58               ` Alexander Graf
2012-09-11 12:23           ` Andreas Färber
2012-09-11 12:27             ` Alexander Graf
2012-09-11 12:59               ` Andreas Färber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=504F8B6F.3040608@freescale.com \
    --to=scottwood@freescale.com \
    --cc=B07421@freescale.com \
    --cc=R65777@freescale.com \
    --cc=afaerber@suse.de \
    --cc=agraf@suse.de \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.