All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] sms: Fix to find SMS entry posted by STK
@ 2012-08-30 16:24 Philippe Nunes
  2012-09-12  3:34 ` Denis Kenzior
  0 siblings, 1 reply; 2+ messages in thread
From: Philippe Nunes @ 2012-08-30 16:24 UTC (permalink / raw)
  To: ofono

[-- Attachment #1: Type: text/plain, Size: 901 bytes --]

SMS initiated by proactive command are not exposed on D-BUS.
Therefore, there is no message associated with the entry created from
STK.
---
 src/sms.c |   11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/src/sms.c b/src/sms.c
index acfc39b..743f725 100644
--- a/src/sms.c
+++ b/src/sms.c
@@ -2114,16 +2114,15 @@ int __ofono_sms_txq_set_submit_notify(struct ofono_sms *sms,
 					void *data,
 					ofono_destroy_func destroy)
 {
-	struct message *m;
+	GList *l;
 	struct tx_queue_entry *entry;
 
-	m = g_hash_table_lookup(sms->messages, uuid);
-	if (m == NULL)
+	l = g_queue_find_custom(sms->txq, uuid, entry_compare_by_uuid);
+
+	if (l == NULL)
 		return -ENOENT;
 
-	entry = message_get_data(m);
-	if (entry == NULL)
-		return -ENOTSUP;
+	entry = l->data;
 
 	tx_queue_entry_set_submit_notify(entry, cb, data, destroy);
 
-- 
1.7.9.5


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] sms: Fix to find SMS entry posted by STK
  2012-08-30 16:24 [PATCH] sms: Fix to find SMS entry posted by STK Philippe Nunes
@ 2012-09-12  3:34 ` Denis Kenzior
  0 siblings, 0 replies; 2+ messages in thread
From: Denis Kenzior @ 2012-09-12  3:34 UTC (permalink / raw)
  To: ofono

[-- Attachment #1: Type: text/plain, Size: 362 bytes --]

Hi Philippe,

On 08/30/2012 11:24 AM, Philippe Nunes wrote:
> SMS initiated by proactive command are not exposed on D-BUS.
> Therefore, there is no message associated with the entry created from
> STK.
> ---
>   src/sms.c |   11 +++++------
>   1 file changed, 5 insertions(+), 6 deletions(-)
>

Patch has been applied, thanks.

Regards,
-Denis


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-09-12  3:34 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-30 16:24 [PATCH] sms: Fix to find SMS entry posted by STK Philippe Nunes
2012-09-12  3:34 ` Denis Kenzior

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.