Re: [Qemu-devel] [PATCH] configure: usbredir fixes

[Michael Tokarev <mjt@tls.msk.ru>]

On 11.09.2012 22:57, Aurelien Jarno wrote:
> usbredir is only used by system emulation, so add the libraries to
> libs_softmmu instead of LIBS.

Fwiw, original code breaks user-static build - not it only
tries to link with unused library but also some distros
does not package/provide static (.a) library for
libusbredirparser (I dunno if it is a general issue).

This patch fixes that.  It has been in Debian as a bugfix
since the time usbredir were introduced.

> Cc: Michael Tokarev <mjt@tls.msk.ru>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> ---
>  configure |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index 7656c32..cf2621a 100755
> --- a/configure
> +++ b/configure
> @@ -2763,7 +2763,7 @@ if test "$usb_redir" != "no" ; then
>          usb_redir_cflags=$($pkg_config --cflags libusbredirparser 2>/dev/null)
>          usb_redir_libs=$($pkg_config --libs libusbredirparser 2>/dev/null)
>          QEMU_CFLAGS="$QEMU_CFLAGS $usb_redir_cflags"
> -        LIBS="$LIBS $usb_redir_libs"
> +        libs_softmmu="$LIBS $usb_redir_libs"
>      else
>          if test "$usb_redir" = "yes"; then
>              feature_not_found "usb-redir"