From: Huang Shijie <b32955@freescale.com>
To: Vikram Narayanan <vikram186@gmail.com>
Cc: dirk.behme@de.bosch.com, dedekind1@gmail.com,
linux-mtd@lists.infradead.org, ffainelli@freebox.fr,
shawn.guo@linaro.org, dwmw2@infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 6/9] mtd: gpmi: simplify the setting DLL code
Date: Wed, 12 Sep 2012 15:00:02 +0800 [thread overview]
Message-ID: <505032F2.4090102@freescale.com> (raw)
In-Reply-To: <504F7E10.8030406@gmail.com>
于 2012年09月12日 02:08, Vikram Narayanan 写道:
>>
>> /*
>> * After we enable the GPMI DLL, we have to wait 64 clock cycles before
>> - * we can use the GPMI.
>> - *
>> - * Calculate the amount of time we need to wait, in microseconds.
>> + * we can use the GPMI. Calculate the amount of time we need to wait,
>> + * in microseconds.
>> */
>> clock_period_in_ns = 1000000000 / clk_get_rate(r->clock[0]);
>
> NSEC_PER_SEC macro in the above statement?
>
> Don't curse me for commenting about the code that you've not written.
> As this patch does some cleanups, I'm suggesting this.
I finally get what's your meaning. thanks for you review :)
I really appreciate it.
Best Regards
Huang Shijie
WARNING: multiple messages have this Message-ID (diff)
From: b32955@freescale.com (Huang Shijie)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 6/9] mtd: gpmi: simplify the setting DLL code
Date: Wed, 12 Sep 2012 15:00:02 +0800 [thread overview]
Message-ID: <505032F2.4090102@freescale.com> (raw)
In-Reply-To: <504F7E10.8030406@gmail.com>
? 2012?09?12? 02:08, Vikram Narayanan ??:
>>
>> /*
>> * After we enable the GPMI DLL, we have to wait 64 clock cycles before
>> - * we can use the GPMI.
>> - *
>> - * Calculate the amount of time we need to wait, in microseconds.
>> + * we can use the GPMI. Calculate the amount of time we need to wait,
>> + * in microseconds.
>> */
>> clock_period_in_ns = 1000000000 / clk_get_rate(r->clock[0]);
>
> NSEC_PER_SEC macro in the above statement?
>
> Don't curse me for commenting about the code that you've not written.
> As this patch does some cleanups, I'm suggesting this.
I finally get what's your meaning. thanks for you review :)
I really appreciate it.
Best Regards
Huang Shijie
next prev parent reply other threads:[~2012-09-12 7:00 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-11 6:17 [PATCH 0/9] add EDO feature for gpmi-nand driver Huang Shijie
2012-09-11 6:17 ` Huang Shijie
2012-09-11 6:17 ` [PATCH 1/9] mtd: add helpers to set/get features for ONFI nand Huang Shijie
2012-09-11 6:17 ` Huang Shijie
2012-09-11 6:17 ` [PATCH 2/9] mtd: add helpers to get the supportted ONFI timing mode Huang Shijie
2012-09-11 6:17 ` Huang Shijie
2012-09-11 6:17 ` [PATCH 3/9] mtd: gpmi: add a new field for HW_GPMI_TIMING1 Huang Shijie
2012-09-11 6:17 ` Huang Shijie
2012-09-11 18:00 ` Vikram Narayanan
2012-09-11 18:00 ` Vikram Narayanan
2012-09-12 2:15 ` Huang Shijie
2012-09-12 2:15 ` Huang Shijie
2012-09-12 17:10 ` Vikram Narayanan
2012-09-11 6:17 ` [PATCH 4/9] mtd: gpmi: do not get the clock frequency in gpmi_begin() Huang Shijie
2012-09-11 6:17 ` Huang Shijie
2012-09-11 6:17 ` [PATCH 5/9] mtd: gpmi: add a new field for HW_GPMI_CTRL1 Huang Shijie
2012-09-11 6:17 ` Huang Shijie
2012-09-11 18:04 ` Vikram Narayanan
2012-09-11 18:04 ` Vikram Narayanan
2012-09-12 2:18 ` Huang Shijie
2012-09-12 2:18 ` Huang Shijie
2012-09-11 6:17 ` [PATCH 6/9] mtd: gpmi: simplify the setting DLL code Huang Shijie
2012-09-11 6:17 ` Huang Shijie
2012-09-11 18:08 ` Vikram Narayanan
2012-09-11 18:08 ` Vikram Narayanan
2012-09-12 2:28 ` Huang Shijie
2012-09-12 2:28 ` Huang Shijie
2012-09-12 7:00 ` Huang Shijie [this message]
2012-09-12 7:00 ` Huang Shijie
2012-09-11 6:17 ` [PATCH 7/9] mtd: gpmi: do not set the default values for the extra clocks Huang Shijie
2012-09-11 6:17 ` Huang Shijie
2012-09-11 6:17 ` [PATCH 8/9] mtd: gpmi: add EDO feature for imx6q Huang Shijie
2012-09-11 6:17 ` Huang Shijie
2012-09-11 6:17 ` [PATCH 9/9] mtd: gpmi: initialize the timing registers only one time Huang Shijie
2012-09-11 6:17 ` Huang Shijie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=505032F2.4090102@freescale.com \
--to=b32955@freescale.com \
--cc=dedekind1@gmail.com \
--cc=dirk.behme@de.bosch.com \
--cc=dwmw2@infradead.org \
--cc=ffainelli@freebox.fr \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=shawn.guo@linaro.org \
--cc=vikram186@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.