From: David Waring <david.waring@rd.bbc.co.uk>
To: Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: Antti Palosaari <crope@iki.fi>, linux-media@vger.kernel.org
Subject: Re: [PATCH 6/6] DVB API: LNA documentation
Date: Wed, 12 Sep 2012 12:01:48 +0100 [thread overview]
Message-ID: <50506B9C.5080705@rd.bbc.co.uk> (raw)
In-Reply-To: <504F851B.5040600@redhat.com>
On 11/09/12 19:38, Mauro Carvalho Chehab wrote:
> Em 16-08-2012 22:35, Antti Palosaari escreveu:
>> [snip]
>> + <para>Possible values: 0, 1, INT_MIN</para>
>
> Hmm... INT_MIN... are you sure it is portable on all Linux compilers?
>
> I don't like the idea on trusting on whatever C/C++/Java/... compiler (or some interpreter)
> would define as "INT_MIN".
>
> The better is to define a value for that, or, instead, to define something
> at the API header file that won't cause troubles with 32 bits or 64 bits
> userspace, like defining it as:
>
> #define DVB_AUTO_LNA ((u32)~0)
>
INT_MIN is defined in limits.h which is an ISO standard header. Other
parts of the kernel also use INT_MIN, e.g. linux/cpu.h and
linux/netfilter_ipv4.h both reference INT_MIN from limits.h.
--
David Waring, Software Engineer, BBC Research & Development
next prev parent reply other threads:[~2012-09-12 11:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-17 1:35 [PATCH 0/6] DVB API LNA Antti Palosaari
2012-08-17 1:35 ` [PATCH 1/6] add LNA support for DVB API Antti Palosaari
2012-08-17 1:35 ` [PATCH 2/6] cxd2820r: switch to Kernel dev_* logging Antti Palosaari
2012-08-17 1:35 ` [PATCH 3/6] cxd2820r: use Kernel GPIO for GPIO access Antti Palosaari
2012-08-17 1:35 ` [PATCH 4/6] em28xx: implement FE set_lna() callback Antti Palosaari
2012-08-17 1:35 ` [PATCH 5/6] cxd2820r: GPIO when GPIOLIB is undefined Antti Palosaari
2012-08-17 1:35 ` [PATCH 6/6] DVB API: LNA documentation Antti Palosaari
2012-09-11 18:38 ` Mauro Carvalho Chehab
2012-09-12 11:01 ` David Waring [this message]
2012-09-12 12:45 ` Mauro Carvalho Chehab
2012-09-16 0:36 ` Antti Palosaari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50506B9C.5080705@rd.bbc.co.uk \
--to=david.waring@rd.bbc.co.uk \
--cc=crope@iki.fi \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.