From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: Antti Palosaari <crope@iki.fi>
Cc: linux-media@vger.kernel.org, Hin-Tak Leung <htl10@users.sourceforge.net>
Subject: Re: [PATCH 6/6] DVB API: LNA documentation
Date: Tue, 11 Sep 2012 15:38:19 -0300 [thread overview]
Message-ID: <504F851B.5040600@redhat.com> (raw)
In-Reply-To: <1345167310-8738-7-git-send-email-crope@iki.fi>
Em 16-08-2012 22:35, Antti Palosaari escreveu:
> Signed-off-by: Antti Palosaari <crope@iki.fi>
> ---
> Documentation/DocBook/media/dvb/dvbproperty.xml | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/Documentation/DocBook/media/dvb/dvbproperty.xml b/Documentation/DocBook/media/dvb/dvbproperty.xml
> index d188be9..2dfa6a0 100644
> --- a/Documentation/DocBook/media/dvb/dvbproperty.xml
> +++ b/Documentation/DocBook/media/dvb/dvbproperty.xml
> @@ -827,6 +827,17 @@ enum fe_interleaving {
> };
> </programlisting>
> </section>
> + <section id="DTV-LNA">
> + <title><constant>DTV_LNA</constant></title>
> + <para>Low-noise amplifier.</para>
> + <para>Hardware might offer controllable LNA which can be set manually
> + using that parameter. Usually LNA could be found only from
> + terrestrial devices if at all.</para>
> + <para>Possible values: 0, 1, INT_MIN</para>
Hmm... INT_MIN... are you sure it is portable on all Linux compilers?
I don't like the idea on trusting on whatever C/C++/Java/... compiler (or some interpreter)
would define as "INT_MIN".
The better is to define a value for that, or, instead, to define something
at the API header file that won't cause troubles with 32 bits or 64 bits
userspace, like defining it as:
#define DVB_AUTO_LNA ((u32)~0)
> + <para>0, LNA off</para>
> + <para>1, LNA on</para>
> + <para>INT_MIN, LNA auto</para>
> + </section>
> </section>
> <section id="frontend-property-terrestrial-systems">
> <title>Properties used on terrestrial delivery systems</title>
> @@ -847,6 +858,7 @@ enum fe_interleaving {
> <listitem><para><link linkend="DTV-GUARD-INTERVAL"><constant>DTV_GUARD_INTERVAL</constant></link></para></listitem>
> <listitem><para><link linkend="DTV-TRANSMISSION-MODE"><constant>DTV_TRANSMISSION_MODE</constant></link></para></listitem>
> <listitem><para><link linkend="DTV-HIERARCHY"><constant>DTV_HIERARCHY</constant></link></para></listitem>
> + <listitem><para><link linkend="DTV-LNA"><constant>DTV_LNA</constant></link></para></listitem>
> </itemizedlist>
> </section>
> <section id="dvbt2-params">
> @@ -870,6 +882,7 @@ enum fe_interleaving {
> <listitem><para><link linkend="DTV-TRANSMISSION-MODE"><constant>DTV_TRANSMISSION_MODE</constant></link></para></listitem>
> <listitem><para><link linkend="DTV-HIERARCHY"><constant>DTV_HIERARCHY</constant></link></para></listitem>
> <listitem><para><link linkend="DTV-DVBT2-PLP-ID"><constant>DTV_DVBT2_PLP_ID</constant></link></para></listitem>
> + <listitem><para><link linkend="DTV-LNA"><constant>DTV_LNA</constant></link></para></listitem>
> </itemizedlist>
> </section>
> <section id="isdbt">
> @@ -981,6 +994,7 @@ enum fe_interleaving {
> <listitem><para><link linkend="DTV-GUARD-INTERVAL"><constant>DTV_GUARD_INTERVAL</constant></link></para></listitem>
> <listitem><para><link linkend="DTV-TRANSMISSION-MODE"><constant>DTV_TRANSMISSION_MODE</constant></link></para></listitem>
> <listitem><para><link linkend="DTV-INTERLEAVING"><constant>DTV_INTERLEAVING</constant></link></para></listitem>
> + <listitem><para><link linkend="DTV-LNA"><constant>DTV_LNA</constant></link></para></listitem>
> </itemizedlist>
> </section>
> </section>
> @@ -1001,6 +1015,7 @@ enum fe_interleaving {
> <listitem><para><link linkend="DTV-INVERSION"><constant>DTV_INVERSION</constant></link></para></listitem>
> <listitem><para><link linkend="DTV-SYMBOL-RATE"><constant>DTV_SYMBOL_RATE</constant></link></para></listitem>
> <listitem><para><link linkend="DTV-INNER-FEC"><constant>DTV_INNER_FEC</constant></link></para></listitem>
> + <listitem><para><link linkend="DTV-LNA"><constant>DTV_LNA</constant></link></para></listitem>
> </itemizedlist>
> </section>
> <section id="dvbc-annex-b-params">
> @@ -1015,6 +1030,7 @@ enum fe_interleaving {
> <listitem><para><link linkend="DTV-FREQUENCY"><constant>DTV_FREQUENCY</constant></link></para></listitem>
> <listitem><para><link linkend="DTV-MODULATION"><constant>DTV_MODULATION</constant></link></para></listitem>
> <listitem><para><link linkend="DTV-INVERSION"><constant>DTV_INVERSION</constant></link></para></listitem>
> + <listitem><para><link linkend="DTV-LNA"><constant>DTV_LNA</constant></link></para></listitem>
> </itemizedlist>
> </section>
> </section>
>
next prev parent reply other threads:[~2012-09-11 18:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-17 1:35 [PATCH 0/6] DVB API LNA Antti Palosaari
2012-08-17 1:35 ` [PATCH 1/6] add LNA support for DVB API Antti Palosaari
2012-08-17 1:35 ` [PATCH 2/6] cxd2820r: switch to Kernel dev_* logging Antti Palosaari
2012-08-17 1:35 ` [PATCH 3/6] cxd2820r: use Kernel GPIO for GPIO access Antti Palosaari
2012-08-17 1:35 ` [PATCH 4/6] em28xx: implement FE set_lna() callback Antti Palosaari
2012-08-17 1:35 ` [PATCH 5/6] cxd2820r: GPIO when GPIOLIB is undefined Antti Palosaari
2012-08-17 1:35 ` [PATCH 6/6] DVB API: LNA documentation Antti Palosaari
2012-09-11 18:38 ` Mauro Carvalho Chehab [this message]
2012-09-12 11:01 ` David Waring
2012-09-12 12:45 ` Mauro Carvalho Chehab
2012-09-16 0:36 ` Antti Palosaari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=504F851B.5040600@redhat.com \
--to=mchehab@redhat.com \
--cc=crope@iki.fi \
--cc=htl10@users.sourceforge.net \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.