* [PATCH] Replace genphy_update_link() call with phy_read_status()
@ 2012-09-12 11:23 Alexander Sverdlin
0 siblings, 0 replies; only message in thread
From: Alexander Sverdlin @ 2012-09-12 11:23 UTC (permalink / raw)
To: netdev, Andy Fleming, davem
From: Alexander Sverdlin <alexander.sverdlin@sysgo.com>
Replace genphy_update_link() call with phy_read_status()
Code in phy.c should not call genphy_*() functions directly, this breaks PHY layer abstraction.
Some drivers may re-implement "read_status" callback and it's not being called in one place of
PHY state machine, where genphy_update_link() is called instead. So fix it.
For drivers that rely on genphy_* implementation nothing changed, as genphy_read_status() calls
genphy_update_link() anyway.
Signed-off-by: Alexander Sverdlin <alexander.sverdlin@sysgo.com>
---
drivers/net/phy/phy.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
index dfca51d..cfed41c 100644
--- a/drivers/net/phy/phy.c
+++ b/drivers/net/phy/phy.c
@@ -839,7 +839,7 @@ void phy_state_machine(struct work_struct *work)
}
break;
case PHY_FORCING:
- err = genphy_update_link(phydev);
+ err = phy_read_status(phydev);
if (err)
break;
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2012-09-12 11:23 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-12 11:23 [PATCH] Replace genphy_update_link() call with phy_read_status() Alexander Sverdlin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.