All of lore.kernel.org
 help / color / mirror / Atom feed
From: Glauber Costa <glommer@parallels.com>
To: Fengguang Wu <fengguang.wu@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	walter harms <wharms@bfs.de>,
	kernel-janitors@vger.kernel.org,
	Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: [PATCH] idr: Rename MAX_LEVEL to MAX_ID_LEVEL
Date: Thu, 13 Sep 2012 09:50:05 +0000	[thread overview]
Message-ID: <5051AC4D.4050003@parallels.com> (raw)
In-Reply-To: <20120912233801.GA14638@localhost>

On 09/13/2012 03:38 AM, Fengguang Wu wrote:
> On Wed, Sep 12, 2012 at 04:03:02PM -0700, Andrew Morton wrote:
>> On Tue, 11 Sep 2012 17:48:23 +0800
>> Fengguang Wu <fengguang.wu@intel.com> wrote:
>>
>>> idr: Rename MAX_LEVEL to MAX_IDR_LEVEL
>>>
>>> To avoid name conflicts:
>>>
>>> drivers/video/riva/fbdev.c:281:9: sparse: preprocessor token MAX_LEVEL redefined
>>>
>>> While at it, also make the other names more consistent and
>>> add parentheses.
>>
>> That was a rather modest effort :(
>>
>>  drivers/i2c/i2c-core.c        |    2 +-
>>  drivers/infiniband/core/cm.c  |    2 +-
>>  drivers/pps/pps.c             |    2 +-
>>  drivers/thermal/thermal_sys.c |    2 +-
>>  fs/super.c                    |    2 +-
>>  5 files changed, 5 insertions(+), 5 deletions(-)
> 
>> From: Andrew Morton <akpm@linux-foundation.org>
>> Subject: idr-rename-max_level-to-max_idr_level-fix-fix-2
>>
>> ho hum
>>
>>  lib/idr.c |   14 +++++++-------
> 
> Embarrassing.. Sorry for not build testing it at all!
> 
> Regards,
> Fengguang
> 
You can build test it automatically using Fengguang's 0-day test system.

/me runs

WARNING: multiple messages have this Message-ID (diff)
From: Glauber Costa <glommer@parallels.com>
To: Fengguang Wu <fengguang.wu@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	walter harms <wharms@bfs.de>,
	kernel-janitors@vger.kernel.org,
	Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: [PATCH] idr: Rename MAX_LEVEL to MAX_ID_LEVEL
Date: Thu, 13 Sep 2012 13:50:05 +0400	[thread overview]
Message-ID: <5051AC4D.4050003@parallels.com> (raw)
In-Reply-To: <20120912233801.GA14638@localhost>

On 09/13/2012 03:38 AM, Fengguang Wu wrote:
> On Wed, Sep 12, 2012 at 04:03:02PM -0700, Andrew Morton wrote:
>> On Tue, 11 Sep 2012 17:48:23 +0800
>> Fengguang Wu <fengguang.wu@intel.com> wrote:
>>
>>> idr: Rename MAX_LEVEL to MAX_IDR_LEVEL
>>>
>>> To avoid name conflicts:
>>>
>>> drivers/video/riva/fbdev.c:281:9: sparse: preprocessor token MAX_LEVEL redefined
>>>
>>> While at it, also make the other names more consistent and
>>> add parentheses.
>>
>> That was a rather modest effort :(
>>
>>  drivers/i2c/i2c-core.c        |    2 +-
>>  drivers/infiniband/core/cm.c  |    2 +-
>>  drivers/pps/pps.c             |    2 +-
>>  drivers/thermal/thermal_sys.c |    2 +-
>>  fs/super.c                    |    2 +-
>>  5 files changed, 5 insertions(+), 5 deletions(-)
> 
>> From: Andrew Morton <akpm@linux-foundation.org>
>> Subject: idr-rename-max_level-to-max_idr_level-fix-fix-2
>>
>> ho hum
>>
>>  lib/idr.c |   14 +++++++-------
> 
> Embarrassing.. Sorry for not build testing it at all!
> 
> Regards,
> Fengguang
> 
You can build test it automatically using Fengguang's 0-day test system.

/me runs

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2012-09-13  9:50 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-10 13:14 [PATCH] idr: Rename MAX_LEVEL to MAX_ID_LEVEL Fengguang Wu
2012-09-10 13:14 ` Fengguang Wu
2012-09-10 14:07 ` Glauber Costa
2012-09-10 14:07   ` Glauber Costa
2012-09-10 16:12 ` walter harms
2012-09-10 16:12   ` walter harms
2012-09-11  9:48   ` Fengguang Wu
2012-09-11  9:48     ` Fengguang Wu
2012-09-12 23:03     ` Andrew Morton
2012-09-12 23:03       ` Andrew Morton
2012-09-12 23:38       ` Fengguang Wu
2012-09-12 23:38         ` Fengguang Wu
2012-09-13  9:50         ` Glauber Costa [this message]
2012-09-13  9:50           ` Glauber Costa
2012-09-11  8:27 ` Bernd Petrovitsch
2012-09-11  8:27   ` Bernd Petrovitsch
2012-09-11  9:47   ` Fengguang Wu
2012-09-11  9:47     ` Fengguang Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5051AC4D.4050003@parallels.com \
    --to=glommer@parallels.com \
    --cc=akpm@linux-foundation.org \
    --cc=fengguang.wu@intel.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=wharms@bfs.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.