All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [PATCH] ath9k: Fix mesh related filtering issue for older chips
Date: Fri, 14 Sep 2012 20:21:17 +0530	[thread overview]
Message-ID: <50534465.3080205@qca.qualcomm.com> (raw)
In-Reply-To: <1347633965-20218-1-git-send-email-mohammed@qca.qualcomm.com>

On Friday 14 September 2012 08:16 PM, Mohammed Shafi Shajakhan wrote:
> From: Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>
>
> We need to have the promiscus mode enabled for older
> chipset(ie rule out many frames being filtered in the
> hardware itself)if 'FIF_OTHER_BSS' flag is set, when we
> start the mesh mode. Fix this by enabling promiscus
> mode for all chipsets whose macversion <= AR9160
> chipsets. This should fix
> https://bugzilla.kernel.org/show_bug.cgi?id=45591
>
> Signed-off-by: Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>
> ---
>   drivers/net/wireless/ath/ath9k/recv.c |    4 ++--
>   1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath9k/recv.c b/drivers/net/wireless/ath/ath9k/recv.c
> index 4480c0c..76db0b3 100644
> --- a/drivers/net/wireless/ath/ath9k/recv.c
> +++ b/drivers/net/wireless/ath/ath9k/recv.c
> @@ -424,8 +424,8 @@ u32 ath_calcrxfilter(struct ath_softc *sc)
>   		rfilt |= ATH9K_RX_FILTER_COMP_BAR;
>
>   	if (sc->nvifs > 1 || (sc->rx.rxfilter & FIF_OTHER_BSS)) {
> -		/* The following may also be needed for other older chips */
> -		if (sc->sc_ah->hw_version.macVersion == AR_SREV_VERSION_9160)
> +		/* This is needed for older chips, especially for mesh mode */
> +		if (sc->sc_ah->hw_version.macVersion <= AR_SREV_VERSION_9160)
>   			rfilt |= ATH9K_RX_FILTER_PROM;
>   		rfilt |= ATH9K_RX_FILTER_MCAST_BCAST_ALL;
>   	}
>

John, kindly drop this. Had resent the v2 with proper author
name (Thomas) who suggested the change.


-- 
thanks,
shafi

WARNING: multiple messages have this Message-ID (diff)
From: Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>
To: Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
	<linux-wireless@vger.kernel.org>,
	Rodriguez Luis <rodrigue@qca.qualcomm.com>,
	<ath9k-devel@lists.ath9k.org>
Subject: Re: [PATCH] ath9k: Fix mesh related filtering issue for older chips
Date: Fri, 14 Sep 2012 20:21:17 +0530	[thread overview]
Message-ID: <50534465.3080205@qca.qualcomm.com> (raw)
In-Reply-To: <1347633965-20218-1-git-send-email-mohammed@qca.qualcomm.com>

On Friday 14 September 2012 08:16 PM, Mohammed Shafi Shajakhan wrote:
> From: Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>
>
> We need to have the promiscus mode enabled for older
> chipset(ie rule out many frames being filtered in the
> hardware itself)if 'FIF_OTHER_BSS' flag is set, when we
> start the mesh mode. Fix this by enabling promiscus
> mode for all chipsets whose macversion <= AR9160
> chipsets. This should fix
> https://bugzilla.kernel.org/show_bug.cgi?id=45591
>
> Signed-off-by: Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>
> ---
>   drivers/net/wireless/ath/ath9k/recv.c |    4 ++--
>   1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath9k/recv.c b/drivers/net/wireless/ath/ath9k/recv.c
> index 4480c0c..76db0b3 100644
> --- a/drivers/net/wireless/ath/ath9k/recv.c
> +++ b/drivers/net/wireless/ath/ath9k/recv.c
> @@ -424,8 +424,8 @@ u32 ath_calcrxfilter(struct ath_softc *sc)
>   		rfilt |= ATH9K_RX_FILTER_COMP_BAR;
>
>   	if (sc->nvifs > 1 || (sc->rx.rxfilter & FIF_OTHER_BSS)) {
> -		/* The following may also be needed for other older chips */
> -		if (sc->sc_ah->hw_version.macVersion == AR_SREV_VERSION_9160)
> +		/* This is needed for older chips, especially for mesh mode */
> +		if (sc->sc_ah->hw_version.macVersion <= AR_SREV_VERSION_9160)
>   			rfilt |= ATH9K_RX_FILTER_PROM;
>   		rfilt |= ATH9K_RX_FILTER_MCAST_BCAST_ALL;
>   	}
>

John, kindly drop this. Had resent the v2 with proper author
name (Thomas) who suggested the change.


-- 
thanks,
shafi



  reply	other threads:[~2012-09-14 14:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-14 14:46 [ath9k-devel] [PATCH] ath9k: Fix mesh related filtering issue for older chips Mohammed Shafi Shajakhan
2012-09-14 14:46 ` Mohammed Shafi Shajakhan
2012-09-14 14:51 ` Mohammed Shafi Shajakhan [this message]
2012-09-14 14:51   ` Mohammed Shafi Shajakhan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50534465.3080205@qca.qualcomm.com \
    --to=mohammed@qca.qualcomm.com \
    --cc=ath9k-devel@lists.ath9k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.