From: Jon Hunter <jon-hunter@ti.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: device-tree <devicetree-discuss@lists.ozlabs.org>,
linux-omap <linux-omap@vger.kernel.org>,
linux-arm <linux-arm-kernel@lists.infradead.org>,
Nicolas Ferre <nicolas.ferre@atmel.com>,
Benoit Cousson <b-cousson@ti.com>,
Stephen Warren <swarren@nvidia.com>,
Grant Likely <grant.likely@secretlab.ca>,
Russell King <linux@arm.linux.org.uk>,
Rob Herring <rob.herring@calxeda.com>,
Vinod Koul <vinod.koul@intel.com>, Dan Williams <djbw@fb.com>
Subject: Re: [PATCH V5 1/2] of: Add generic device tree DMA helpers
Date: Fri, 14 Sep 2012 12:20:45 -0500 [thread overview]
Message-ID: <5053676D.8020602@ti.com> (raw)
In-Reply-To: <201209141526.17791.arnd@arndb.de>
On 09/14/2012 10:26 AM, Arnd Bergmann wrote:
> On Friday 14 September 2012, Jon Hunter wrote:
>>
>> Cc: Nicolas Ferre <nicolas.ferre@atmel.com>
>> Cc: Benoit Cousson <b-cousson@ti.com>
>> Cc: Stephen Warren <swarren@nvidia.com>
>> Cc: Grant Likely <grant.likely@secretlab.ca>
>> Cc: Russell King <linux@arm.linux.org.uk>
>> Cc: Rob Herring <rob.herring@calxeda.com>
>> Cc: Arnd Bergmann <arnd@arndb.de>
>> Cc: Vinod Koul <vinod.koul@intel.com>
>> Cc: Dan Williams <djbw@fb.com>
>> Signed-off-by: Jon Hunter <jon-hunter@ti.com>
>
> Reviewed-by: Arnd Bergmann <arnd@arndb.de>
>
> Thanks for all this work, looks great!
Thanks!
> My final (tiny) comment on this:
>
>> +2. A single read-write channel with two alternative dma controllers:
>> +
>> + dmas = <&dma1 5
>> + &dma2 7
>> + &dma3 2>;
>> + dma-names = "rx-tx", "rx-tx", "rx-tx"
>
> *three* alternative dma controllers, not two.
Oops! I have been starring at this so long I can no longer see the wood
for the trees!
Jon
WARNING: multiple messages have this Message-ID (diff)
From: jon-hunter@ti.com (Jon Hunter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V5 1/2] of: Add generic device tree DMA helpers
Date: Fri, 14 Sep 2012 12:20:45 -0500 [thread overview]
Message-ID: <5053676D.8020602@ti.com> (raw)
In-Reply-To: <201209141526.17791.arnd@arndb.de>
On 09/14/2012 10:26 AM, Arnd Bergmann wrote:
> On Friday 14 September 2012, Jon Hunter wrote:
>>
>> Cc: Nicolas Ferre <nicolas.ferre@atmel.com>
>> Cc: Benoit Cousson <b-cousson@ti.com>
>> Cc: Stephen Warren <swarren@nvidia.com>
>> Cc: Grant Likely <grant.likely@secretlab.ca>
>> Cc: Russell King <linux@arm.linux.org.uk>
>> Cc: Rob Herring <rob.herring@calxeda.com>
>> Cc: Arnd Bergmann <arnd@arndb.de>
>> Cc: Vinod Koul <vinod.koul@intel.com>
>> Cc: Dan Williams <djbw@fb.com>
>> Signed-off-by: Jon Hunter <jon-hunter@ti.com>
>
> Reviewed-by: Arnd Bergmann <arnd@arndb.de>
>
> Thanks for all this work, looks great!
Thanks!
> My final (tiny) comment on this:
>
>> +2. A single read-write channel with two alternative dma controllers:
>> +
>> + dmas = <&dma1 5
>> + &dma2 7
>> + &dma3 2>;
>> + dma-names = "rx-tx", "rx-tx", "rx-tx"
>
> *three* alternative dma controllers, not two.
Oops! I have been starring at this so long I can no longer see the wood
for the trees!
Jon
next prev parent reply other threads:[~2012-09-14 17:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-14 15:18 [PATCH V5 0/2] of: Add generic device tree DMA helpers Jon Hunter
2012-09-14 15:18 ` Jon Hunter
2012-09-14 15:18 ` [PATCH V5 1/2] " Jon Hunter
2012-09-14 15:18 ` Jon Hunter
2012-09-14 15:26 ` Arnd Bergmann
2012-09-14 15:26 ` Arnd Bergmann
2012-09-14 17:20 ` Jon Hunter [this message]
2012-09-14 17:20 ` Jon Hunter
2012-09-14 15:37 ` Nicolas Ferre
2012-09-14 15:37 ` Nicolas Ferre
2012-09-14 15:18 ` [PATCH V5 2/2] dmaengine: add helper function to request a slave DMA channel Jon Hunter
2012-09-14 15:18 ` Jon Hunter
2012-09-14 15:26 ` Arnd Bergmann
2012-09-14 15:26 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5053676D.8020602@ti.com \
--to=jon-hunter@ti.com \
--cc=arnd@arndb.de \
--cc=b-cousson@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=djbw@fb.com \
--cc=grant.likely@secretlab.ca \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=nicolas.ferre@atmel.com \
--cc=rob.herring@calxeda.com \
--cc=swarren@nvidia.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.