From: Sakari Ailus <sakari.ailus@iki.fi>
To: Hans Verkuil <hans.verkuil@cisco.com>
Cc: linux-media@vger.kernel.org
Subject: Re: [RFCv3 API PATCH 00/31] Full series of API fixes from the 2012 Media Workshop
Date: Sat, 15 Sep 2012 00:26:45 +0300 [thread overview]
Message-ID: <5053A115.9060303@iki.fi> (raw)
In-Reply-To: <1347620266-13767-1-git-send-email-hans.verkuil@cisco.com>
Hans Verkuil wrote:
> Hi all,
>
> This is the full patch series containing API fixes as discussed during the
> 2012 Media Workshop.
>
> Regarding the 'make ioctl const' patches: I've only done the easy ones in
> this patch series. The remaining write-only ioctls are used much more widely,
> so changing those will happen later.
>
> The last few patches that enhance the core code with more stringent tests
> against what ioctls can be called for which types of device node will need
> reviewing. I have tested it exhaustively with ivtv (which is one of the
> most complex drivers, and the only one that has exotic devices like VBI
> out).
>
> To use v4l2-compliance with ivtv I also needed to make a few other fixes
> elsewhere. The tree with both this patch series and the addition ivtv fixes
> can be found here:
>
> http://git.linuxtv.org/hverkuil/media_tree.git/shortlog/refs/heads/ivtv
>
> I have also tested this patch series (actually a slightly older version)
> with em28xx. That driver needed a lot of changes to get it to pass the
> v4l2-compliance tests. Those can be found here:
>
> http://git.linuxtv.org/hverkuil/media_tree.git/shortlog/refs/heads/em28xx
Hi, Hans!
Thanks for the patchset!
On patch 7 (which I somehow managed not to receive): both cx18 and ivtv
contain references to V4L2_BUF_TYPE_PRIVATE. I wonder if that's intentional.
For patches 2, 3, 4, 6, 8, 17 and 28 (for omap3isp)
Acked-by: Sakari Ailus <sakari.ailus@iki.fi>
And for patches 5, 11, 18
Reviewed-by: Sakari Ailus <sakari.ailus@iki.fi>
Kind regards,
--
Sakari Ailus
sakari.ailus@iki.fi
next prev parent reply other threads:[~2012-09-14 21:25 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-14 10:57 [RFCv3 API PATCH 00/31] Full series of API fixes from the 2012 Media Workshop Hans Verkuil
2012-09-14 10:57 ` [RFCv3 API PATCH 01/31] v4l: Remove experimental tag from certain API elements Hans Verkuil
2012-09-14 10:57 ` [RFCv3 API PATCH 02/31] videodev2.h: split off controls into v4l2-controls.h Hans Verkuil
2012-09-14 10:57 ` [RFCv3 API PATCH 03/31] DocBook: improve STREAMON/OFF documentation Hans Verkuil
2012-09-14 10:57 ` [RFCv3 API PATCH 04/31] DocBook: make the G/S/TRY_FMT specification more strict Hans Verkuil
2012-09-14 10:57 ` [RFCv3 API PATCH 05/31] DocBook: bus_info can no longer be empty Hans Verkuil
2012-09-14 10:57 ` [RFCv3 API PATCH 06/31] vivi/mem2mem_testdev: update to latest bus_info specification Hans Verkuil
2012-09-14 17:34 ` Sylwester Nawrocki
2012-09-14 10:57 ` [RFCv3 API PATCH 07/31] v4l2-core: deprecate V4L2_BUF_TYPE_PRIVATE Hans Verkuil
2012-09-14 10:57 ` [RFCv3 API PATCH 08/31] DocBook: " Hans Verkuil
2012-09-14 10:57 ` [RFCv3 API PATCH 09/31] v4l2: remove experimental tag from a number of old drivers Hans Verkuil
2012-09-14 10:57 ` [RFCv3 API PATCH 10/31] DocBook: document when to return ENODATA Hans Verkuil
2012-09-14 10:57 ` [RFCv3 API PATCH 11/31] v4l2-core: tvnorms may be 0 for a given input, handle that case Hans Verkuil
2012-09-14 10:57 ` [RFCv3 API PATCH 12/31] Rename V4L2_(IN|OUT)_CAP_CUSTOM_TIMINGS Hans Verkuil
2012-09-14 10:57 ` [RFCv3 API PATCH 13/31] Feature removal: Remove CUSTOM_TIMINGS defines in 3.9 Hans Verkuil
2012-09-14 10:57 ` [RFCv3 API PATCH 14/31] DocBook: fix awkward language and fix the documented return value Hans Verkuil
2012-09-14 10:57 ` [RFCv3 API PATCH 15/31] v4l2-core: Add new V4L2_CAP_MONOTONIC_TS capability Hans Verkuil
2012-09-14 20:25 ` Sakari Ailus
2012-09-14 20:27 ` Rémi Denis-Courmont
2012-09-14 21:05 ` Sakari Ailus
2012-09-15 7:41 ` Hans Verkuil
2012-09-15 9:31 ` Laurent Pinchart
2012-09-15 10:05 ` Hans Verkuil
2012-09-15 10:37 ` Sakari Ailus
2012-09-15 12:35 ` Hans Verkuil
2012-09-15 20:16 ` Sylwester Nawrocki
2012-09-16 13:57 ` Hans Verkuil
2012-09-16 15:33 ` Laurent Pinchart
2012-09-16 21:59 ` Sylwester Nawrocki
2012-09-17 7:13 ` Daniel Glöckner
2012-09-17 9:18 ` Laurent Pinchart
2012-09-17 9:28 ` Hans Verkuil
2012-09-17 9:30 ` Daniel Glöckner
2012-09-17 17:19 ` Sakari Ailus
2012-09-17 20:27 ` Sylwester Nawrocki
2012-09-18 7:42 ` Sakari Ailus
2012-09-15 10:26 ` Sylwester Nawrocki
2012-09-14 10:57 ` [RFCv3 API PATCH 16/31] Add V4L2_CAP_MONOTONIC_TS where applicable Hans Verkuil
2012-09-14 10:57 ` [RFCv3 API PATCH 17/31] DocBook: clarify that sequence is also set for output devices Hans Verkuil
2012-09-14 10:57 ` [RFCv3 API PATCH 18/31] DocBook: Mark CROPCAP as optional instead of as compulsory Hans Verkuil
2012-09-14 10:57 ` [RFCv3 API PATCH 19/31] v4l2: make vidioc_s_fbuf const Hans Verkuil
2012-09-14 10:57 ` [RFCv3 API PATCH 20/31] v4l2: make vidioc_s_jpegcomp const Hans Verkuil
2012-09-14 10:57 ` [RFCv3 API PATCH 21/31] v4l2: make vidioc_s_freq_hw_seek const Hans Verkuil
2012-09-14 10:57 ` [RFCv3 API PATCH 22/31] v4l2: make vidioc_(un)subscribe_event const Hans Verkuil
2012-09-14 10:57 ` [RFCv3 API PATCH 23/31] v4l2: make vidioc_s_audio const Hans Verkuil
2012-09-14 10:57 ` [RFCv3 API PATCH 24/31] v4l2: make vidioc_s_audout const Hans Verkuil
2012-09-14 10:57 ` [RFCv3 API PATCH 25/31] v4l2: make vidioc_s_modulator const Hans Verkuil
2012-09-14 10:57 ` [RFCv3 API PATCH 26/31] v4l2: make vidioc_s_crop const Hans Verkuil
2012-09-14 10:57 ` [RFCv3 API PATCH 27/31] v4l2-dev: add new VFL_DIR_ defines Hans Verkuil
2012-09-14 10:57 ` [RFCv3 API PATCH 28/31] Set vfl_dir for all display or m2m drivers Hans Verkuil
2012-09-14 17:34 ` Sylwester Nawrocki
2012-09-14 10:57 ` [RFCv3 API PATCH 29/31] v4l2-dev: improve ioctl validity checks Hans Verkuil
2012-09-14 10:57 ` [RFCv3 API PATCH 30/31] v4l2-dev: reorder checks into blocks of ioctls with similar properties Hans Verkuil
2012-09-14 10:57 ` [RFCv3 API PATCH 31/31] Add vfl_dir field documentation Hans Verkuil
2012-09-14 17:34 ` Sylwester Nawrocki
2012-09-14 17:59 ` Hans Verkuil
2012-09-14 21:26 ` Sakari Ailus [this message]
2012-09-15 7:33 ` [RFCv3 API PATCH 00/31] Full series of API fixes from the 2012 Media Workshop Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5053A115.9060303@iki.fi \
--to=sakari.ailus@iki.fi \
--cc=hans.verkuil@cisco.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.