From: Mike Dunn <mikedunn@newsguy.com>
To: Peter Huewe <peterhuewe@gmx.de>
Cc: Arnd Bergmann <arnd@arndb.de>,
Artem Bityutskiy <artem.bityutskiy@linux.intel.com>,
linux-kernel@vger.kernel.org, Huang Shijie <b32955@freescale.com>,
linux-mtd@lists.infradead.org,
David Woodhouse <dwmw2@infradead.org>,
Shubhrajyoti D <shubhrajyoti@ti.com>
Subject: Re: [PATCH] mtd/nand/docg4: Add missing HAS_IOMEM dependency
Date: Sat, 15 Sep 2012 11:23:33 -0700 [thread overview]
Message-ID: <5054C7A5.5010308@newsguy.com> (raw)
In-Reply-To: <1347662469-1604-1-git-send-email-peterhuewe@gmx.de>
Acked-by: Mike Dunn <mikedunn@newsguy.com>
Sorry for the oversight.
Mike
On 09/14/2012 03:41 PM, Peter Huewe wrote:
> While building an allyesconfig for UML I received this error message(s):
> drivers/mtd/nand/docg4.c: In function 'probe_docg4':
> drivers/mtd/nand/docg4.c:1272:2: error: implicit declaration of function
> 'ioremap' [-Werror=implicit-function-declaration]
> drivers/mtd/nand/docg4.c:1272:10: warning: assignment makes pointer from
> integer without a cast [enabled by default]
> drivers/mtd/nand/docg4.c:1327:2: error: implicit declaration of function
> 'iounmap' [-Werror=implicit-function-declaration]
>
> which is caused by the missing implementations on UML.
>
> This patch adds this missing HAS_IOMEM dependency and prevents the driver from
> being build on platforms with no HAS_IOMEM
>
> Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
> ---
> drivers/mtd/nand/Kconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
> index 8ca4176..3e2f75d 100644
> --- a/drivers/mtd/nand/Kconfig
> +++ b/drivers/mtd/nand/Kconfig
> @@ -356,7 +356,7 @@ config MTD_NAND_DISKONCHIP_BBTWRITE
>
> config MTD_NAND_DOCG4
> tristate "Support for DiskOnChip G4 (EXPERIMENTAL)"
> - depends on EXPERIMENTAL
> + depends on EXPERIMENTAL && HAS_IOMEM
> select BCH
> select BITREVERSE
> help
WARNING: multiple messages have this Message-ID (diff)
From: Mike Dunn <mikedunn@newsguy.com>
To: Peter Huewe <peterhuewe@gmx.de>
Cc: David Woodhouse <dwmw2@infradead.org>,
Arnd Bergmann <arnd@arndb.de>,
Artem Bityutskiy <artem.bityutskiy@linux.intel.com>,
linux-kernel@vger.kernel.org, Huang Shijie <b32955@freescale.com>,
linux-mtd@lists.infradead.org,
Shubhrajyoti D <shubhrajyoti@ti.com>
Subject: Re: [PATCH] mtd/nand/docg4: Add missing HAS_IOMEM dependency
Date: Sat, 15 Sep 2012 11:23:33 -0700 [thread overview]
Message-ID: <5054C7A5.5010308@newsguy.com> (raw)
In-Reply-To: <1347662469-1604-1-git-send-email-peterhuewe@gmx.de>
Acked-by: Mike Dunn <mikedunn@newsguy.com>
Sorry for the oversight.
Mike
On 09/14/2012 03:41 PM, Peter Huewe wrote:
> While building an allyesconfig for UML I received this error message(s):
> drivers/mtd/nand/docg4.c: In function 'probe_docg4':
> drivers/mtd/nand/docg4.c:1272:2: error: implicit declaration of function
> 'ioremap' [-Werror=implicit-function-declaration]
> drivers/mtd/nand/docg4.c:1272:10: warning: assignment makes pointer from
> integer without a cast [enabled by default]
> drivers/mtd/nand/docg4.c:1327:2: error: implicit declaration of function
> 'iounmap' [-Werror=implicit-function-declaration]
>
> which is caused by the missing implementations on UML.
>
> This patch adds this missing HAS_IOMEM dependency and prevents the driver from
> being build on platforms with no HAS_IOMEM
>
> Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
> ---
> drivers/mtd/nand/Kconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
> index 8ca4176..3e2f75d 100644
> --- a/drivers/mtd/nand/Kconfig
> +++ b/drivers/mtd/nand/Kconfig
> @@ -356,7 +356,7 @@ config MTD_NAND_DISKONCHIP_BBTWRITE
>
> config MTD_NAND_DOCG4
> tristate "Support for DiskOnChip G4 (EXPERIMENTAL)"
> - depends on EXPERIMENTAL
> + depends on EXPERIMENTAL && HAS_IOMEM
> select BCH
> select BITREVERSE
> help
next prev parent reply other threads:[~2012-09-15 18:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-14 22:41 [PATCH] mtd/nand/docg4: Add missing HAS_IOMEM dependency Peter Huewe
2012-09-14 22:41 ` Peter Huewe
2012-09-15 18:23 ` Mike Dunn [this message]
2012-09-15 18:23 ` Mike Dunn
2012-09-26 9:49 ` Artem Bityutskiy
2012-09-26 9:49 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5054C7A5.5010308@newsguy.com \
--to=mikedunn@newsguy.com \
--cc=arnd@arndb.de \
--cc=artem.bityutskiy@linux.intel.com \
--cc=b32955@freescale.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=peterhuewe@gmx.de \
--cc=shubhrajyoti@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.