All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Ungerer <gerg@snapgear.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
	dedekind1@gmail.com,
	Mark Brown <broonie@opensource.wolfsonmicro.com>,
	Mike Turquette <mturquette@ti.com>,
	Greg Ungerer <gerg@uclinux.org>,
	Julia Lawall <julia.lawall@lip6.fr>,
	linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org
Subject: Re: [PATCH] clk: Make the managed clk functions generically available
Date: Sun, 16 Sep 2012 10:15:35 +1000	[thread overview]
Message-ID: <50551A27.5070807@snapgear.com> (raw)
In-Reply-To: <20120915213151.GM12245@n2100.arm.linux.org.uk>

On 09/16/2012 07:31 AM, Russell King - ARM Linux wrote:
> On Wed, Sep 12, 2012 at 10:43:07PM +0200, Lars-Peter Clausen wrote:
>> I wouldn't mind having this merged sooner rather than later, there is at least
>> one driver in next which is currently broken due to the missing devm_clk_get.
>> Russell what's your plan for the patch? Maybe under the given circumstances it
>> makes sense to let it go through the m68k tree.
>
> Ok, I've merged it but there was no indication in the patch that it was
> supposed to be a fix... there's no cc: to stable.  Does it need to go to
> stable?  When was this brokenness introduced?  What's the story for the
> m68k bit?

For the m68k issues this is not a candidate for stable. The breakage
that this fixes did not occur until the 3.6 merge window.

The fact that it fixes some breakage on some m68k platforms is more
of a side effect, and the original patch author would not have known
about this. The underlying problem was with the local m68k/coldfire
implementation of devm_clk_get, but this patch makes that code go
away completely.

Regards
Greg


------------------------------------------------------------------------
Greg Ungerer  --  Principal Engineer        EMAIL:     gerg@snapgear.com
SnapGear Group, McAfee                      PHONE:       +61 7 3435 2888
8 Gardner Close,                            FAX:         +61 7 3891 3630
Milton, QLD, 4064, Australia                WEB: http://www.SnapGear.com

WARNING: multiple messages have this Message-ID (diff)
From: gerg@snapgear.com (Greg Ungerer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: Make the managed clk functions generically available
Date: Sun, 16 Sep 2012 10:15:35 +1000	[thread overview]
Message-ID: <50551A27.5070807@snapgear.com> (raw)
In-Reply-To: <20120915213151.GM12245@n2100.arm.linux.org.uk>

On 09/16/2012 07:31 AM, Russell King - ARM Linux wrote:
> On Wed, Sep 12, 2012 at 10:43:07PM +0200, Lars-Peter Clausen wrote:
>> I wouldn't mind having this merged sooner rather than later, there is at least
>> one driver in next which is currently broken due to the missing devm_clk_get.
>> Russell what's your plan for the patch? Maybe under the given circumstances it
>> makes sense to let it go through the m68k tree.
>
> Ok, I've merged it but there was no indication in the patch that it was
> supposed to be a fix... there's no cc: to stable.  Does it need to go to
> stable?  When was this brokenness introduced?  What's the story for the
> m68k bit?

For the m68k issues this is not a candidate for stable. The breakage
that this fixes did not occur until the 3.6 merge window.

The fact that it fixes some breakage on some m68k platforms is more
of a side effect, and the original patch author would not have known
about this. The underlying problem was with the local m68k/coldfire
implementation of devm_clk_get, but this patch makes that code go
away completely.

Regards
Greg


------------------------------------------------------------------------
Greg Ungerer  --  Principal Engineer        EMAIL:     gerg at snapgear.com
SnapGear Group, McAfee                      PHONE:       +61 7 3435 2888
8 Gardner Close,                            FAX:         +61 7 3891 3630
Milton, QLD, 4064, Australia                WEB: http://www.SnapGear.com

WARNING: multiple messages have this Message-ID (diff)
From: Greg Ungerer <gerg@snapgear.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Lars-Peter Clausen <lars@metafoo.de>, <dedekind1@gmail.com>,
	Mark Brown <broonie@opensource.wolfsonmicro.com>,
	Mike Turquette <mturquette@ti.com>,
	Greg Ungerer <gerg@uclinux.org>,
	Julia Lawall <julia.lawall@lip6.fr>, <linux-m68k@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>, <stable@vger.kernel.org>
Subject: Re: [PATCH] clk: Make the managed clk functions generically available
Date: Sun, 16 Sep 2012 10:15:35 +1000	[thread overview]
Message-ID: <50551A27.5070807@snapgear.com> (raw)
In-Reply-To: <20120915213151.GM12245@n2100.arm.linux.org.uk>

On 09/16/2012 07:31 AM, Russell King - ARM Linux wrote:
> On Wed, Sep 12, 2012 at 10:43:07PM +0200, Lars-Peter Clausen wrote:
>> I wouldn't mind having this merged sooner rather than later, there is at least
>> one driver in next which is currently broken due to the missing devm_clk_get.
>> Russell what's your plan for the patch? Maybe under the given circumstances it
>> makes sense to let it go through the m68k tree.
>
> Ok, I've merged it but there was no indication in the patch that it was
> supposed to be a fix... there's no cc: to stable.  Does it need to go to
> stable?  When was this brokenness introduced?  What's the story for the
> m68k bit?

For the m68k issues this is not a candidate for stable. The breakage
that this fixes did not occur until the 3.6 merge window.

The fact that it fixes some breakage on some m68k platforms is more
of a side effect, and the original patch author would not have known
about this. The underlying problem was with the local m68k/coldfire
implementation of devm_clk_get, but this patch makes that code go
away completely.

Regards
Greg


------------------------------------------------------------------------
Greg Ungerer  --  Principal Engineer        EMAIL:     gerg@snapgear.com
SnapGear Group, McAfee                      PHONE:       +61 7 3435 2888
8 Gardner Close,                            FAX:         +61 7 3891 3630
Milton, QLD, 4064, Australia                WEB: http://www.SnapGear.com

  reply	other threads:[~2012-09-16  0:15 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-09 15:01 [PATCH] clk: Make the managed clk functions generically available Lars-Peter Clausen
2012-09-09 15:01 ` Lars-Peter Clausen
2012-09-09 20:57 ` Russell King - ARM Linux
2012-09-09 20:57   ` Russell King - ARM Linux
2012-09-09 20:57   ` Russell King - ARM Linux
2012-09-09 23:50 ` Mark Brown
2012-09-09 23:50   ` Mark Brown
2012-09-10  0:15   ` Russell King - ARM Linux
2012-09-10  0:15     ` Russell King - ARM Linux
2012-09-10  0:15     ` Russell King - ARM Linux
2012-09-10  0:20     ` Mark Brown
2012-09-10  0:20       ` Mark Brown
2012-09-10  0:20       ` Mark Brown
2012-09-10  0:39       ` Russell King - ARM Linux
2012-09-10  0:39         ` Russell King - ARM Linux
2012-09-10  0:39         ` Russell King - ARM Linux
2012-09-11 14:44         ` Lars-Peter Clausen
2012-09-11 14:44           ` Lars-Peter Clausen
2012-09-11 14:50           ` Artem Bityutskiy
2012-09-11 14:50             ` Artem Bityutskiy
2012-09-11 14:50             ` Artem Bityutskiy
2012-09-12  1:32             ` Greg Ungerer
2012-09-12  1:32               ` Greg Ungerer
2012-09-12  1:32               ` Greg Ungerer
2012-09-12 20:43               ` Lars-Peter Clausen
2012-09-12 20:43               ` Lars-Peter Clausen
2012-09-12 20:43                 ` Lars-Peter Clausen
2012-09-15 21:31                 ` Russell King - ARM Linux
2012-09-15 21:31                   ` Russell King - ARM Linux
2012-09-15 21:31                   ` Russell King - ARM Linux
2012-09-16  0:15                   ` Greg Ungerer [this message]
2012-09-16  0:15                     ` Greg Ungerer
2012-09-16  0:15                     ` Greg Ungerer
2012-09-18  8:00                   ` Thierry Reding
2012-09-18  8:00                     ` Thierry Reding
2012-09-18  8:00                     ` Thierry Reding
2012-09-18  9:35                     ` Russell King - ARM Linux
2012-09-18  9:35                     ` Russell King - ARM Linux
2012-09-18  9:35                       ` Russell King - ARM Linux
2012-09-18 11:25                       ` Thierry Reding
2012-09-18 11:25                         ` Thierry Reding
2012-09-18 11:25                         ` Thierry Reding
2012-09-18 20:40                         ` Russell King - ARM Linux
2012-09-18 20:40                         ` Russell King - ARM Linux
2012-09-18 20:40                           ` Russell King - ARM Linux
2012-09-19  6:55                           ` Thierry Reding
2012-09-19  6:55                           ` Thierry Reding
2012-09-19  6:55                             ` Thierry Reding
2012-09-11 17:51           ` Russell King - ARM Linux
2012-09-11 17:51             ` Russell King - ARM Linux
2012-09-11 17:51             ` Russell King - ARM Linux
2012-09-11 14:44         ` Lars-Peter Clausen
2012-09-09 23:50 ` Mark Brown
2012-09-10  3:10 ` Greg Ungerer
2012-09-10  3:10   ` Greg Ungerer
2012-09-10  3:10   ` Greg Ungerer
  -- strict thread matches above, loose matches on Subject: below --
2012-09-09 15:01 Lars-Peter Clausen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50551A27.5070807@snapgear.com \
    --to=gerg@snapgear.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=dedekind1@gmail.com \
    --cc=gerg@uclinux.org \
    --cc=julia.lawall@lip6.fr \
    --cc=lars@metafoo.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@lists.linux-m68k.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mturquette@ti.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.