From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Vipul Kumar Samar <vipulkumar.samar@st.com>
Cc: grant.likely@secretlab.ca,
spi-devel-general@lists.sourceforge.net,
linus.walleij@linaro.org, spear-devel@list.st.com,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] spi: pl022: Add clk_{un}prepare() support in runtime PM
Date: Mon, 17 Sep 2012 16:09:34 +0400 [thread overview]
Message-ID: <505712FE.3040500@mvista.com> (raw)
In-Reply-To: <1f784b72399e0e96414f00866b209e2e218065af.1347877746.git.vipulkumar.samar@st.com>
Hello.
On 17-09-2012 14:37, Vipul Kumar Samar wrote:
> clk_{un}prepare is mandatory for platforms using common clock framework. Add
> clk_{un}prepare() support for spi-pl022 runtime PM.
> Signed-off-by: Vipul Kumar Samar <vipulkumar.samar@st.com>
[...]
> @@ -2342,10 +2342,13 @@ static int pl022_runtime_suspend(struct device *dev)
> static int pl022_runtime_resume(struct device *dev)
> {
> struct pl022 *pl022 = dev_get_drvdata(dev);
> + int ret = 0;
Don't need to init it at all.
> - clk_enable(pl022->clk);
> + ret = clk_prepare_enable(pl022->clk);
> + if (ret)
> + dev_err(dev, "could not enable SSP/SPI bus clock\n");
>
> - return 0;
> + return ret;
> }
> #endif
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: sshtylyov@mvista.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] spi: pl022: Add clk_{un}prepare() support in runtime PM
Date: Mon, 17 Sep 2012 16:09:34 +0400 [thread overview]
Message-ID: <505712FE.3040500@mvista.com> (raw)
In-Reply-To: <1f784b72399e0e96414f00866b209e2e218065af.1347877746.git.vipulkumar.samar@st.com>
Hello.
On 17-09-2012 14:37, Vipul Kumar Samar wrote:
> clk_{un}prepare is mandatory for platforms using common clock framework. Add
> clk_{un}prepare() support for spi-pl022 runtime PM.
> Signed-off-by: Vipul Kumar Samar <vipulkumar.samar@st.com>
[...]
> @@ -2342,10 +2342,13 @@ static int pl022_runtime_suspend(struct device *dev)
> static int pl022_runtime_resume(struct device *dev)
> {
> struct pl022 *pl022 = dev_get_drvdata(dev);
> + int ret = 0;
Don't need to init it at all.
> - clk_enable(pl022->clk);
> + ret = clk_prepare_enable(pl022->clk);
> + if (ret)
> + dev_err(dev, "could not enable SSP/SPI bus clock\n");
>
> - return 0;
> + return ret;
> }
> #endif
WBR, Sergei
next prev parent reply other threads:[~2012-09-17 12:09 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-17 10:37 [PATCH] spi: pl022: Add clk_{un}prepare() support in runtime PM Vipul Kumar Samar
2012-09-17 10:37 ` Vipul Kumar Samar
2012-09-17 10:37 ` Vipul Kumar Samar
2012-09-17 10:50 ` viresh kumar
2012-09-17 10:50 ` viresh kumar
2012-09-17 12:09 ` Sergei Shtylyov [this message]
2012-09-17 12:09 ` Sergei Shtylyov
2012-09-17 13:39 ` Linus Walleij
2012-09-17 13:39 ` Linus Walleij
[not found] ` <CACRpkdbHegZAw+9XXzOb5UPPqJvzoNfPJ5aPDhuwWWhWunuv8w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-09-18 4:09 ` viresh kumar
2012-09-18 4:09 ` viresh kumar
2012-09-18 4:09 ` viresh kumar
2012-09-18 11:50 ` Linus Walleij
2012-09-18 11:50 ` Linus Walleij
2012-09-19 3:31 ` viresh kumar
2012-09-19 3:31 ` viresh kumar
[not found] ` <CAOh2x=kH2pmF0oh+Rfna+0JmM+X433vB_TyhPJUhQg9B5r1evA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-09-20 6:43 ` Linus Walleij
2012-09-20 6:43 ` Linus Walleij
2012-09-20 6:43 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=505712FE.3040500@mvista.com \
--to=sshtylyov@mvista.com \
--cc=grant.likely@secretlab.ca \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=spear-devel@list.st.com \
--cc=spi-devel-general@lists.sourceforge.net \
--cc=vipulkumar.samar@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.