All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Henderson <rth@twiddle.net>
To: "Andreas Färber" <afaerber@suse.de>
Cc: blauwirbel@gmail.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 04/13] tcg-sparc: Assume v9 cpu always, i.e. force v8plus in 32-bit mode.
Date: Mon, 17 Sep 2012 10:05:46 -0700	[thread overview]
Message-ID: <5057586A.6010809@twiddle.net> (raw)
In-Reply-To: <50574A07.5030009@suse.de>

On 09/17/2012 09:04 AM, Andreas Färber wrote:
> Without knowing the code, this does not strike me as the best of ideas:
> SPARC CPUs are rather uncommon these days, so being able to emulate it
> in sparc32-softmmu may be helpful for keeping it working.
> 
> Could you elaborate on what exactly is broken and what would need to be
> done as alternative?

See, for instance, patch 2.  INDEX_op_qemu_ld64 and INDEX_op_qemu_st64
were unimplemented, caught during tcg startup with --enable-tcg-debug,
and crashing later without.

Handling only sparcv9 host cpus means that lots of code paths are able
to be cleaned up:

  (1) Multiply and divide insns are available
      (Conditional support for these is not easy.)

  (2) Endian-swapping load/store insns are available
      (Vastly cleans up qemu_ld/st; by the end of my patch set the
       fast path through the tlb is a single insn in the delay slot
       of the branch over the call to the helper.)

  (3) Conditional move insns are available
      (For setcond this is tidier than playing subtract-with-borrow games).

But sparcv9 is now coming up on 20 years old.  The amount of hardware
still live that isn't v9 capable is bound to be vanishingly small -- in
much the same way that i386 hosts without i486 bswap.  I don't think we
need to use the QEMU TCG code generator as a test case that keeps sparcv7
code alive.


r~

  reply	other threads:[~2012-09-17 17:06 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-16  0:05 [Qemu-devel] [PATCH] fix gcc warnings when RESERVED_VA is 0 Mike Frysinger
2012-09-16  9:58 ` Peter Maydell
2012-09-16 10:25   ` Blue Swirl
2012-09-17 15:28     ` [Qemu-devel] [PATCH v2 00/13] Sparc TCG cleanup Richard Henderson
2012-09-17 15:28       ` [Qemu-devel] [PATCH 01/13] linux-user: Use memcpy in get_user/put_user Richard Henderson
2012-09-17 15:35         ` Peter Maydell
2012-09-17 15:40           ` Richard Henderson
2012-09-17 16:06         ` Peter Maydell
2012-09-17 15:28       ` [Qemu-devel] [PATCH 02/13] tcg-sparc: Hack in qemu_ld/st64 for 32-bit Richard Henderson
2012-09-17 15:28       ` [Qemu-devel] [PATCH 03/13] tcg-sparc: Fix ADDX opcode Richard Henderson
2012-09-17 15:28       ` [Qemu-devel] [PATCH 04/13] tcg-sparc: Assume v9 cpu always, i.e. force v8plus in 32-bit mode Richard Henderson
2012-09-17 16:04         ` Andreas Färber
2012-09-17 17:05           ` Richard Henderson [this message]
2012-09-17 19:25             ` Blue Swirl
2012-09-17 21:52               ` Richard Henderson
2012-09-17 15:28       ` [Qemu-devel] [PATCH 05/13] tcg-sparc: Fix qemu_ld/st to handle 32-bit host Richard Henderson
2012-09-17 15:28       ` [Qemu-devel] [PATCH 06/13] tcg-sparc: Support GUEST_BASE Richard Henderson
2012-09-17 15:28       ` [Qemu-devel] [PATCH 07/13] tcg-sparc: Change AREG0 in generated code to %i0 Richard Henderson
2012-09-17 15:28       ` [Qemu-devel] [PATCH 08/13] tcg-sparc: Clean up cruft stemming from attempts to use global registers Richard Henderson
2012-09-17 15:28       ` [Qemu-devel] [PATCH 09/13] tcg-sparc: Mask shift immediates to avoid illegal insns Richard Henderson
2012-09-17 15:28       ` [Qemu-devel] [PATCH 10/13] tcg-sparc: Use defines for temporaries Richard Henderson
2012-09-17 15:28       ` [Qemu-devel] [PATCH 11/13] tcg-sparc: Add %g/%o registers to alloc_order Richard Henderson
2012-09-17 15:28       ` [Qemu-devel] [PATCH 12/13] tcg-sparc: Fix and enable direct TB chaining Richard Henderson
2012-09-17 15:28       ` [Qemu-devel] [PATCH 13/13] tcg: Fix !USE_DIRECT_JUMP Richard Henderson
2012-09-17 15:50         ` Andreas Färber
2012-09-21 20:21           ` Stefan Weil
2012-09-21 10:28         ` Aurelien Jarno
2012-09-21 18:16         ` Aurelien Jarno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5057586A.6010809@twiddle.net \
    --to=rth@twiddle.net \
    --cc=afaerber@suse.de \
    --cc=blauwirbel@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.