From: Aurelien Jarno <aurelien@aurel32.net>
To: Richard Henderson <rth@twiddle.net>
Cc: blauwirbel@gmail.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 13/13] tcg: Fix !USE_DIRECT_JUMP
Date: Fri, 21 Sep 2012 12:28:50 +0200 [thread overview]
Message-ID: <20120921102850.GE4457@ohm.aurel32.net> (raw)
In-Reply-To: <1347895732-22212-14-git-send-email-rth@twiddle.net>
On Mon, Sep 17, 2012 at 08:28:52AM -0700, Richard Henderson wrote:
> Commit 6375e09e changed the type of TranslationBlock.tb_next,
> but failed to change the type of TCGContext.tb_next.
>
> Signed-off-by: Richard Henderson <rth@twiddle.net>
> ---
> tcg/tcg.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tcg/tcg.h b/tcg/tcg.h
> index 7a72729..21016ec 100644
> --- a/tcg/tcg.h
> +++ b/tcg/tcg.h
> @@ -343,7 +343,7 @@ struct TCGContext {
>
> /* goto_tb support */
> uint8_t *code_buf;
> - unsigned long *tb_next;
> + uintptr_t *tb_next;
> uint16_t *tb_next_offset;
> uint16_t *tb_jmp_offset; /* != NULL if USE_DIRECT_JUMP */
>
Not directly sparc related, and definitely correct.
Reviewed-by: Aurelien Jarno <aurelien@aurel32.net>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
next prev parent reply other threads:[~2012-09-21 10:29 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-16 0:05 [Qemu-devel] [PATCH] fix gcc warnings when RESERVED_VA is 0 Mike Frysinger
2012-09-16 9:58 ` Peter Maydell
2012-09-16 10:25 ` Blue Swirl
2012-09-17 15:28 ` [Qemu-devel] [PATCH v2 00/13] Sparc TCG cleanup Richard Henderson
2012-09-17 15:28 ` [Qemu-devel] [PATCH 01/13] linux-user: Use memcpy in get_user/put_user Richard Henderson
2012-09-17 15:35 ` Peter Maydell
2012-09-17 15:40 ` Richard Henderson
2012-09-17 16:06 ` Peter Maydell
2012-09-17 15:28 ` [Qemu-devel] [PATCH 02/13] tcg-sparc: Hack in qemu_ld/st64 for 32-bit Richard Henderson
2012-09-17 15:28 ` [Qemu-devel] [PATCH 03/13] tcg-sparc: Fix ADDX opcode Richard Henderson
2012-09-17 15:28 ` [Qemu-devel] [PATCH 04/13] tcg-sparc: Assume v9 cpu always, i.e. force v8plus in 32-bit mode Richard Henderson
2012-09-17 16:04 ` Andreas Färber
2012-09-17 17:05 ` Richard Henderson
2012-09-17 19:25 ` Blue Swirl
2012-09-17 21:52 ` Richard Henderson
2012-09-17 15:28 ` [Qemu-devel] [PATCH 05/13] tcg-sparc: Fix qemu_ld/st to handle 32-bit host Richard Henderson
2012-09-17 15:28 ` [Qemu-devel] [PATCH 06/13] tcg-sparc: Support GUEST_BASE Richard Henderson
2012-09-17 15:28 ` [Qemu-devel] [PATCH 07/13] tcg-sparc: Change AREG0 in generated code to %i0 Richard Henderson
2012-09-17 15:28 ` [Qemu-devel] [PATCH 08/13] tcg-sparc: Clean up cruft stemming from attempts to use global registers Richard Henderson
2012-09-17 15:28 ` [Qemu-devel] [PATCH 09/13] tcg-sparc: Mask shift immediates to avoid illegal insns Richard Henderson
2012-09-17 15:28 ` [Qemu-devel] [PATCH 10/13] tcg-sparc: Use defines for temporaries Richard Henderson
2012-09-17 15:28 ` [Qemu-devel] [PATCH 11/13] tcg-sparc: Add %g/%o registers to alloc_order Richard Henderson
2012-09-17 15:28 ` [Qemu-devel] [PATCH 12/13] tcg-sparc: Fix and enable direct TB chaining Richard Henderson
2012-09-17 15:28 ` [Qemu-devel] [PATCH 13/13] tcg: Fix !USE_DIRECT_JUMP Richard Henderson
2012-09-17 15:50 ` Andreas Färber
2012-09-21 20:21 ` Stefan Weil
2012-09-21 10:28 ` Aurelien Jarno [this message]
2012-09-21 18:16 ` Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120921102850.GE4457@ohm.aurel32.net \
--to=aurelien@aurel32.net \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.