From: Kevin Daughtridge <kevin-ZgHIA9YJVL4@public.gmane.org>
To: Jiri Kosina <jkosina-AlSwsSmVLrQ@public.gmane.org>,
linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [PATCH] usbhid: call report_fixup before comparing descriptors
Date: Mon, 17 Sep 2012 13:05:06 -0700 [thread overview]
Message-ID: <50578272.1020902@kdau.com> (raw)
hid_post_reset checks the stored report descriptor against what is currently
returned by the device. An HID driver's report_fixup method may have
changed the
stored descriptor, however, creating false positives. These leave some
devices
nonfunctional after a resume, with a "reset_resume error 1" reported.
This patch
passes the new descriptor to the driver's report_fixup method, if any,
before it
is compared to the stored one.
BugLink: http://bugs.launchpad.net/bugs/1049623
Signed-off-by: Kevin Daughtridge <kevin-ZgHIA9YJVL4@public.gmane.org>
---
--- a/drivers/hid/usbhid/hid-core.c 2012-08-20 10:17:09.000000000 -0700
+++ b/drivers/hid/usbhid/hid-core.c 2012-09-16 18:51:45.381868737 -0700
@@ -1436,6 +1436,10 @@ static int hid_post_reset(struct usb_int
kfree(rdesc);
return 1;
}
+
+ if (hid->driver && hid->driver->report_fixup)
+ rdesc = hid->driver->report_fixup(hid, rdesc, &status);
+
status = memcmp(rdesc, hid->rdesc, hid->rsize);
kfree(rdesc);
if (status != 0) {
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Daughtridge <kevin@kdau.com>
To: Jiri Kosina <jkosina@suse.cz>, linux-input@vger.kernel.org
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] usbhid: call report_fixup before comparing descriptors
Date: Mon, 17 Sep 2012 13:05:06 -0700 [thread overview]
Message-ID: <50578272.1020902@kdau.com> (raw)
hid_post_reset checks the stored report descriptor against what is currently
returned by the device. An HID driver's report_fixup method may have
changed the
stored descriptor, however, creating false positives. These leave some
devices
nonfunctional after a resume, with a "reset_resume error 1" reported.
This patch
passes the new descriptor to the driver's report_fixup method, if any,
before it
is compared to the stored one.
BugLink: http://bugs.launchpad.net/bugs/1049623
Signed-off-by: Kevin Daughtridge <kevin@kdau.com>
---
--- a/drivers/hid/usbhid/hid-core.c 2012-08-20 10:17:09.000000000 -0700
+++ b/drivers/hid/usbhid/hid-core.c 2012-09-16 18:51:45.381868737 -0700
@@ -1436,6 +1436,10 @@ static int hid_post_reset(struct usb_int
kfree(rdesc);
return 1;
}
+
+ if (hid->driver && hid->driver->report_fixup)
+ rdesc = hid->driver->report_fixup(hid, rdesc, &status);
+
status = memcmp(rdesc, hid->rdesc, hid->rsize);
kfree(rdesc);
if (status != 0) {
next reply other threads:[~2012-09-17 20:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-17 20:05 Kevin Daughtridge [this message]
2012-09-17 20:05 ` [PATCH] usbhid: call report_fixup before comparing descriptors Kevin Daughtridge
[not found] ` <50578272.1020902-ZgHIA9YJVL4@public.gmane.org>
2012-09-18 12:00 ` Sergei Shtylyov
2012-09-18 12:00 ` Sergei Shtylyov
2012-09-18 16:16 ` Henrik Rydberg
2012-09-19 2:21 ` Kevin Daughtridge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50578272.1020902@kdau.com \
--to=kevin-zghia9yjvl4@public.gmane.org \
--cc=jkosina-AlSwsSmVLrQ@public.gmane.org \
--cc=linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.