From: Michael Neuling <mikey@neuling.org>
To: Jan Dittmer <jdi@l4x.org>
Cc: hskinnemoen@atmel.com, heiko.carstens@de.ibm.com,
linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
Paul Mackerras <paulus@samba.org>, Alan Cox <alan@redhat.com>,
akpm@linux-foundation.org,
Linus Torvalds <torvalds@linux-foundation.org>,
davem@davemloft.net
Subject: Re: Define termios_1 functions for powerpc, s390, avr32 and frv
Date: Thu, 13 Sep 2007 17:22:36 +1000 [thread overview]
Message-ID: <5058.1189668156@neuling.org> (raw)
In-Reply-To: <46E8DF49.7090402@l4x.org>
> > Commit f629307c857c030d5a3dd777fee37c8bb395e171 introduced uses of
> > kernel_termios_to_user_termios_1 and user_termios_to_kernel_termios_1
> > on all architectures. However, powerpc, s390, avr32 and frv don't
> > currently define those functions since their termios struct didn't
> > need to be changed when the arbitrary baud rate stuff was added, and
> > thus the kernel won't currently build on those architectures.
>
> alpha, parisc, sh, sparc{64,}, xtensa are still broken with this error...
They need to include <asm-generic/termios.h> in asm-<arch>/termios.h
like in powerpc.
Alternatively tonyb's patch should fix them. Could also do that?
Mikey
WARNING: multiple messages have this Message-ID (diff)
From: Michael Neuling <mikey@neuling.org>
To: Jan Dittmer <jdi@l4x.org>
Cc: Paul Mackerras <paulus@samba.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
akpm@linux-foundation.org, Tony Breeds <tony@bakeyournoodle.com>,
linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
Alan Cox <alan@redhat.com>,
davem@davemloft.net, heiko.carstens@de.ibm.com,
hskinnemoen@atmel.com, dhowells@redhat.com
Subject: Re: Define termios_1 functions for powerpc, s390, avr32 and frv
Date: Thu, 13 Sep 2007 17:22:36 +1000 [thread overview]
Message-ID: <5058.1189668156@neuling.org> (raw)
In-Reply-To: <46E8DF49.7090402@l4x.org>
> > Commit f629307c857c030d5a3dd777fee37c8bb395e171 introduced uses of
> > kernel_termios_to_user_termios_1 and user_termios_to_kernel_termios_1
> > on all architectures. However, powerpc, s390, avr32 and frv don't
> > currently define those functions since their termios struct didn't
> > need to be changed when the arbitrary baud rate stuff was added, and
> > thus the kernel won't currently build on those architectures.
>
> alpha, parisc, sh, sparc{64,}, xtensa are still broken with this error...
They need to include <asm-generic/termios.h> in asm-<arch>/termios.h
like in powerpc.
Alternatively tonyb's patch should fix them. Could also do that?
Mikey
next prev parent reply other threads:[~2007-09-13 7:22 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-12 15:16 Define termios_1 functions for powerpc, s390, avr32 and frv Paul Mackerras
2007-09-12 15:16 ` Paul Mackerras
2007-09-12 16:09 ` Linus Torvalds
2007-09-12 16:09 ` Linus Torvalds
2007-09-13 6:57 ` Jan Dittmer
2007-09-13 6:57 ` Jan Dittmer
2007-09-13 7:11 ` David Miller
2007-09-13 7:11 ` David Miller
2007-09-13 7:22 ` Michael Neuling [this message]
2007-09-13 7:22 ` Michael Neuling
2007-09-13 9:53 ` Paul Mundt
2007-09-13 9:53 ` Paul Mundt
2007-09-13 10:55 ` Andrew Morton
2007-09-13 10:55 ` Andrew Morton
2007-09-14 18:33 ` David Miller
2007-09-14 18:33 ` David Miller
2007-09-14 22:12 ` Andrew Morton
2007-09-14 22:12 ` Andrew Morton
2007-09-14 22:30 ` David Miller
2007-09-14 22:30 ` David Miller
2007-09-13 16:31 ` Alan Cox
2007-09-13 16:31 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5058.1189668156@neuling.org \
--to=mikey@neuling.org \
--cc=akpm@linux-foundation.org \
--cc=alan@redhat.com \
--cc=davem@davemloft.net \
--cc=heiko.carstens@de.ibm.com \
--cc=hskinnemoen@atmel.com \
--cc=jdi@l4x.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.