All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: "Andreas Färber" <afaerber@suse.de>
Cc: Gerhard Wiesinger <lists@wiesinger.com>,
	qemu-devel@nongnu.org, qemu-stable@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-stable] [PATCH] make_device_config.sh: Fix target path in generated dependency file
Date: Tue, 18 Sep 2012 16:29:47 +0400	[thread overview]
Message-ID: <5058693B.9020103@msgid.tls.msk.ru> (raw)
In-Reply-To: <1339086183-1356-1-git-send-email-afaerber@suse.de>

Has it been applied to anything?  I don't think so.
Is it still needed?

Thanks,

/mjt

On 07.06.2012 20:23, Andreas Färber wrote:
> config-devices.mak.d is included from Makefile.target, i.e. from inside
> the *-softmmu/ directory. It included the directory path, so never
> applied to the actual config-devices.mak. Symptoms were spurious
> dependency issues with default-configs/pci.mak.
> 
> Fix by using `basename` to strip the directory path.
> 
> Reported-by: Gerhard Wiesinger <lists@wiesinger.com>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> ---
>  Seems I forgot to send this out before 1.1...
> 
>  scripts/make_device_config.sh |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/scripts/make_device_config.sh b/scripts/make_device_config.sh
> index 5d14885..0778fe2 100644
> --- a/scripts/make_device_config.sh
> +++ b/scripts/make_device_config.sh
> @@ -25,4 +25,4 @@ done
>  process_includes $src > $dest
>  
>  cat $src $all_includes | grep -v '^include' > $dest
> -echo "$1: $all_includes" > $dep
> +echo "`basename $1`: $all_includes" > $dep

  reply	other threads:[~2012-09-18 12:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-07 16:23 [Qemu-devel] [PATCH] make_device_config.sh: Fix target path in generated dependency file Andreas Färber
2012-09-18 12:29 ` Michael Tokarev [this message]
2012-09-18 14:32   ` [Qemu-devel] [Qemu-stable] " Andreas Färber
2012-10-27  8:32     ` Michael Tokarev
2012-12-03 19:31       ` [Qemu-devel] [Qemu-stable] [PATCH 1.3] " mdroth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5058693B.9020103@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=afaerber@suse.de \
    --cc=lists@wiesinger.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.