* Re: [lm-sensors] [PATCH 4/4] hwmon: (ad7314) Add 'name' sysfs attribute
2012-09-11 20:52 [lm-sensors] [PATCH 4/4] hwmon: (ad7314) Add 'name' sysfs attribute Guenter Roeck
@ 2012-09-17 16:38 ` Guenter Roeck
2012-09-17 19:07 ` Jean Delvare
2012-09-18 20:10 ` Jonathan Cameron
2 siblings, 0 replies; 4+ messages in thread
From: Guenter Roeck @ 2012-09-17 16:38 UTC (permalink / raw)
To: lm-sensors
ping
On Tue, Sep 11, 2012 at 01:52:53PM -0700, Guenter Roeck wrote:
> The 'name' sysfs attribute is mandatory for hwmon devices, but was missing
> in this driver.
>
> Cc: Jonathan Cameron <jic23@cam.ac.uk>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> candidate for -stable
>
> drivers/hwmon/ad7314.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/hwmon/ad7314.c b/drivers/hwmon/ad7314.c
> index 455294f..37c01e7 100644
> --- a/drivers/hwmon/ad7314.c
> +++ b/drivers/hwmon/ad7314.c
> @@ -87,10 +87,18 @@ static ssize_t ad7314_show_temperature(struct device *dev,
> }
> }
>
> +static ssize_t ad7314_show_name(struct device *dev,
> + struct device_attribute *devattr, char *buf)
> +{
> + return sprintf(buf, "%s\n", to_spi_device(dev)->modalias);
> +}
> +
> +static DEVICE_ATTR(name, S_IRUGO, ad7314_show_name, NULL);
> static SENSOR_DEVICE_ATTR(temp1_input, S_IRUGO,
> ad7314_show_temperature, NULL, 0);
>
> static struct attribute *ad7314_attributes[] = {
> + &dev_attr_name.attr,
> &sensor_dev_attr_temp1_input.dev_attr.attr,
> NULL,
> };
> --
> 1.7.9.7
>
>
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [lm-sensors] [PATCH 4/4] hwmon: (ad7314) Add 'name' sysfs attribute
2012-09-11 20:52 [lm-sensors] [PATCH 4/4] hwmon: (ad7314) Add 'name' sysfs attribute Guenter Roeck
2012-09-17 16:38 ` Guenter Roeck
@ 2012-09-17 19:07 ` Jean Delvare
2012-09-18 20:10 ` Jonathan Cameron
2 siblings, 0 replies; 4+ messages in thread
From: Jean Delvare @ 2012-09-17 19:07 UTC (permalink / raw)
To: lm-sensors
On Tue, 11 Sep 2012 13:52:53 -0700, Guenter Roeck wrote:
> The 'name' sysfs attribute is mandatory for hwmon devices, but was missing
> in this driver.
>
> Cc: Jonathan Cameron <jic23@cam.ac.uk>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> candidate for -stable
>
> drivers/hwmon/ad7314.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/hwmon/ad7314.c b/drivers/hwmon/ad7314.c
> index 455294f..37c01e7 100644
> --- a/drivers/hwmon/ad7314.c
> +++ b/drivers/hwmon/ad7314.c
> @@ -87,10 +87,18 @@ static ssize_t ad7314_show_temperature(struct device *dev,
> }
> }
>
> +static ssize_t ad7314_show_name(struct device *dev,
> + struct device_attribute *devattr, char *buf)
> +{
> + return sprintf(buf, "%s\n", to_spi_device(dev)->modalias);
> +}
> +
> +static DEVICE_ATTR(name, S_IRUGO, ad7314_show_name, NULL);
> static SENSOR_DEVICE_ATTR(temp1_input, S_IRUGO,
> ad7314_show_temperature, NULL, 0);
>
> static struct attribute *ad7314_attributes[] = {
> + &dev_attr_name.attr,
> &sensor_dev_attr_temp1_input.dev_attr.attr,
> NULL,
> };
Acked-by: Jean Delvare <khali@linux-fr.org>
--
Jean Delvare
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [lm-sensors] [PATCH 4/4] hwmon: (ad7314) Add 'name' sysfs attribute
2012-09-11 20:52 [lm-sensors] [PATCH 4/4] hwmon: (ad7314) Add 'name' sysfs attribute Guenter Roeck
2012-09-17 16:38 ` Guenter Roeck
2012-09-17 19:07 ` Jean Delvare
@ 2012-09-18 20:10 ` Jonathan Cameron
2 siblings, 0 replies; 4+ messages in thread
From: Jonathan Cameron @ 2012-09-18 20:10 UTC (permalink / raw)
To: lm-sensors
On 09/17/2012 05:38 PM, Guenter Roeck wrote:
> ping
>
> On Tue, Sep 11, 2012 at 01:52:53PM -0700, Guenter Roeck wrote:
>> The 'name' sysfs attribute is mandatory for hwmon devices, but was missing
>> in this driver.
Sorry, completely forgot about this.
Acked-by: Jonathan Cameron <jic23@kernel.org>
>>
>> Cc: Jonathan Cameron <jic23@cam.ac.uk>
>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>> ---
>> candidate for -stable
>>
>> drivers/hwmon/ad7314.c | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>>
>> diff --git a/drivers/hwmon/ad7314.c b/drivers/hwmon/ad7314.c
>> index 455294f..37c01e7 100644
>> --- a/drivers/hwmon/ad7314.c
>> +++ b/drivers/hwmon/ad7314.c
>> @@ -87,10 +87,18 @@ static ssize_t ad7314_show_temperature(struct device *dev,
>> }
>> }
>>
>> +static ssize_t ad7314_show_name(struct device *dev,
>> + struct device_attribute *devattr, char *buf)
>> +{
>> + return sprintf(buf, "%s\n", to_spi_device(dev)->modalias);
>> +}
>> +
>> +static DEVICE_ATTR(name, S_IRUGO, ad7314_show_name, NULL);
>> static SENSOR_DEVICE_ATTR(temp1_input, S_IRUGO,
>> ad7314_show_temperature, NULL, 0);
>>
>> static struct attribute *ad7314_attributes[] = {
>> + &dev_attr_name.attr,
>> &sensor_dev_attr_temp1_input.dev_attr.attr,
>> NULL,
>> };
>> --
>> 1.7.9.7
>>
>>
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 4+ messages in thread