From: "Cousson, Benoit" <b-cousson@ti.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/3] ARM: OMAP2+: hwmod code: convert missing clockdomain warnings to debug messages
Date: Tue, 18 Sep 2012 16:50:39 -0500 [thread overview]
Message-ID: <5058ECAF.7010609@ti.com> (raw)
In-Reply-To: <20120918211251.16484.18401.stgit@dusk.lan>
Hi Paul,
On 9/18/2012 4:12 PM, Paul Walmsley wrote:
> The decision was made a few months ago to allow struct omap_hwmod
> records and struct clk records to omit clockdomain information if the
> clockdomain is not software-controllable. See for example commit
> 868c157df9721675c19729eed2c96bac6c3f1d01 ("ARM: OMAP2+: hwmod: remove
> prm_clkdm, cm_clkdm; allow hwmods to have no clockdomain").
>
> So convert an existing pr_warning() to a pr_debug() (regarding missing
> clockdomains in clocks), and add a pr_debug() for missing hwmod
> clockdomains.
At some point I sent you a small RFC to still keep the message if
neither oh->clkdm nor oh->_clk->clkdm was there. I've never had the time
to test it, but that should then cover OMAP2, 3 & 4 cases.
Regards,
Benoit
> It's still useful to enable these messages for
> debugging, since missing clockdomains can cause hard-to-debug problems
> with power management; see for example commit
> 6c4a057bffe9823221eab547e11fac181dc18a2b ("ARM: OMAP4: clock data:
> Force a DPLL clkdm/pwrdm ON before a relock").
>
> Signed-off-by: Paul Walmsley <paul@pwsan.com>
> Cc: Benoît Cousson <b-cousson@ti.com>
> ---
> arch/arm/mach-omap2/omap_hwmod.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/omap_hwmod.c b/arch/arm/mach-omap2/omap_hwmod.c
> index 80cea5b..e05228a 100644
> --- a/arch/arm/mach-omap2/omap_hwmod.c
> +++ b/arch/arm/mach-omap2/omap_hwmod.c
> @@ -685,8 +685,8 @@ static int _init_main_clk(struct omap_hwmod *oh)
> }
>
> if (!oh->_clk->clkdm)
> - pr_warning("omap_hwmod: %s: missing clockdomain for %s.\n",
> - oh->main_clk, oh->_clk->name);
> + pr_debug("omap_hwmod: %s: missing clockdomain for %s.\n",
> + oh->main_clk, oh->_clk->name);
>
> return ret;
> }
> @@ -1380,8 +1380,10 @@ static struct omap_hwmod *_lookup(const char *name)
> */
> static int _init_clkdm(struct omap_hwmod *oh)
> {
> - if (!oh->clkdm_name)
> + if (!oh->clkdm_name) {
> + pr_debug("omap_hwmod: %s: missing clockdomain\n", oh->name);
> return 0;
> + }
>
> oh->clkdm = clkdm_lookup(oh->clkdm_name);
> if (!oh->clkdm) {
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: b-cousson@ti.com (Cousson, Benoit)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] ARM: OMAP2+: hwmod code: convert missing clockdomain warnings to debug messages
Date: Tue, 18 Sep 2012 16:50:39 -0500 [thread overview]
Message-ID: <5058ECAF.7010609@ti.com> (raw)
In-Reply-To: <20120918211251.16484.18401.stgit@dusk.lan>
Hi Paul,
On 9/18/2012 4:12 PM, Paul Walmsley wrote:
> The decision was made a few months ago to allow struct omap_hwmod
> records and struct clk records to omit clockdomain information if the
> clockdomain is not software-controllable. See for example commit
> 868c157df9721675c19729eed2c96bac6c3f1d01 ("ARM: OMAP2+: hwmod: remove
> prm_clkdm, cm_clkdm; allow hwmods to have no clockdomain").
>
> So convert an existing pr_warning() to a pr_debug() (regarding missing
> clockdomains in clocks), and add a pr_debug() for missing hwmod
> clockdomains.
At some point I sent you a small RFC to still keep the message if
neither oh->clkdm nor oh->_clk->clkdm was there. I've never had the time
to test it, but that should then cover OMAP2, 3 & 4 cases.
Regards,
Benoit
> It's still useful to enable these messages for
> debugging, since missing clockdomains can cause hard-to-debug problems
> with power management; see for example commit
> 6c4a057bffe9823221eab547e11fac181dc18a2b ("ARM: OMAP4: clock data:
> Force a DPLL clkdm/pwrdm ON before a relock").
>
> Signed-off-by: Paul Walmsley <paul@pwsan.com>
> Cc: Beno?t Cousson <b-cousson@ti.com>
> ---
> arch/arm/mach-omap2/omap_hwmod.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/omap_hwmod.c b/arch/arm/mach-omap2/omap_hwmod.c
> index 80cea5b..e05228a 100644
> --- a/arch/arm/mach-omap2/omap_hwmod.c
> +++ b/arch/arm/mach-omap2/omap_hwmod.c
> @@ -685,8 +685,8 @@ static int _init_main_clk(struct omap_hwmod *oh)
> }
>
> if (!oh->_clk->clkdm)
> - pr_warning("omap_hwmod: %s: missing clockdomain for %s.\n",
> - oh->main_clk, oh->_clk->name);
> + pr_debug("omap_hwmod: %s: missing clockdomain for %s.\n",
> + oh->main_clk, oh->_clk->name);
>
> return ret;
> }
> @@ -1380,8 +1380,10 @@ static struct omap_hwmod *_lookup(const char *name)
> */
> static int _init_clkdm(struct omap_hwmod *oh)
> {
> - if (!oh->clkdm_name)
> + if (!oh->clkdm_name) {
> + pr_debug("omap_hwmod: %s: missing clockdomain\n", oh->name);
> return 0;
> + }
>
> oh->clkdm = clkdm_lookup(oh->clkdm_name);
> if (!oh->clkdm) {
>
>
next prev parent reply other threads:[~2012-09-18 21:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-18 21:12 [PATCH 0/3] ARM: OMAP2+: hwmod: resolve some OMAP4 warnings Paul Walmsley
2012-09-18 21:12 ` Paul Walmsley
2012-09-18 21:12 ` [PATCH 1/3] ARM: OMAP4: hwmod data: add missing HWMOD_NO_IDLEST flags to some PRCM IP blocks Paul Walmsley
2012-09-18 21:12 ` Paul Walmsley
2012-09-18 21:12 ` [PATCH 2/3] ARM: OMAP4+: hwmod code: remove clkdm requirement in _omap4_wait_target_*() Paul Walmsley
2012-09-18 21:12 ` Paul Walmsley
2012-09-18 21:12 ` [PATCH 3/3] ARM: OMAP2+: hwmod code: convert missing clockdomain warnings to debug messages Paul Walmsley
2012-09-18 21:12 ` Paul Walmsley
2012-09-18 21:50 ` Cousson, Benoit [this message]
2012-09-18 21:50 ` Cousson, Benoit
2012-09-19 22:48 ` Paul Walmsley
2012-09-19 22:48 ` Paul Walmsley
2012-09-19 22:58 ` Cousson, Benoit
2012-09-19 22:58 ` Cousson, Benoit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5058ECAF.7010609@ti.com \
--to=b-cousson@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.