Re: [PATCH 2/5]KVM:x86, apicv: adjust for virtual interrupt delivery

[Avi Kivity <avi@redhat.com>]

On 09/17/2012 02:28 PM, Li, Jiongxi wrote:
>> > > +	} else if (kvm_apic_vid_enabled(vcpu)) {
>> > > +		if (kvm_cpu_has_interrupt_apic_vid(vcpu) &&
>> > > +		    kvm_x86_ops->interrupt_allowed(vcpu)) {
>> > > +			kvm_queue_interrupt(vcpu,
>> > > +				kvm_cpu_get_interrupt_apic_vid(vcpu), false);
>> > > +			kvm_x86_ops->set_irq(vcpu);
>> > > +		}
>> >
>> > It may be simpler to change kvm_cpu_{has,get}_interrupt to ignore the
>> > apic if virtual interrupt delivery is enabled.
>> OKs
> 
> Kvm_cpu_has_interrupt is also called in other place, no just used to judge whether 
> to inject interrupt manually. For instance, it is called in
kvm_arch_vcpu_runnable.
> In that case, apic can't be ingored. So for safety, I think it is
better to use another
> function here other than change the original kvm_cpu_has_interrupt
function.

Good point.

We can call them *_extint(), since that's what they're accepting.

-- 
error compiling committee.c: too many arguments to function