From: Michael Tokarev <mjt@tls.msk.ru>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Alon Levy <alevy@redhat.com>,
qemu-devel@nongnu.org, Dunrong Huang <riegamaths@gmail.com>
Subject: Re: [Qemu-devel] [PATCH] qxl/update_area_io: cleanup invalid parameters handling
Date: Thu, 20 Sep 2012 10:43:26 +0400 [thread overview]
Message-ID: <505ABB0E.9030305@msgid.tls.msk.ru> (raw)
In-Reply-To: <505ABA90.6070002@redhat.com>
On 20.09.2012 10:41, Gerd Hoffmann wrote:
> On 09/19/12 15:41, Michael Tokarev wrote:
>> This cleans up two additions of almost the same code in commits
>> 511b13e2c9 and ccc2960d654. While at it, make error paths
>> consistent (always use 'break' instead of 'return').
>
> Other way around: should be 'return' not 'break'.
In other, early-added, error-return places it is "break".
For now it is irrelevant actually, since right after the
switch we already have "return", so "break" is now the
same as "return". For future it might not be the case.
/mjt
next prev parent reply other threads:[~2012-09-20 6:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-19 13:41 [Qemu-devel] [PATCH] qxl/update_area_io: cleanup invalid parameters handling Michael Tokarev
2012-09-20 6:41 ` Gerd Hoffmann
2012-09-20 6:43 ` Michael Tokarev [this message]
2012-09-20 6:50 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=505ABB0E.9030305@msgid.tls.msk.ru \
--to=mjt@tls.msk.ru \
--cc=alevy@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=riegamaths@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.