From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: vikram186@gmail.com, Josh Wu <josh.wu@atmel.com>,
linux-mtd@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, dedekind1@gmail.com
Subject: Re: [PATCH v2] mtd: atmel_nand: fix the compile error which miss label "err_ecc_ioremap".
Date: Thu, 20 Sep 2012 10:20:48 +0200 [thread overview]
Message-ID: <505AD1E0.2040607@atmel.com> (raw)
In-Reply-To: <20120920052333.GC17667@game.jcrosoft.org>
On 09/20/2012 07:23 AM, Jean-Christophe PLAGNIOL-VILLARD :
> On 15:10 Tue 11 Sep , Josh Wu wrote:
>> Add err_ecc_ioremap label to fix following errors:
>> ---8<---
>> CC drivers/mtd/nand/atmel_nand.o
>> drivers/mtd/nand/atmel_nand.c: In function 'atmel_nand_probe':
>> drivers/mtd/nand/atmel_nand.c:1423: error: label 'err_ecc_ioremap' used but not defined
>> make[3]: *** [drivers/mtd/nand/atmel_nand.o] Error 1
>> make[2]: *** [drivers/mtd/nand] Error 2
>> make[1]: *** [drivers/mtd] Error 2
>> make: *** [drivers] Error 2
>> --->8---
> switch to devm_xxx instead this will simplify the error patch and remove patch
As far as I understand, it is a correction patch: so my advice would be
to take this patch for fixing the current code (for 3.7 if I recall well).
If we want to move to the new devm_xxx API, we can do it once the
current code is fixed.
Bye,
--
Nicolas Ferre
WARNING: multiple messages have this Message-ID (diff)
From: nicolas.ferre@atmel.com (Nicolas Ferre)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] mtd: atmel_nand: fix the compile error which miss label "err_ecc_ioremap".
Date: Thu, 20 Sep 2012 10:20:48 +0200 [thread overview]
Message-ID: <505AD1E0.2040607@atmel.com> (raw)
In-Reply-To: <20120920052333.GC17667@game.jcrosoft.org>
On 09/20/2012 07:23 AM, Jean-Christophe PLAGNIOL-VILLARD :
> On 15:10 Tue 11 Sep , Josh Wu wrote:
>> Add err_ecc_ioremap label to fix following errors:
>> ---8<---
>> CC drivers/mtd/nand/atmel_nand.o
>> drivers/mtd/nand/atmel_nand.c: In function 'atmel_nand_probe':
>> drivers/mtd/nand/atmel_nand.c:1423: error: label 'err_ecc_ioremap' used but not defined
>> make[3]: *** [drivers/mtd/nand/atmel_nand.o] Error 1
>> make[2]: *** [drivers/mtd/nand] Error 2
>> make[1]: *** [drivers/mtd] Error 2
>> make: *** [drivers] Error 2
>> --->8---
> switch to devm_xxx instead this will simplify the error patch and remove patch
As far as I understand, it is a correction patch: so my advice would be
to take this patch for fixing the current code (for 3.7 if I recall well).
If we want to move to the new devm_xxx API, we can do it once the
current code is fixed.
Bye,
--
Nicolas Ferre
next prev parent reply other threads:[~2012-09-20 8:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-11 7:10 [PATCH v2] mtd: atmel_nand: fix the compile error which miss label "err_ecc_ioremap" Josh Wu
2012-09-11 7:10 ` Josh Wu
2012-09-20 2:03 ` Josh Wu
2012-09-20 2:03 ` Josh Wu
2012-09-20 5:23 ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-20 5:23 ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-20 8:20 ` Nicolas Ferre [this message]
2012-09-20 8:20 ` Nicolas Ferre
2012-09-21 10:16 ` Josh Wu
2012-09-21 10:16 ` Josh Wu
2012-09-23 12:41 ` Artem Bityutskiy
2012-09-23 12:41 ` Artem Bityutskiy
2012-09-23 13:01 ` Artem Bityutskiy
2012-09-23 13:01 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=505AD1E0.2040607@atmel.com \
--to=nicolas.ferre@atmel.com \
--cc=dedekind1@gmail.com \
--cc=josh.wu@atmel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=plagnioj@jcrosoft.com \
--cc=vikram186@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.