From: Jan Kiszka <jan.kiszka@siemens.com>
To: Philippe Gerum <rpm@xenomai.org>
Cc: "Mauerer, Wolfgang" <wolfgang.mauerer@siemens.com>,
Xenomai <xenomai@xenomai.org>
Subject: Re: [Xenomai] [PATCH] Revert "ipipe: ipipe_request_irq(), ipipe_free_irq() are root-only services"
Date: Thu, 20 Sep 2012 13:27:01 +0200 [thread overview]
Message-ID: <505AFD85.5090500@siemens.com> (raw)
In-Reply-To: <505AFACC.1050802@siemens.com>
On 2012-09-20 13:15, Jan Kiszka wrote:
>> Sorry, three bugs:
>> - in the RTDM spec as it always allowed rtdm_irq_request over RT task
>> contexts
>
> Changing the spec and adding a runtime check will likely be no issue. No
> sane driver should have made use of that option. I will file a patch.
Naturally, this also affects rtdm_irq_enable/disable, and some use cases
I'm aware off will bail out when we add assertions for non-RT context.
I would prefer to address it more selectively, allowing all those
services for IRQ types that support it (i.e. that can be atomically
enabled/disabled), keeping the freedom to reject or otherwise fail for
types that are in conflict.
Jan
--
Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2012-09-20 11:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-20 10:37 [Xenomai] [PATCH] Revert "ipipe: ipipe_request_irq(), ipipe_free_irq() are root-only services" Jan Kiszka
2012-09-20 10:49 ` Philippe Gerum
2012-09-20 10:56 ` Jan Kiszka
2012-09-20 10:57 ` Jan Kiszka
2012-09-20 11:06 ` Philippe Gerum
2012-09-20 11:15 ` Jan Kiszka
2012-09-20 11:27 ` Jan Kiszka [this message]
2012-09-20 13:01 ` Gilles Chanteperdrix
2012-09-20 13:15 ` Jan Kiszka
2012-09-20 14:12 ` Gilles Chanteperdrix
2012-09-20 15:00 ` Jan Kiszka
2012-09-20 15:13 ` Gilles Chanteperdrix
2012-09-20 13:10 ` Philippe Gerum
2012-09-20 13:54 ` Jan Kiszka
2012-09-20 14:05 ` Philippe Gerum
2012-09-20 15:07 ` Jan Kiszka
2012-09-20 15:16 ` Philippe Gerum
2012-09-20 15:45 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=505AFD85.5090500@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=rpm@xenomai.org \
--cc=wolfgang.mauerer@siemens.com \
--cc=xenomai@xenomai.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.