All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: Philippe Gerum <rpm@xenomai.org>,
	Gilles Chanteperdrix <gilles.chanteperdrix@xenomai.org>
Cc: Wolfgang Mauerer <wolfgang.mauerer@siemens.com>,
	Xenomai <xenomai@xenomai.org>
Subject: [Xenomai] [PATCH] Revert "ipipe: ipipe_request_irq(), ipipe_free_irq() are root-only services"
Date: Thu, 20 Sep 2012 12:37:57 +0200	[thread overview]
Message-ID: <505AF205.6010206@siemens.com> (raw)

This reverts commit 073ff1e8045d0311b8cf390687c0ba3619681672.

Both service are NOT just root-only services. E.g., rtdm_irq_request
requires by specification support also over non-Linux contexts.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---

We run all critical code under an I-pipe spin lock, so this restriction
seems artificial. Nevertheless, I briefly checked if some arch has
specific needs but didn't find any trace in core-3.5.

Wolfgang, this already resolves the issue I mentioned regarding startup
of RTnet NICs.

 kernel/ipipe/core.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/kernel/ipipe/core.c b/kernel/ipipe/core.c
index 9898b92..23a2146 100644
--- a/kernel/ipipe/core.c
+++ b/kernel/ipipe/core.c
@@ -846,8 +846,6 @@ int ipipe_request_irq(struct ipipe_domain *ipd,
 	unsigned long flags;
 	int ret = 0;
 
-	ipipe_root_only();
-
 	if (handler == NULL ||
 	    (irq >= IPIPE_NR_XIRQS && !ipipe_virtual_irq_p(irq)))
 		return -EINVAL;
@@ -881,8 +879,6 @@ void ipipe_free_irq(struct ipipe_domain *ipd,
 {
 	unsigned long flags;
 
-	ipipe_root_only();
-
 	spin_lock_irqsave(&__ipipe_lock, flags);
 
 	if (ipd->irqs[irq].handler == NULL)
-- 
1.7.3.4


             reply	other threads:[~2012-09-20 10:37 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-20 10:37 Jan Kiszka [this message]
2012-09-20 10:49 ` [Xenomai] [PATCH] Revert "ipipe: ipipe_request_irq(), ipipe_free_irq() are root-only services" Philippe Gerum
2012-09-20 10:56   ` Jan Kiszka
2012-09-20 10:57     ` Jan Kiszka
2012-09-20 11:06       ` Philippe Gerum
2012-09-20 11:15       ` Jan Kiszka
2012-09-20 11:27         ` Jan Kiszka
2012-09-20 13:01         ` Gilles Chanteperdrix
2012-09-20 13:15           ` Jan Kiszka
2012-09-20 14:12             ` Gilles Chanteperdrix
2012-09-20 15:00               ` Jan Kiszka
2012-09-20 15:13                 ` Gilles Chanteperdrix
2012-09-20 13:10         ` Philippe Gerum
2012-09-20 13:54           ` Jan Kiszka
2012-09-20 14:05             ` Philippe Gerum
2012-09-20 15:07               ` Jan Kiszka
2012-09-20 15:16                 ` Philippe Gerum
2012-09-20 15:45                   ` Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=505AF205.6010206@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=gilles.chanteperdrix@xenomai.org \
    --cc=rpm@xenomai.org \
    --cc=wolfgang.mauerer@siemens.com \
    --cc=xenomai@xenomai.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.