From: Or Gerlitz <ogerlitz@mellanox.com>
To: Marcelo Ricardo Leitner <mleitner@redhat.com>
Cc: netdev <netdev@vger.kernel.org>,
Yevgeny Petrilin <yevgenyp@mellanox.com>,
Amir Vadai <amirv@mellanox.com>
Subject: Re: mlx4: dropping multicast packets at promisc leave
Date: Thu, 20 Sep 2012 16:21:56 +0300 [thread overview]
Message-ID: <505B1874.3040904@mellanox.com> (raw)
In-Reply-To: <505A66CC.8010701@redhat.com>
On 20/09/2012 03:43, Marcelo Ricardo Leitner wrote:
> I have a report that our mlx4 driver (RHEL 6.3) is dropping multicast
> packets when NIC leaves promisc mode. It seems this is being cause due
> to the new steering mode that took place near by commit
> 1679200f91da6a054b06954c9bd3eeed29b6731f. As it seems, the new
> steering mode needs more commands/time to leave the promisc mode,
> which may be leading to packet drops.
Marcelo,
The commit you point on below 6d19993 "net/mlx4_en: Re-design multicast
attachments flow" makes sure to avoid
doing extra firmware comments and not leave a window in time where
"correct" addresses are not attached. Its hard to say what's the case on
that RHEL 6.3 system, it would be very helpful through if you manage to
reproduce the problem on an upstream kernel -- BTW you didn't say on
which kernel you are trying to reproduce this, note that upstream has
also commit 60d31c1475f2 "net/mlx4_core: Looking for promiscuous entries
on the correct port" (reported by you...) , so if somehow this commit
makes the diff you could use it also on their system.
> It takes 300ms to perform the change there against my 600us. Hitting
> something like tcpdump -c 10 in a loop helps triggering it.
Do you have any insight for this huge difference?
Or.
next prev parent reply other threads:[~2012-09-20 13:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-20 0:43 mlx4: dropping multicast packets at promisc leave Marcelo Ricardo Leitner
2012-09-20 13:21 ` Or Gerlitz [this message]
2012-09-20 15:04 ` Marcelo Ricardo Leitner
2012-09-21 18:32 ` Marcelo Ricardo Leitner
2012-09-27 20:37 ` Marcelo Ricardo Leitner
2012-09-27 20:45 ` Or Gerlitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=505B1874.3040904@mellanox.com \
--to=ogerlitz@mellanox.com \
--cc=amirv@mellanox.com \
--cc=mleitner@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=yevgenyp@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.