From: Jens Axboe <axboe@kernel.dk>
To: Konrad Rzeszutek Wilk <konrad@kernel.org>
Cc: Minchan Kim <minchan@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Nitin Gupta <ngupta@vflare.org>,
Seth Jennings <sjenning@linux.vnet.ibm.com>,
Dan Magenheimer <dan.magenheimer@oracle.com>,
Konrad Rzeszutek Wilk <konrad@darnok.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: Query of zram/zsmalloc promotion
Date: Fri, 21 Sep 2012 20:31:37 +0200 [thread overview]
Message-ID: <505CB289.2040307@kernel.dk> (raw)
In-Reply-To: <20120921164112.GD4780@phenom.dumpdata.com>
On 2012-09-21 18:41, Konrad Rzeszutek Wilk wrote:
> On Wed, Sep 12, 2012 at 11:39:14AM +0900, Minchan Kim wrote:
>> Hi all,
>>
>> I would like to promote zram/zsmalloc from staging tree.
>> I already tried it https://lkml.org/lkml/2012/8/8/37 but I didn't get
>> any response from you guys.
>>
>> I think zram/zsmalloc's code qulity is good and they
>> are used for many embedded vendors for a long time.
>> So it's proper time to promote them.
>>
>> The zram should put on under driver/block/. I think it's not
>> arguable but the issue is which directory we should keep *zsmalloc*.
>>
>> Now Nitin want to keep it with zram so it would be in driver/blocks/zram/
>> But I don't like it because zsmalloc touches several fields of struct page
>> freely(and AFAIRC, Andrew had a same concern with me) so I want to put
>> it under mm/.
>
> I like the idea of keeping it in /lib or /mm. Actually 'lib' sounds more
> appropriate since it is dealing with storing a bunch of pages in a nice
> layout for great density purposes.
>>
>> In addtion, now zcache use it, too so it's rather awkward if we put it
>> under dirver/blocks/zram/.
>>
>> So questions.
>>
>> To Andrew:
>> Is it okay to put it under mm/ ? Or /lib?
>>
>> To Jens:
>> Is it okay to put zram under drvier/block/ If you are okay, I will start sending
>> patchset after I sort out zsmalloc's location issue.
>
> I would think it would be OK.
We can certainly put it in drivers/block, I have no issue with that.
--
Jens Axboe
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Jens Axboe <axboe@kernel.dk>
To: Konrad Rzeszutek Wilk <konrad@kernel.org>
Cc: Minchan Kim <minchan@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Nitin Gupta <ngupta@vflare.org>,
Seth Jennings <sjenning@linux.vnet.ibm.com>,
Dan Magenheimer <dan.magenheimer@oracle.com>,
Konrad Rzeszutek Wilk <konrad@darnok.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: Query of zram/zsmalloc promotion
Date: Fri, 21 Sep 2012 20:31:37 +0200 [thread overview]
Message-ID: <505CB289.2040307@kernel.dk> (raw)
In-Reply-To: <20120921164112.GD4780@phenom.dumpdata.com>
On 2012-09-21 18:41, Konrad Rzeszutek Wilk wrote:
> On Wed, Sep 12, 2012 at 11:39:14AM +0900, Minchan Kim wrote:
>> Hi all,
>>
>> I would like to promote zram/zsmalloc from staging tree.
>> I already tried it https://lkml.org/lkml/2012/8/8/37 but I didn't get
>> any response from you guys.
>>
>> I think zram/zsmalloc's code qulity is good and they
>> are used for many embedded vendors for a long time.
>> So it's proper time to promote them.
>>
>> The zram should put on under driver/block/. I think it's not
>> arguable but the issue is which directory we should keep *zsmalloc*.
>>
>> Now Nitin want to keep it with zram so it would be in driver/blocks/zram/
>> But I don't like it because zsmalloc touches several fields of struct page
>> freely(and AFAIRC, Andrew had a same concern with me) so I want to put
>> it under mm/.
>
> I like the idea of keeping it in /lib or /mm. Actually 'lib' sounds more
> appropriate since it is dealing with storing a bunch of pages in a nice
> layout for great density purposes.
>>
>> In addtion, now zcache use it, too so it's rather awkward if we put it
>> under dirver/blocks/zram/.
>>
>> So questions.
>>
>> To Andrew:
>> Is it okay to put it under mm/ ? Or /lib?
>>
>> To Jens:
>> Is it okay to put zram under drvier/block/ If you are okay, I will start sending
>> patchset after I sort out zsmalloc's location issue.
>
> I would think it would be OK.
We can certainly put it in drivers/block, I have no issue with that.
--
Jens Axboe
next prev parent reply other threads:[~2012-09-21 18:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-12 2:39 Query of zram/zsmalloc promotion Minchan Kim
2012-09-12 2:39 ` Minchan Kim
2012-09-21 16:41 ` Konrad Rzeszutek Wilk
2012-09-21 16:41 ` Konrad Rzeszutek Wilk
2012-09-21 18:31 ` Jens Axboe [this message]
2012-09-21 18:31 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=505CB289.2040307@kernel.dk \
--to=axboe@kernel.dk \
--cc=akpm@linux-foundation.org \
--cc=dan.magenheimer@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=konrad@darnok.org \
--cc=konrad@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=ngupta@vflare.org \
--cc=sjenning@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.