From: eric.nelson@boundarydevices.com (Eric Nelson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/6] staging: drm/imx: Add i.MX IPUv3 crtc support
Date: Sat, 22 Sep 2012 10:52:12 -0700 [thread overview]
Message-ID: <505DFACC.7010604@boundarydevices.com> (raw)
In-Reply-To: <20120922101727.GG1322@pengutronix.de>
On 09/22/2012 03:17 AM, Sascha Hauer wrote:
> Hi Eric,
>
> On Fri, Sep 21, 2012 at 09:24:19AM -0700, Eric Nelson wrote:
>> Hi Sascha,
>>
>>
>> But ipu_crtc->imx_crtc gets initialized in this call, and
>> ipu_irq_handler() makes use of it.
>>
>> The U-Boot code doesn't enable interrupts, so it's not acking
>> along the way, and leaves bits set in IPU1_INT_STAT_15.
>>
>> I found that I can get around this in U-Boot by disabling the
>> LCD controller and acking all of the interrupts after disabling
>> the controller, but I haven't yet figured out where to tap into
>> cleanup_before_linux().
>
> Passing over an enabled IPU from the bootloader to the kernel is
> (currently) not a supported usecase, so U-Boot should indeed disable it.
> That said, the kernel driver should make sure the IPU is sufficiently
> configured before the interrupts are enabled, so this seems to be a bug
> that deserves fixing.
>
Thanks Sascha,
Patches for U-Boot are in process.
http://lists.denx.de/pipermail/u-boot/2012-September/134807.html
Regards,
Eric
WARNING: multiple messages have this Message-ID (diff)
From: Eric Nelson <eric.nelson@boundarydevices.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: David Jander <david.jander@protonic.nl>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
DRI Development <dri-devel@lists.freedesktop.org>,
Ahmed Ammar <aammar@genesi-usa.com>,
kernel@pengutronix.de, Matt Sealey <matt@genesi-usa.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 4/6] staging: drm/imx: Add i.MX IPUv3 crtc support
Date: Sat, 22 Sep 2012 10:52:12 -0700 [thread overview]
Message-ID: <505DFACC.7010604@boundarydevices.com> (raw)
In-Reply-To: <20120922101727.GG1322@pengutronix.de>
On 09/22/2012 03:17 AM, Sascha Hauer wrote:
> Hi Eric,
>
> On Fri, Sep 21, 2012 at 09:24:19AM -0700, Eric Nelson wrote:
>> Hi Sascha,
>>
>>
>> But ipu_crtc->imx_crtc gets initialized in this call, and
>> ipu_irq_handler() makes use of it.
>>
>> The U-Boot code doesn't enable interrupts, so it's not acking
>> along the way, and leaves bits set in IPU1_INT_STAT_15.
>>
>> I found that I can get around this in U-Boot by disabling the
>> LCD controller and acking all of the interrupts after disabling
>> the controller, but I haven't yet figured out where to tap into
>> cleanup_before_linux().
>
> Passing over an enabled IPU from the bootloader to the kernel is
> (currently) not a supported usecase, so U-Boot should indeed disable it.
> That said, the kernel driver should make sure the IPU is sufficiently
> configured before the interrupts are enabled, so this seems to be a bug
> that deserves fixing.
>
Thanks Sascha,
Patches for U-Boot are in process.
http://lists.denx.de/pipermail/u-boot/2012-September/134807.html
Regards,
Eric
next prev parent reply other threads:[~2012-09-22 17:52 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-21 8:07 [PATCH] Add i.MX IPUv3 base/KMS driver to the staging tree Sascha Hauer
2012-09-21 8:07 ` Sascha Hauer
2012-09-21 8:07 ` [PATCH 1/6] staging: drm/imx: Add i.MX drm core support Sascha Hauer
2012-09-21 8:07 ` Sascha Hauer
2012-09-21 8:07 ` [PATCH 2/6] staging: drm/imx: Add parallel display support Sascha Hauer
2012-09-21 8:07 ` Sascha Hauer
2012-09-21 8:07 ` [PATCH 3/6] staging: drm/imx: add i.MX IPUv3 base driver Sascha Hauer
2012-09-21 8:07 ` Sascha Hauer
2012-09-21 8:07 ` [PATCH 4/6] staging: drm/imx: Add i.MX IPUv3 crtc support Sascha Hauer
2012-09-21 8:07 ` Sascha Hauer
2012-09-21 16:24 ` Eric Nelson
2012-09-21 16:24 ` Eric Nelson
2012-09-22 10:17 ` Sascha Hauer
2012-09-22 10:17 ` Sascha Hauer
2012-09-22 17:52 ` Eric Nelson [this message]
2012-09-22 17:52 ` Eric Nelson
2012-09-21 8:07 ` [PATCH 5/6] staging: drm/imx: Add devicetree binding documentation Sascha Hauer
2012-09-21 8:07 ` Sascha Hauer
2012-09-21 8:07 ` [PATCH 6/6] staging: drm/imx: Add TODO Sascha Hauer
2012-09-21 8:07 ` Sascha Hauer
2012-09-21 16:18 ` [PATCH] Add i.MX IPUv3 base/KMS driver to the staging tree Greg Kroah-Hartman
2012-09-21 16:18 ` Greg Kroah-Hartman
-- strict thread matches above, loose matches on Subject: below --
2012-09-12 10:31 Sascha Hauer
2012-09-12 10:31 ` [PATCH 4/6] staging: drm/imx: Add i.MX IPUv3 crtc support Sascha Hauer
2012-09-12 10:31 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=505DFACC.7010604@boundarydevices.com \
--to=eric.nelson@boundarydevices.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.