From: Alex Shi <alex.shi@intel.com>
To: Tomoki Sekiyama <tomoki.sekiyama.qu@hitachi.com>
Cc: x86@kernel.org, yrl.pp-manager.tt@hitachi.com,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] x86: Distinguish TLB shootdown interrupts from other functions call interrupts
Date: Mon, 24 Sep 2012 09:37:50 +0800 [thread overview]
Message-ID: <505FB96E.8050608@intel.com> (raw)
In-Reply-To: <20120920085033.14512.98190.stgit@hpxw>
On 09/20/2012 04:50 PM, Tomoki Sekiyama wrote:
> unsigned int irq_resched_count;
> unsigned int irq_call_count;
> + /* irq_tlb_count is double-counted in irq_call_count, so it must be
> + subtracted from irq_call_count when displaying irq_call_count */
> unsigned int irq_tlb_count;
Review again this patch, above comments is not kernel compatible format.
Could you change it like standard comment format:
/*
* xxxxxxx
* xxxx
*/
--
Thanks
Alex
next prev parent reply other threads:[~2012-09-24 1:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-19 9:04 [PATCH] x86: Distinguish TLB shootdown interrupts from other functions call interrupts Tomoki Sekiyama
2012-09-20 1:18 ` Alex Shi
2012-09-20 8:50 ` Tomoki Sekiyama
2012-09-21 8:08 ` Alex Shi
2012-09-24 1:37 ` Alex Shi [this message]
[not found] <50611D82.4010702@intel.com>
2012-09-26 2:11 ` Tomoki Sekiyama
2012-09-26 2:17 ` Alex Shi
2012-09-27 7:02 ` Alex Shi
2012-09-28 5:49 ` H. Peter Anvin
2012-09-28 6:08 ` Alex Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=505FB96E.8050608@intel.com \
--to=alex.shi@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=tomoki.sekiyama.qu@hitachi.com \
--cc=x86@kernel.org \
--cc=yrl.pp-manager.tt@hitachi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.