From: Jason Wessel <jason.wessel@windriver.com>
To: Anton Vorontsov <anton.vorontsov@linaro.org>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
"Russell King" <linux@arm.linux.org.uk>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Alan Cox" <alan@linux.intel.com>,
"Arve Hjønnevåg" <arve@android.com>,
"Colin Cross" <ccross@android.com>,
"Brian Swetland" <swetland@google.com>,
"John Stultz" <john.stultz@linaro.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linaro-kernel@lists.linaro.org, patches@linaro.org,
kernel-team@android.com, kgdb-bugreport@lists.sourceforge.net,
linux-serial@vger.kernel.org
Subject: Re: [PATCH v8 0/11] KGDB/KDB FIQ (NMI) debugger
Date: Mon, 24 Sep 2012 05:46:09 -0500 [thread overview]
Message-ID: <506039F1.2040108@windriver.com> (raw)
In-Reply-To: <505B1CC7.9000005@windriver.com>
On 09/20/2012 08:40 AM, Jason Wessel wrote:
> On 09/19/2012 06:40 PM, Anton Vorontsov wrote:
>> Hi all,
>>
>> In v8, addressed Jason's comments:
>>
>> - Changed kgdb_enable_nmi() weak function to kgdb_arch callbck;
>> - We no longer register disable_nmi command if arch does not register
>> KGDB NMI handling (i.e. not filling kgdb_arch.enable_nmi callback);
>> - The same is for ttyNMI: if architecure does not provide us with
>> enable_nmi call, we don't need the tty device. Of course, there is no
>> way to tell wether a specific serial device can be used for NMI
>> debugging, as it is not serial-device specific, but specific to
>> whether IRQ can be rerouted to an NMI (for most our cases, pretty
>> much every IRQ can be rerouted, e.g. a hot-pluggable serial device on
>> a PCI bus).
>> - Rebased on the latest and greatest tty-next, just in case.
>
> I have the kgdb regression builder running right now (it will be done in about 1 hour), and so far it picked up one new warning.
>
> drivers/tty/serial/kgdb_nmi.c: In function 'kgdb_nmi_poll_one_knock':
> drivers/tty/serial/kgdb_nmi.c:161: warning: field width should have type 'int', but argument 4 has type 'size_t'
>
Hi Anton,
You can add my ack to the series, for what you have in: "git://git.infradead.org/users/cbou/linux-nmi-kdb.git master", and then drop a pull request to Greg for the next merge window. Thank you for your hard work through all the revisions of this code and this slick new feature.
Acked-by: Jason Wessel <jason.wessel@windriver.com>
Cheers,
Jason.
WARNING: multiple messages have this Message-ID (diff)
From: jason.wessel@windriver.com (Jason Wessel)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v8 0/11] KGDB/KDB FIQ (NMI) debugger
Date: Mon, 24 Sep 2012 05:46:09 -0500 [thread overview]
Message-ID: <506039F1.2040108@windriver.com> (raw)
In-Reply-To: <505B1CC7.9000005@windriver.com>
On 09/20/2012 08:40 AM, Jason Wessel wrote:
> On 09/19/2012 06:40 PM, Anton Vorontsov wrote:
>> Hi all,
>>
>> In v8, addressed Jason's comments:
>>
>> - Changed kgdb_enable_nmi() weak function to kgdb_arch callbck;
>> - We no longer register disable_nmi command if arch does not register
>> KGDB NMI handling (i.e. not filling kgdb_arch.enable_nmi callback);
>> - The same is for ttyNMI: if architecure does not provide us with
>> enable_nmi call, we don't need the tty device. Of course, there is no
>> way to tell wether a specific serial device can be used for NMI
>> debugging, as it is not serial-device specific, but specific to
>> whether IRQ can be rerouted to an NMI (for most our cases, pretty
>> much every IRQ can be rerouted, e.g. a hot-pluggable serial device on
>> a PCI bus).
>> - Rebased on the latest and greatest tty-next, just in case.
>
> I have the kgdb regression builder running right now (it will be done in about 1 hour), and so far it picked up one new warning.
>
> drivers/tty/serial/kgdb_nmi.c: In function 'kgdb_nmi_poll_one_knock':
> drivers/tty/serial/kgdb_nmi.c:161: warning: field width should have type 'int', but argument 4 has type 'size_t'
>
Hi Anton,
You can add my ack to the series, for what you have in: "git://git.infradead.org/users/cbou/linux-nmi-kdb.git master", and then drop a pull request to Greg for the next merge window. Thank you for your hard work through all the revisions of this code and this slick new feature.
Acked-by: Jason Wessel <jason.wessel@windriver.com>
Cheers,
Jason.
next prev parent reply other threads:[~2012-09-24 10:46 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-19 23:40 [PATCH v8 0/11] KGDB/KDB FIQ (NMI) debugger Anton Vorontsov
2012-09-19 23:40 ` Anton Vorontsov
2012-09-19 23:41 ` [PATCH 01/11] kernel/debug: Mask KGDB NMI upon entry Anton Vorontsov
2012-09-19 23:41 ` Anton Vorontsov
2012-09-19 23:41 ` [PATCH 02/11] kdb: Implement disable_nmi command Anton Vorontsov
2012-09-19 23:41 ` Anton Vorontsov
2012-09-19 23:41 ` [PATCH 03/11] kdb: Turn KGDB_KDB=n stubs into static inlines Anton Vorontsov
2012-09-19 23:41 ` Anton Vorontsov
2012-09-19 23:41 ` [PATCH 04/11] tty/serial/core: Introduce poll_init callback Anton Vorontsov
2012-09-19 23:41 ` Anton Vorontsov
2012-09-19 23:41 ` [PATCH 05/11] tty/serial/amba-pl011: Implement " Anton Vorontsov
2012-09-19 23:41 ` Anton Vorontsov
2012-09-19 23:41 ` [PATCH 06/11] tty/serial/amba-pl011: Quiesce interrupts in poll_get_char Anton Vorontsov
2012-09-19 23:41 ` Anton Vorontsov
2012-09-19 23:41 ` [PATCH 07/11] tty/serial: Add kgdb_nmi driver Anton Vorontsov
2012-09-19 23:41 ` Anton Vorontsov
2012-09-19 23:41 ` Anton Vorontsov
2012-09-20 13:57 ` Jason Wessel
2012-09-20 13:57 ` Jason Wessel
2012-09-20 18:30 ` [PATCH updated " Anton Vorontsov
2012-09-20 18:30 ` Anton Vorontsov
2012-09-20 18:30 ` Anton Vorontsov
2012-09-19 23:41 ` [PATCH 08/11] ARM: Move some macros from entry-armv to entry-header Anton Vorontsov
2012-09-19 23:41 ` Anton Vorontsov
2012-09-19 23:42 ` [PATCH 09/11] ARM: Add KGDB/KDB FIQ debugger generic code Anton Vorontsov
2012-09-19 23:42 ` Anton Vorontsov
2012-09-19 23:42 ` Anton Vorontsov
2012-09-19 23:42 ` [PATCH 10/11] ARM: VIC: Add a couple of low-level FIQ management helpers Anton Vorontsov
2012-09-19 23:42 ` Anton Vorontsov
2012-09-19 23:42 ` [PATCH 11/11] ARM: versatile: Make able to use UART ports for KGDB FIQ debugger Anton Vorontsov
2012-09-19 23:42 ` Anton Vorontsov
2012-09-20 13:40 ` [PATCH v8 0/11] KGDB/KDB FIQ (NMI) debugger Jason Wessel
2012-09-20 13:40 ` Jason Wessel
2012-09-20 13:40 ` Jason Wessel
2012-09-24 10:46 ` Jason Wessel [this message]
2012-09-24 10:46 ` Jason Wessel
2012-09-24 21:25 ` Anton Vorontsov
2012-09-24 21:25 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=506039F1.2040108@windriver.com \
--to=jason.wessel@windriver.com \
--cc=akpm@linux-foundation.org \
--cc=alan@linux.intel.com \
--cc=anton.vorontsov@linaro.org \
--cc=arve@android.com \
--cc=ccross@android.com \
--cc=gregkh@linuxfoundation.org \
--cc=john.stultz@linaro.org \
--cc=kernel-team@android.com \
--cc=kgdb-bugreport@lists.sourceforge.net \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=patches@linaro.org \
--cc=swetland@google.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.