Re: [PATCH 2/3 V2] fc2580: silence uninitialized variable warning

[Antti Palosaari <crope@iki.fi>]

On 09/24/2012 03:51 PM, Gianluca Gennari wrote:
> fc2580.c: In function 'fc2580_set_params':
> fc2580.c:118: warning: 'ret' may be used uninitialized in this function
>
> V2: fixed coding style.
>
> Signed-off-by: Gianluca Gennari <gennarone@gmail.com>


Acked-by: Antti Palosaari <crope@iki.fi>
Reviewed-by: Antti Palosaari <crope@iki.fi>

> ---
>   drivers/media/tuners/fc2580.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/media/tuners/fc2580.c b/drivers/media/tuners/fc2580.c
> index 036e94b..3ad68e9 100644
> --- a/drivers/media/tuners/fc2580.c
> +++ b/drivers/media/tuners/fc2580.c
> @@ -115,7 +115,7 @@ static int fc2580_set_params(struct dvb_frontend *fe)
>   {
>   	struct fc2580_priv *priv = fe->tuner_priv;
>   	struct dtv_frontend_properties *c = &fe->dtv_property_cache;
> -	int ret, i;
> +	int ret = 0, i;
>   	unsigned int r_val, n_val, k_val, k_val_reg, f_ref;
>   	u8 tmp_val, r18_val;
>   	u64 f_vco;
>


-- 
http://palosaari.fi/