* [PATCH 2/3 V2] fc2580: silence uninitialized variable warning [not found] <GmailId139f821bcaa99b1e> @ 2012-09-24 12:51 ` Gianluca Gennari 2012-09-24 12:57 ` Antti Palosaari 0 siblings, 1 reply; 2+ messages in thread From: Gianluca Gennari @ 2012-09-24 12:51 UTC (permalink / raw) To: linux-media, crope; +Cc: mchehab, Gianluca Gennari fc2580.c: In function 'fc2580_set_params': fc2580.c:118: warning: 'ret' may be used uninitialized in this function V2: fixed coding style. Signed-off-by: Gianluca Gennari <gennarone@gmail.com> --- drivers/media/tuners/fc2580.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/tuners/fc2580.c b/drivers/media/tuners/fc2580.c index 036e94b..3ad68e9 100644 --- a/drivers/media/tuners/fc2580.c +++ b/drivers/media/tuners/fc2580.c @@ -115,7 +115,7 @@ static int fc2580_set_params(struct dvb_frontend *fe) { struct fc2580_priv *priv = fe->tuner_priv; struct dtv_frontend_properties *c = &fe->dtv_property_cache; - int ret, i; + int ret = 0, i; unsigned int r_val, n_val, k_val, k_val_reg, f_ref; u8 tmp_val, r18_val; u64 f_vco; -- 1.7.0.4 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 2/3 V2] fc2580: silence uninitialized variable warning 2012-09-24 12:51 ` [PATCH 2/3 V2] fc2580: silence uninitialized variable warning Gianluca Gennari @ 2012-09-24 12:57 ` Antti Palosaari 0 siblings, 0 replies; 2+ messages in thread From: Antti Palosaari @ 2012-09-24 12:57 UTC (permalink / raw) To: Gianluca Gennari; +Cc: linux-media, mchehab On 09/24/2012 03:51 PM, Gianluca Gennari wrote: > fc2580.c: In function 'fc2580_set_params': > fc2580.c:118: warning: 'ret' may be used uninitialized in this function > > V2: fixed coding style. > > Signed-off-by: Gianluca Gennari <gennarone@gmail.com> Acked-by: Antti Palosaari <crope@iki.fi> Reviewed-by: Antti Palosaari <crope@iki.fi> > --- > drivers/media/tuners/fc2580.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/media/tuners/fc2580.c b/drivers/media/tuners/fc2580.c > index 036e94b..3ad68e9 100644 > --- a/drivers/media/tuners/fc2580.c > +++ b/drivers/media/tuners/fc2580.c > @@ -115,7 +115,7 @@ static int fc2580_set_params(struct dvb_frontend *fe) > { > struct fc2580_priv *priv = fe->tuner_priv; > struct dtv_frontend_properties *c = &fe->dtv_property_cache; > - int ret, i; > + int ret = 0, i; > unsigned int r_val, n_val, k_val, k_val_reg, f_ref; > u8 tmp_val, r18_val; > u64 f_vco; > -- http://palosaari.fi/ ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-09-24 12:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <GmailId139f821bcaa99b1e>
2012-09-24 12:51 ` [PATCH 2/3 V2] fc2580: silence uninitialized variable warning Gianluca Gennari
2012-09-24 12:57 ` Antti Palosaari
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.