From: Don Dutile <ddutile@redhat.com>
To: Yuval Mintz <yuvalmin@broadcom.com>
Cc: Yinghai Lu <yinghai@kernel.org>,
"Rose, Gregory V" <gregory.v.rose@intel.com>,
Ben Hutchings <bhutchings@solarflare.com>,
Bjorn Helgaas <bhelgaas@google.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Ariel Elior <ariele@broadcom.com>,
Eilon Greenstein <eilong@broadcom.com>,
linux-pci <linux-pci@vger.kernel.org>
Subject: Re: New commands to configure IOV features
Date: Mon, 24 Sep 2012 13:37:34 -0400 [thread overview]
Message-ID: <50609A5E.7020104@redhat.com> (raw)
In-Reply-To: <505F2F99.9090302@broadcom.com>
On 09/23/2012 11:49 AM, Yuval Mintz wrote:
>>>> It provides 3 sysfs files (enable, disable, num_max_vfs);
>>>> callbacks for enable& disable.
>>>
>>> why using three? only pass max_vfs should be enough...
>>>
>>> aka pass 0 mean disabling, pass other value mean enabling.
>>>
>> could do that. but I wouldn't use 'max_vfs'; I would recommend
>> 'num_vfs', as max implies, er, um, the maximum, and what one
>> wants is to be able to enable a number from 1->max_vfs.
>> 'max_vfs' will be provided by another file.
>>
>
> If we're at it, how do you suggest the configurations of the VFs
> resources/properties should be made?
> Notice I'm asking about properties which relate to all PCI devices,
> E.g., number of interrupts assigned to each VF (for VF RSS).
>
This issue/question is indep of VFs & SRIOV.
It's a generic problem for PFs and how many (msi) intr's a device
is given, based on its request, i.e., system provides 8 MSI per cpu
per device ... how are those 8 assigned/used by the device? ...
how to free 4 of the 8 if one device doesn't use them, and another
device could use them.. cache/memory affinity to intr's.... the list
goes on...
> (For properties which relate only to networking devices, we could
> use standard network API such as netlink).
>
> Perhaps given a configurable property that applies to all PCI devices,
A VF is 'just another PCI device', so configurable properties
for all PCI devices should encompass VF/SRIOV devices equally.
> once SRIOV is enabled and the VFs are created, there would be an
> additional sysfs node under the VFs through which the user could
> configure that property.
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Don Dutile <ddutile@redhat.com>
To: Yuval Mintz <yuvalmin@broadcom.com>
Cc: Yinghai Lu <yinghai@kernel.org>,
"Rose, Gregory V" <gregory.v.rose@intel.com>,
Ben Hutchings <bhutchings@solarflare.com>,
Bjorn Helgaas <bhelgaas@google.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Ariel Elior <ariele@broadcom.com>,
Eilon Greenstein <eilong@broadcom.com>,
linux-pci <linux-pci@vger.kernel.org>
Subject: Re: New commands to configure IOV features
Date: Mon, 24 Sep 2012 13:37:34 -0400 [thread overview]
Message-ID: <50609A5E.7020104@redhat.com> (raw)
In-Reply-To: <505F2F99.9090302@broadcom.com>
On 09/23/2012 11:49 AM, Yuval Mintz wrote:
>>>> It provides 3 sysfs files (enable, disable, num_max_vfs);
>>>> callbacks for enable& disable.
>>>
>>> why using three? only pass max_vfs should be enough...
>>>
>>> aka pass 0 mean disabling, pass other value mean enabling.
>>>
>> could do that. but I wouldn't use 'max_vfs'; I would recommend
>> 'num_vfs', as max implies, er, um, the maximum, and what one
>> wants is to be able to enable a number from 1->max_vfs.
>> 'max_vfs' will be provided by another file.
>>
>
> If we're at it, how do you suggest the configurations of the VFs
> resources/properties should be made?
> Notice I'm asking about properties which relate to all PCI devices,
> E.g., number of interrupts assigned to each VF (for VF RSS).
>
This issue/question is indep of VFs & SRIOV.
It's a generic problem for PFs and how many (msi) intr's a device
is given, based on its request, i.e., system provides 8 MSI per cpu
per device ... how are those 8 assigned/used by the device? ...
how to free 4 of the 8 if one device doesn't use them, and another
device could use them.. cache/memory affinity to intr's.... the list
goes on...
> (For properties which relate only to networking devices, we could
> use standard network API such as netlink).
>
> Perhaps given a configurable property that applies to all PCI devices,
A VF is 'just another PCI device', so configurable properties
for all PCI devices should encompass VF/SRIOV devices equally.
> once SRIOV is enabled and the VFs are created, there would be an
> additional sysfs node under the VFs through which the user could
> configure that property.
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-09-24 17:37 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-07 11:17 New commands to configure IOV features Yuval Mintz
2012-05-07 15:16 ` Greg Rose
2012-06-26 12:21 ` Yuval Mintz
2012-06-26 16:13 ` Alexander Duyck
2012-06-26 17:19 ` Greg Rose
2012-07-01 11:09 ` Yuval Mintz
2012-07-09 18:39 ` Ben Hutchings
2012-07-09 21:13 ` Chris Friesen
2012-07-16 9:19 ` Yuval Mintz
2012-07-17 19:29 ` Don Dutile
2012-07-17 21:08 ` Chris Friesen
2012-07-17 21:11 ` David Miller
2012-07-20 15:27 ` Chris Friesen
2012-07-20 15:56 ` Don Dutile
2012-07-20 17:42 ` Ben Hutchings
2012-07-20 19:29 ` Chris Friesen
2012-07-20 20:01 ` Ben Hutchings
2012-07-20 20:15 ` Don Dutile
2012-07-20 23:42 ` Chris Friesen
2012-07-21 0:52 ` Rose, Gregory V
2012-07-23 14:03 ` Don Dutile
2012-07-23 15:09 ` Chris Friesen
2012-07-23 17:06 ` Rose, Gregory V
2012-07-23 18:36 ` Stephen Hemminger
2012-07-23 18:40 ` Rose, Gregory V
2012-09-19 11:07 ` Yuval Mintz
2012-09-19 15:53 ` Greg Rose
2012-09-19 19:44 ` Ben Hutchings
2012-09-19 22:17 ` Yinghai Lu
2012-09-19 22:46 ` Ben Hutchings
2012-09-20 0:19 ` Yinghai Lu
2012-09-20 1:23 ` Ben Hutchings
2012-09-20 2:27 ` Yinghai Lu
2012-09-20 3:08 ` Subhendu Ghosh
2012-09-20 15:39 ` Rose, Gregory V
2012-09-20 15:39 ` Rose, Gregory V
2012-09-21 5:50 ` Yinghai Lu
2012-09-21 17:35 ` Ben Hutchings
2012-09-21 19:23 ` Yinghai Lu
2012-09-21 18:06 ` Don Dutile
2012-09-21 18:06 ` Don Dutile
2012-09-21 19:49 ` Yinghai Lu
2012-09-21 20:08 ` Don Dutile
2012-09-21 20:08 ` Don Dutile
2012-09-23 15:49 ` Yuval Mintz
2012-09-24 17:37 ` Don Dutile [this message]
2012-09-24 17:37 ` Don Dutile
2012-09-30 6:39 ` Yuval Mintz
2012-10-01 14:12 ` Don Dutile
2012-10-01 14:12 ` Don Dutile
2012-09-19 17:49 ` David Miller
2012-07-23 16:37 ` Rose, Gregory V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50609A5E.7020104@redhat.com \
--to=ddutile@redhat.com \
--cc=ariele@broadcom.com \
--cc=bhelgaas@google.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=eilong@broadcom.com \
--cc=gregory.v.rose@intel.com \
--cc=linux-pci@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yinghai@kernel.org \
--cc=yuvalmin@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.