[PATCH 1/2] libx11.inc: disable warnings that don't work on certain compilers

All of lore.kernel.org
 help / color / mirror / Atom feed

* [PATCH 1/2] libx11.inc: disable warnings that don't work on certain compilers
@ 2012-09-24 19:55 Matthew McClintock
  2012-09-24 19:55 ` [PATCH 2/2] libx11: fix nativesdk build on older distros Matthew McClintock
  2012-09-24 20:00 ` [PATCH 1/2] libx11.inc: disable warnings that don't work on certain compilers Martin Jansa
  0 siblings, 2 replies; 21+ messages in thread
From: Matthew McClintock @ 2012-09-24 19:55 UTC (permalink / raw)
  To: openembedded-core

Fixes these sorts of issues present on older gcc (CentOS 5.x in this case)

| cc1: error: unrecognized command line option "-Werror=implicit"
| cc1: error: unrecognized command line option "-Werror=nonnull"
| cc1: error: unrecognized command line option "-Werror=init-self"
| cc1: error: unrecognized command line option "-Werror=main"
| cc1: error: unrecognized command line option "-Werror=missing-braces"
| cc1: error: unrecognized command line option "-Werror=sequence-point"
| cc1: error: unrecognized command line option "-Werror=return-type"
| cc1: error: unrecognized command line option "-Werror=trigraphs"
| cc1: error: unrecognized command line option "-Werror=array-bounds"
| cc1: error: unrecognized command line option "-Werror=write-strings"
| cc1: error: unrecognized command line option "-Werror=address"
| cc1: error: unrecognized command line option "-Werror=int-to-pointer-cast"
| cc1: error: unrecognized command line option "-Werror=pointer-to-int-cast"

Signed-off-by: Matthew McClintock <msm@freescale.com>
---
 meta/recipes-graphics/xorg-lib/libx11.inc |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/meta/recipes-graphics/xorg-lib/libx11.inc b/meta/recipes-graphics/xorg-lib/libx11.inc
index 3ecd9e5..0e99442 100644
--- a/meta/recipes-graphics/xorg-lib/libx11.inc
+++ b/meta/recipes-graphics/xorg-lib/libx11.inc
@@ -11,7 +11,7 @@ inherit siteinfo
 FILESPATH = "${FILE_DIRNAME}/libx11"
 
 PE = "1"
-INC_PR = "r8"
+INC_PR = "r9"
 
 PROVIDES = "virtual/libx11"
 
@@ -23,6 +23,7 @@ DEPENDS += "xproto xextproto xtrans libxcb kbproto inputproto"
 DEPENDS += "xproto-native"
 
 EXTRA_OECONF += "--with-keysymdefdir=${STAGING_INCDIR}/X11/"
+EXTRA_OEMAKE = '-e CWARNFLAGS=""'
 
 # Let people with incredibly archaic requirements enable Xcms and BigFont, but
 # disable them by default.
-- 
1.7.9.7





^ permalink raw reply related	[flat|nested] 21+ messages in thread

* [PATCH 2/2] libx11: fix nativesdk build on older distros
  2012-09-24 19:55 [PATCH 1/2] libx11.inc: disable warnings that don't work on certain compilers Matthew McClintock
@ 2012-09-24 19:55 ` Matthew McClintock
  2012-09-24 20:13   ` McClintock Matthew-B29882
                     ` (2 more replies)
  2012-09-24 20:00 ` [PATCH 1/2] libx11.inc: disable warnings that don't work on certain compilers Martin Jansa
  1 sibling, 3 replies; 21+ messages in thread
From: Matthew McClintock @ 2012-09-24 19:55 UTC (permalink / raw)
  To: openembedded-core

makekeys-makekeys.o: In function `main':
makekeys.c:(.text+0x85): undefined reference to `__isoc99_sscanf'
makekeys.c:(.text+0xa7): undefined reference to `__isoc99_sscanf'
collect2: ld returned 1 exit status
make: *** [makekeys] Error 1

Older libc do not have this defined, we can use the -D_GNU_SOURCE
to the compiler to prevent generating calls to this function and
make linking work

Signed-off-by: Matthew McClintock <msm@freescale.com>
---
 .../xorg-lib/libx11/use_host_cc_for_utils.patch    |   12 ++++++++++++
 meta/recipes-graphics/xorg-lib/libx11_1.5.0.bb     |    3 ++-
 2 files changed, 14 insertions(+), 1 deletion(-)
 create mode 100644 meta/recipes-graphics/xorg-lib/libx11/use_host_cc_for_utils.patch

diff --git a/meta/recipes-graphics/xorg-lib/libx11/use_host_cc_for_utils.patch b/meta/recipes-graphics/xorg-lib/libx11/use_host_cc_for_utils.patch
new file mode 100644
index 0000000..08ba39a
--- /dev/null
+++ b/meta/recipes-graphics/xorg-lib/libx11/use_host_cc_for_utils.patch
@@ -0,0 +1,12 @@
+Index: libX11-1.5.0/src/Makefile.am
+===================================================================
+--- libX11-1.5.0.orig/src/Makefile.am
++++ libX11-1.5.0/src/Makefile.am
+@@ -420,6 +420,6 @@ ks_tables.h: $(KEYSYMDEFS) $(top_builddi
+ 	mv ks_tables_h $@
+ 
+ $(top_builddir)/src/util/makekeys$(EXEEXT): force
+-	cd util && $(MAKE)
++	cd util && $(MAKE) CC=gcc CCLD=gcc LDFLAGS= CFLAGS=-D_GNU_SOURCE
+ 
+ force:
diff --git a/meta/recipes-graphics/xorg-lib/libx11_1.5.0.bb b/meta/recipes-graphics/xorg-lib/libx11_1.5.0.bb
index 94e2051..3e00dd8 100644
--- a/meta/recipes-graphics/xorg-lib/libx11_1.5.0.bb
+++ b/meta/recipes-graphics/xorg-lib/libx11_1.5.0.bb
@@ -1,11 +1,12 @@
 require libx11.inc
 inherit gettext
 
-PR = "${INC_PR}.2"
+PR = "${INC_PR}.3"
 
 BBCLASSEXTEND = "native nativesdk"
 
 SRC_URI += "file://keysymdef_include.patch"
+SRC_URI_append_virtclass-nativesdk += "file://use_host_cc_for_utils.patch"
 
 SRC_URI[md5sum] = "78b4b3bab4acbdf0abcfca30a8c70cc6"
 SRC_URI[sha256sum] = "c382efd7e92bfc3cef39a4b7f1ecf2744ba4414a705e3bc1e697f75502bd4d86"
-- 
1.7.9.7





^ permalink raw reply related	[flat|nested] 21+ messages in thread

* Re: [PATCH 2/2] libx11: fix nativesdk build on older distros
  2012-09-24 19:55 ` [PATCH 2/2] libx11: fix nativesdk build on older distros Matthew McClintock
@ 2012-09-24 20:13   ` McClintock Matthew-B29882
  2012-09-24 21:08     ` Chris Larson
  2012-09-24 21:52   ` Saul Wold
       [not found]   ` <CAJTo0LYe6LuFQJS_36PYVsjwnp=N9J-XuiFVMntBi76qt+i4aw@mail.gmail.com>
  2 siblings, 1 reply; 21+ messages in thread
From: McClintock Matthew-B29882 @ 2012-09-24 20:13 UTC (permalink / raw)
  To: openembedded-core@lists.openembedded.org

On Mon, Sep 24, 2012 at 2:55 PM, Matthew McClintock <msm@freescale.com> wrote:
> makekeys-makekeys.o: In function `main':
> makekeys.c:(.text+0x85): undefined reference to `__isoc99_sscanf'
> makekeys.c:(.text+0xa7): undefined reference to `__isoc99_sscanf'
> collect2: ld returned 1 exit status
> make: *** [makekeys] Error 1
>
> Older libc do not have this defined, we can use the -D_GNU_SOURCE
> to the compiler to prevent generating calls to this function and
> make linking work
>
> Signed-off-by: Matthew McClintock <msm@freescale.com>
> ---
>  .../xorg-lib/libx11/use_host_cc_for_utils.patch    |   12 ++++++++++++
>  meta/recipes-graphics/xorg-lib/libx11_1.5.0.bb     |    3 ++-
>  2 files changed, 14 insertions(+), 1 deletion(-)
>  create mode 100644 meta/recipes-graphics/xorg-lib/libx11/use_host_cc_for_utils.patch
>
> diff --git a/meta/recipes-graphics/xorg-lib/libx11/use_host_cc_for_utils.patch b/meta/recipes-graphics/xorg-lib/libx11/use_host_cc_for_utils.patch
> new file mode 100644
> index 0000000..08ba39a
> --- /dev/null
> +++ b/meta/recipes-graphics/xorg-lib/libx11/use_host_cc_for_utils.patch
> @@ -0,0 +1,12 @@
> +Index: libX11-1.5.0/src/Makefile.am
> +===================================================================
> +--- libX11-1.5.0.orig/src/Makefile.am
> ++++ libX11-1.5.0/src/Makefile.am
> +@@ -420,6 +420,6 @@ ks_tables.h: $(KEYSYMDEFS) $(top_builddi
> +       mv ks_tables_h $@
> +
> + $(top_builddir)/src/util/makekeys$(EXEEXT): force
> +-      cd util && $(MAKE)
> ++      cd util && $(MAKE) CC=gcc CCLD=gcc LDFLAGS= CFLAGS=-D_GNU_SOURCE

I kicked off a build right after testing on one machine, and this is
not quite right. Mostly I think I Need more CFLAGS to build 32 or 64
bit native binaries so they can run on the target system properly.
E.g. if I don't have:

/lib/ld.so.1: No such file or directory

-M

> +
> + force:
> diff --git a/meta/recipes-graphics/xorg-lib/libx11_1.5.0.bb b/meta/recipes-graphics/xorg-lib/libx11_1.5.0.bb
> index 94e2051..3e00dd8 100644
> --- a/meta/recipes-graphics/xorg-lib/libx11_1.5.0.bb
> +++ b/meta/recipes-graphics/xorg-lib/libx11_1.5.0.bb
> @@ -1,11 +1,12 @@
>  require libx11.inc
>  inherit gettext
>
> -PR = "${INC_PR}.2"
> +PR = "${INC_PR}.3"
>
>  BBCLASSEXTEND = "native nativesdk"
>
>  SRC_URI += "file://keysymdef_include.patch"
> +SRC_URI_append_virtclass-nativesdk += "file://use_host_cc_for_utils.patch"
>
>  SRC_URI[md5sum] = "78b4b3bab4acbdf0abcfca30a8c70cc6"
>  SRC_URI[sha256sum] = "c382efd7e92bfc3cef39a4b7f1ecf2744ba4414a705e3bc1e697f75502bd4d86"
> --
> 1.7.9.7
>
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core



^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [PATCH 2/2] libx11: fix nativesdk build on older distros
  2012-09-24 20:13   ` McClintock Matthew-B29882
@ 2012-09-24 21:08     ` Chris Larson
  2012-09-24 22:28       ` McClintock Matthew-B29882
  0 siblings, 1 reply; 21+ messages in thread
From: Chris Larson @ 2012-09-24 21:08 UTC (permalink / raw)
  To: McClintock Matthew-B29882; +Cc: openembedded-core@lists.openembedded.org

On Mon, Sep 24, 2012 at 1:13 PM, McClintock Matthew-B29882
<B29882@freescale.com> wrote:
> On Mon, Sep 24, 2012 at 2:55 PM, Matthew McClintock <msm@freescale.com> wrote:
>> makekeys-makekeys.o: In function `main':
>> makekeys.c:(.text+0x85): undefined reference to `__isoc99_sscanf'
>> makekeys.c:(.text+0xa7): undefined reference to `__isoc99_sscanf'
>> collect2: ld returned 1 exit status
>> make: *** [makekeys] Error 1
>>
>> Older libc do not have this defined, we can use the -D_GNU_SOURCE
>> to the compiler to prevent generating calls to this function and
>> make linking work
>>
>> Signed-off-by: Matthew McClintock <msm@freescale.com>
>> ---
>>  .../xorg-lib/libx11/use_host_cc_for_utils.patch    |   12 ++++++++++++
>>  meta/recipes-graphics/xorg-lib/libx11_1.5.0.bb     |    3 ++-
>>  2 files changed, 14 insertions(+), 1 deletion(-)
>>  create mode 100644 meta/recipes-graphics/xorg-lib/libx11/use_host_cc_for_utils.patch
>>
>> diff --git a/meta/recipes-graphics/xorg-lib/libx11/use_host_cc_for_utils.patch b/meta/recipes-graphics/xorg-lib/libx11/use_host_cc_for_utils.patch
>> new file mode 100644
>> index 0000000..08ba39a
>> --- /dev/null
>> +++ b/meta/recipes-graphics/xorg-lib/libx11/use_host_cc_for_utils.patch
>> @@ -0,0 +1,12 @@
>> +Index: libX11-1.5.0/src/Makefile.am
>> +===================================================================
>> +--- libX11-1.5.0.orig/src/Makefile.am
>> ++++ libX11-1.5.0/src/Makefile.am
>> +@@ -420,6 +420,6 @@ ks_tables.h: $(KEYSYMDEFS) $(top_builddi
>> +       mv ks_tables_h $@
>> +
>> + $(top_builddir)/src/util/makekeys$(EXEEXT): force
>> +-      cd util && $(MAKE)
>> ++      cd util && $(MAKE) CC=gcc CCLD=gcc LDFLAGS= CFLAGS=-D_GNU_SOURCE

Isn't the makekeys build already using CC_FOR_BUILD? That's what is
implied by the libx11.inc export of those variables. So it seems a bit
unnecessary to pass in gcc expliciltly.
-- 
Christopher Larson



^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [PATCH 2/2] libx11: fix nativesdk build on older distros
  2012-09-24 21:08     ` Chris Larson
@ 2012-09-24 22:28       ` McClintock Matthew-B29882
  0 siblings, 0 replies; 21+ messages in thread
From: McClintock Matthew-B29882 @ 2012-09-24 22:28 UTC (permalink / raw)
  To: Chris Larson
  Cc: McClintock Matthew-B29882,
	openembedded-core@lists.openembedded.org

On Mon, Sep 24, 2012 at 4:08 PM, Chris Larson <clarson@kergoth.com> wrote:
> On Mon, Sep 24, 2012 at 1:13 PM, McClintock Matthew-B29882
> <B29882@freescale.com> wrote:
>> On Mon, Sep 24, 2012 at 2:55 PM, Matthew McClintock <msm@freescale.com> wrote:
>>> makekeys-makekeys.o: In function `main':
>>> makekeys.c:(.text+0x85): undefined reference to `__isoc99_sscanf'
>>> makekeys.c:(.text+0xa7): undefined reference to `__isoc99_sscanf'
>>> collect2: ld returned 1 exit status
>>> make: *** [makekeys] Error 1
>>>
>>> Older libc do not have this defined, we can use the -D_GNU_SOURCE
>>> to the compiler to prevent generating calls to this function and
>>> make linking work
>>>
>>> Signed-off-by: Matthew McClintock <msm@freescale.com>
>>> ---
>>>  .../xorg-lib/libx11/use_host_cc_for_utils.patch    |   12 ++++++++++++
>>>  meta/recipes-graphics/xorg-lib/libx11_1.5.0.bb     |    3 ++-
>>>  2 files changed, 14 insertions(+), 1 deletion(-)
>>>  create mode 100644 meta/recipes-graphics/xorg-lib/libx11/use_host_cc_for_utils.patch
>>>
>>> diff --git a/meta/recipes-graphics/xorg-lib/libx11/use_host_cc_for_utils.patch b/meta/recipes-graphics/xorg-lib/libx11/use_host_cc_for_utils.patch
>>> new file mode 100644
>>> index 0000000..08ba39a
>>> --- /dev/null
>>> +++ b/meta/recipes-graphics/xorg-lib/libx11/use_host_cc_for_utils.patch
>>> @@ -0,0 +1,12 @@
>>> +Index: libX11-1.5.0/src/Makefile.am
>>> +===================================================================
>>> +--- libX11-1.5.0.orig/src/Makefile.am
>>> ++++ libX11-1.5.0/src/Makefile.am
>>> +@@ -420,6 +420,6 @@ ks_tables.h: $(KEYSYMDEFS) $(top_builddi
>>> +       mv ks_tables_h $@
>>> +
>>> + $(top_builddir)/src/util/makekeys$(EXEEXT): force
>>> +-      cd util && $(MAKE)
>>> ++      cd util && $(MAKE) CC=gcc CCLD=gcc LDFLAGS= CFLAGS=-D_GNU_SOURCE
>
> Isn't the makekeys build already using CC_FOR_BUILD? That's what is
> implied by the libx11.inc export of those variables. So it seems a bit
> unnecessary to pass in gcc expliciltly.

I think this is probably what I was looking for... will try to respin.

-M

> --
> Christopher Larson
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core



^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [PATCH 2/2] libx11: fix nativesdk build on older distros
  2012-09-24 19:55 ` [PATCH 2/2] libx11: fix nativesdk build on older distros Matthew McClintock
  2012-09-24 20:13   ` McClintock Matthew-B29882
@ 2012-09-24 21:52   ` Saul Wold
  2012-09-24 22:28     ` McClintock Matthew-B29882
       [not found]   ` <CAJTo0LYe6LuFQJS_36PYVsjwnp=N9J-XuiFVMntBi76qt+i4aw@mail.gmail.com>
  2 siblings, 1 reply; 21+ messages in thread
From: Saul Wold @ 2012-09-24 21:52 UTC (permalink / raw)
  To: Matthew McClintock; +Cc: openembedded-core

On 09/24/2012 12:55 PM, Matthew McClintock wrote:
> makekeys-makekeys.o: In function `main':
> makekeys.c:(.text+0x85): undefined reference to `__isoc99_sscanf'
> makekeys.c:(.text+0xa7): undefined reference to `__isoc99_sscanf'
> collect2: ld returned 1 exit status
> make: *** [makekeys] Error 1
>
> Older libc do not have this defined, we can use the -D_GNU_SOURCE
> to the compiler to prevent generating calls to this function and
> make linking work
>
> Signed-off-by: Matthew McClintock <msm@freescale.com>
> ---
>   .../xorg-lib/libx11/use_host_cc_for_utils.patch    |   12 ++++++++++++
>   meta/recipes-graphics/xorg-lib/libx11_1.5.0.bb     |    3 ++-
>   2 files changed, 14 insertions(+), 1 deletion(-)
>   create mode 100644 meta/recipes-graphics/xorg-lib/libx11/use_host_cc_for_utils.patch
>
> diff --git a/meta/recipes-graphics/xorg-lib/libx11/use_host_cc_for_utils.patch b/meta/recipes-graphics/xorg-lib/libx11/use_host_cc_for_utils.patch
> new file mode 100644
> index 0000000..08ba39a
> --- /dev/null
> +++ b/meta/recipes-graphics/xorg-lib/libx11/use_host_cc_for_utils.patch

This patch needs a header!


> @@ -0,0 +1,12 @@
> +Index: libX11-1.5.0/src/Makefile.am
> +===================================================================
> +--- libX11-1.5.0.orig/src/Makefile.am
> ++++ libX11-1.5.0/src/Makefile.am
> +@@ -420,6 +420,6 @@ ks_tables.h: $(KEYSYMDEFS) $(top_builddi
> + 	mv ks_tables_h $@
> +
> + $(top_builddir)/src/util/makekeys$(EXEEXT): force
> +-	cd util && $(MAKE)
> ++	cd util && $(MAKE) CC=gcc CCLD=gcc LDFLAGS= CFLAGS=-D_GNU_SOURCE

Is hardcoding 'gcc' here really the right thing to do?
> +
> + force:
> diff --git a/meta/recipes-graphics/xorg-lib/libx11_1.5.0.bb b/meta/recipes-graphics/xorg-lib/libx11_1.5.0.bb
> index 94e2051..3e00dd8 100644
> --- a/meta/recipes-graphics/xorg-lib/libx11_1.5.0.bb
> +++ b/meta/recipes-graphics/xorg-lib/libx11_1.5.0.bb
> @@ -1,11 +1,12 @@
>   require libx11.inc
>   inherit gettext
>
> -PR = "${INC_PR}.2"
> +PR = "${INC_PR}.3"
>
>   BBCLASSEXTEND = "native nativesdk"
>
>   SRC_URI += "file://keysymdef_include.patch"
> +SRC_URI_append_virtclass-nativesdk += "file://use_host_cc_for_utils.patch"
>
>   SRC_URI[md5sum] = "78b4b3bab4acbdf0abcfca30a8c70cc6"
>   SRC_URI[sha256sum] = "c382efd7e92bfc3cef39a4b7f1ecf2744ba4414a705e3bc1e697f75502bd4d86"
>



^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [PATCH 2/2] libx11: fix nativesdk build on older distros
  2012-09-24 21:52   ` Saul Wold
@ 2012-09-24 22:28     ` McClintock Matthew-B29882
  0 siblings, 0 replies; 21+ messages in thread
From: McClintock Matthew-B29882 @ 2012-09-24 22:28 UTC (permalink / raw)
  To: Saul Wold; +Cc: openembedded-core@lists.openembedded.org

On Mon, Sep 24, 2012 at 4:52 PM, Saul Wold <sgw@linux.intel.com> wrote:
> On 09/24/2012 12:55 PM, Matthew McClintock wrote:
>>
>> makekeys-makekeys.o: In function `main':
>> makekeys.c:(.text+0x85): undefined reference to `__isoc99_sscanf'
>> makekeys.c:(.text+0xa7): undefined reference to `__isoc99_sscanf'
>> collect2: ld returned 1 exit status
>> make: *** [makekeys] Error 1
>>
>> Older libc do not have this defined, we can use the -D_GNU_SOURCE
>> to the compiler to prevent generating calls to this function and
>> make linking work
>>
>> Signed-off-by: Matthew McClintock <msm@freescale.com>
>> ---
>>   .../xorg-lib/libx11/use_host_cc_for_utils.patch    |   12 ++++++++++++
>>   meta/recipes-graphics/xorg-lib/libx11_1.5.0.bb     |    3 ++-
>>   2 files changed, 14 insertions(+), 1 deletion(-)
>>   create mode 100644
>> meta/recipes-graphics/xorg-lib/libx11/use_host_cc_for_utils.patch
>>
>> diff --git
>> a/meta/recipes-graphics/xorg-lib/libx11/use_host_cc_for_utils.patch
>> b/meta/recipes-graphics/xorg-lib/libx11/use_host_cc_for_utils.patch
>> new file mode 100644
>> index 0000000..08ba39a
>> --- /dev/null
>> +++ b/meta/recipes-graphics/xorg-lib/libx11/use_host_cc_for_utils.patch
>
>
> This patch needs a header!

Yes!

>
>
>
>> @@ -0,0 +1,12 @@
>> +Index: libX11-1.5.0/src/Makefile.am
>> +===================================================================
>> +--- libX11-1.5.0.orig/src/Makefile.am
>> ++++ libX11-1.5.0/src/Makefile.am
>> +@@ -420,6 +420,6 @@ ks_tables.h: $(KEYSYMDEFS) $(top_builddi
>> +       mv ks_tables_h $@
>> +
>> + $(top_builddir)/src/util/makekeys$(EXEEXT): force
>> +-      cd util && $(MAKE)
>> ++      cd util && $(MAKE) CC=gcc CCLD=gcc LDFLAGS= CFLAGS=-D_GNU_SOURCE
>
>
> Is hardcoding 'gcc' here really the right thing to do?

Probably not, Chris has made some other suggestions so I will look at
a better v2.

-M

>
>> +
>> + force:
>> diff --git a/meta/recipes-graphics/xorg-lib/libx11_1.5.0.bb
>> b/meta/recipes-graphics/xorg-lib/libx11_1.5.0.bb
>> index 94e2051..3e00dd8 100644
>> --- a/meta/recipes-graphics/xorg-lib/libx11_1.5.0.bb
>> +++ b/meta/recipes-graphics/xorg-lib/libx11_1.5.0.bb
>> @@ -1,11 +1,12 @@
>>   require libx11.inc
>>   inherit gettext
>>
>> -PR = "${INC_PR}.2"
>> +PR = "${INC_PR}.3"
>>
>>   BBCLASSEXTEND = "native nativesdk"
>>
>>   SRC_URI += "file://keysymdef_include.patch"
>> +SRC_URI_append_virtclass-nativesdk +=
>> "file://use_host_cc_for_utils.patch"
>>
>>   SRC_URI[md5sum] = "78b4b3bab4acbdf0abcfca30a8c70cc6"
>>   SRC_URI[sha256sum] =
>> "c382efd7e92bfc3cef39a4b7f1ecf2744ba4414a705e3bc1e697f75502bd4d86"
>>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core



^ permalink raw reply	[flat|nested] 21+ messages in thread

[parent not found: <CAJTo0LYe6LuFQJS_36PYVsjwnp=N9J-XuiFVMntBi76qt+i4aw@mail.gmail.com>]

[parent not found: <70CC66F5C30A414DADDA6973E4CA391A6A6CE2@039-SN1MPN1-001.039d.mgd.msft.net>]

* Re: [PATCH 2/2] libx11: fix nativesdk build on older distros
       [not found]     ` <70CC66F5C30A414DADDA6973E4CA391A6A6CE2@039-SN1MPN1-001.039d.mgd.msft.net>
@ 2012-09-25 16:48       ` Burton, Ross
  2012-09-25 17:38         ` McClintock Matthew-B29882
       [not found]         ` <CAEsOVNfCLUhhpM91OBLC_paOXzsoS6PMeVXdp2xSnajqGuBcyg@mail.gmail.com>
  0 siblings, 2 replies; 21+ messages in thread
From: Burton, Ross @ 2012-09-25 16:48 UTC (permalink / raw)
  To: McClintock Matthew-B29882, OE-core

Whoops, I dropped oe-core.

On 25 September 2012 16:38, McClintock Matthew-B29882
<B29882@freescale.com> wrote:
>>> Older libc do not have this defined, we can use the -D_GNU_SOURCE
>>> to the compiler to prevent generating calls to this function and
>>> make linking work
>>
>> Why isn't this from configure.ac working?
>>
>> # Set common system defines for POSIX extensions, such as _GNU_SOURCE
>> # Must be called before any macros that run the compiler (like AC_PROG_LIBTOOL)
>> # to avoid autoconf errors.
>> AC_USE_SYSTEM_EXTENSIONS
>
> Do these make it to CC_FOR_BUILD? Here is what it looks like before:

AC_USE_SYSTEM_EXTENSIONS sets _GNU_SOURCE (and more) using AC_DEFINE,
so they end up in config.h... which isn't being included in
makekeys.c.

So the correct and upstreamable fix is to include config.h from makekeys.c.

Ross



^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [PATCH 2/2] libx11: fix nativesdk build on older distros
  2012-09-25 16:48       ` Burton, Ross
@ 2012-09-25 17:38         ` McClintock Matthew-B29882
       [not found]         ` <CAEsOVNfCLUhhpM91OBLC_paOXzsoS6PMeVXdp2xSnajqGuBcyg@mail.gmail.com>
  1 sibling, 0 replies; 21+ messages in thread
From: McClintock Matthew-B29882 @ 2012-09-25 17:38 UTC (permalink / raw)
  To: Burton, Ross; +Cc: McClintock Matthew-B29882, OE-core

On Tue, Sep 25, 2012 at 11:48 AM, Burton, Ross <ross.burton@intel.com> wrote:
> Whoops, I dropped oe-core.
>
> On 25 September 2012 16:38, McClintock Matthew-B29882
> <B29882@freescale.com> wrote:
>>>> Older libc do not have this defined, we can use the -D_GNU_SOURCE
>>>> to the compiler to prevent generating calls to this function and
>>>> make linking work
>>>
>>> Why isn't this from configure.ac working?
>>>
>>> # Set common system defines for POSIX extensions, such as _GNU_SOURCE
>>> # Must be called before any macros that run the compiler (like AC_PROG_LIBTOOL)
>>> # to avoid autoconf errors.
>>> AC_USE_SYSTEM_EXTENSIONS
>>
>> Do these make it to CC_FOR_BUILD? Here is what it looks like before:
>
> AC_USE_SYSTEM_EXTENSIONS sets _GNU_SOURCE (and more) using AC_DEFINE,
> so they end up in config.h... which isn't being included in
> makekeys.c.
>
> So the correct and upstreamable fix is to include config.h from makekeys.c.

I read somewhere (very informative - I know - but I've forgot where)
that you are not supposed to include config.h for CC_FOR_BUILD
targets? I'm not expert and just double checking on this bit as the
correct solution.

--M



^ permalink raw reply	[flat|nested] 21+ messages in thread

[parent not found: <CAEsOVNfCLUhhpM91OBLC_paOXzsoS6PMeVXdp2xSnajqGuBcyg@mail.gmail.com>]

* Re: [PATCH 2/2] libx11: fix nativesdk build on older distros
       [not found]         ` <CAEsOVNfCLUhhpM91OBLC_paOXzsoS6PMeVXdp2xSnajqGuBcyg@mail.gmail.com>
@ 2012-09-25 18:55           ` McClintock Matthew-B29882
  2012-09-25 19:09             ` Burton, Ross
  0 siblings, 1 reply; 21+ messages in thread
From: McClintock Matthew-B29882 @ 2012-09-25 18:55 UTC (permalink / raw)
  To: Burton, Ross; +Cc: McClintock Matthew-B29882, OE-core

On Tue, Sep 25, 2012 at 12:38 PM, Matthew McClintock <msm@freescale.com> wrote:
> On Tue, Sep 25, 2012 at 11:48 AM, Burton, Ross <ross.burton@intel.com> wrote:
>> Whoops, I dropped oe-core.
>>
>> On 25 September 2012 16:38, McClintock Matthew-B29882
>> <B29882@freescale.com> wrote:
>>>>> Older libc do not have this defined, we can use the -D_GNU_SOURCE
>>>>> to the compiler to prevent generating calls to this function and
>>>>> make linking work
>>>>
>>>> Why isn't this from configure.ac working?
>>>>
>>>> # Set common system defines for POSIX extensions, such as _GNU_SOURCE
>>>> # Must be called before any macros that run the compiler (like AC_PROG_LIBTOOL)
>>>> # to avoid autoconf errors.
>>>> AC_USE_SYSTEM_EXTENSIONS
>>>
>>> Do these make it to CC_FOR_BUILD? Here is what it looks like before:
>>
>> AC_USE_SYSTEM_EXTENSIONS sets _GNU_SOURCE (and more) using AC_DEFINE,
>> so they end up in config.h... which isn't being included in
>> makekeys.c.
>>
>> So the correct and upstreamable fix is to include config.h from makekeys.c.
>
> I read somewhere (very informative - I know - but I've forgot where)
> that you are not supposed to include config.h for CC_FOR_BUILD
> targets? I'm not expert and just double checking on this bit as the
> correct solution.

Found it: http://sources.redhat.com/autobook/autobook/autobook_270.html

-M



^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [PATCH 2/2] libx11: fix nativesdk build on older distros
  2012-09-25 18:55           ` McClintock Matthew-B29882
@ 2012-09-25 19:09             ` Burton, Ross
  2012-09-25 23:11               ` Daniel Stone
  0 siblings, 1 reply; 21+ messages in thread
From: Burton, Ross @ 2012-09-25 19:09 UTC (permalink / raw)
  To: McClintock Matthew-B29882; +Cc: OE-core

On 25 September 2012 19:55, McClintock Matthew-B29882
<B29882@freescale.com> wrote:
>> I read somewhere (very informative - I know - but I've forgot where)
>> that you are not supposed to include config.h for CC_FOR_BUILD
>> targets? I'm not expert and just double checking on this bit as the
>> correct solution.
>
> Found it: http://sources.redhat.com/autobook/autobook/autobook_270.html

That is a very good point, hadn't thought of that (and I recommend
that book to everyone, clearly I should re-read it).

The best fix is to just #define _GNU_SOURCE at the top of makekeys
then, and push that upstream (mail patch to xorg-devel@lists.x.org).

Ross



^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [PATCH 2/2] libx11: fix nativesdk build on older distros
  2012-09-25 19:09             ` Burton, Ross
@ 2012-09-25 23:11               ` Daniel Stone
  2012-09-26  9:30                 ` Burton, Ross
  0 siblings, 1 reply; 21+ messages in thread
From: Daniel Stone @ 2012-09-25 23:11 UTC (permalink / raw)
  To: Burton, Ross; +Cc: McClintock Matthew-B29882, OE-core

Hi,

On 26 September 2012 05:09, Burton, Ross <ross.burton@intel.com> wrote:
> On 25 September 2012 19:55, McClintock Matthew-B29882
> <B29882@freescale.com> wrote:
>>> I read somewhere (very informative - I know - but I've forgot where)
>>> that you are not supposed to include config.h for CC_FOR_BUILD
>>> targets? I'm not expert and just double checking on this bit as the
>>> correct solution.
>>
>> Found it: http://sources.redhat.com/autobook/autobook/autobook_270.html
>
> That is a very good point, hadn't thought of that (and I recommend
> that book to everyone, clearly I should re-read it).
>
> The best fix is to just #define _GNU_SOURCE at the top of makekeys
> then, and push that upstream (mail patch to xorg-devel@lists.x.org).

Actually, it isn't, as that breaks non-glibc badly.  glibc takes
_GNU_SOURCE to mean 'please add useful GNU extensions to this POSIX
wasteland', whereas BSD and/or Solaris take it to mean 'please make
this only GNU and don't use any other extensions at all'.  So we have
to do whatever AC_USE_SYSTEM_EXTENSIONS does, because that really is
the only thing that actually works.

Cheers,
Daniel



^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [PATCH 2/2] libx11: fix nativesdk build on older distros
  2012-09-25 23:11               ` Daniel Stone
@ 2012-09-26  9:30                 ` Burton, Ross
  2012-09-26 17:55                   ` McClintock Matthew-B29882
  0 siblings, 1 reply; 21+ messages in thread
From: Burton, Ross @ 2012-09-26  9:30 UTC (permalink / raw)
  To: Daniel Stone; +Cc: McClintock Matthew-B29882, OE-core

On 26 September 2012 00:11, Daniel Stone <daniel@fooishbar.org> wrote:
>> The best fix is to just #define _GNU_SOURCE at the top of makekeys
>> then, and push that upstream (mail patch to xorg-devel@lists.x.org).
>
> Actually, it isn't, as that breaks non-glibc badly.  glibc takes
> _GNU_SOURCE to mean 'please add useful GNU extensions to this POSIX
> wasteland', whereas BSD and/or Solaris take it to mean 'please make
> this only GNU and don't use any other extensions at all'.  So we have
> to do whatever AC_USE_SYSTEM_EXTENSIONS does, because that really is
> the only thing that actually works.

What do you mean non-glibc? :)

Ignoring Minix as a build host (I think that's reasonable),
AC_USE_SYSTEM_EXTENSIONS  defines _ALL_SOURCE _GNU_SOURCE
_POSIX_PTHREAD_SEMANTICS _TANDEM_SOURCE, and does a compile-time
sanity test of __EXTENSIONS__ (because it's possible that some
combination of these defines make the system headers unusable on
Solaris).

This is annoying.  How about for oe-core we patch in -D_GNU_SOURCE to
src/util/Makefile.am's CPPFLAGS definition and I'll discuss with
xorg-dev for a proper fix?

Ross

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [PATCH 2/2] libx11: fix nativesdk build on older distros
  2012-09-26  9:30                 ` Burton, Ross
@ 2012-09-26 17:55                   ` McClintock Matthew-B29882
  0 siblings, 0 replies; 21+ messages in thread
From: McClintock Matthew-B29882 @ 2012-09-26 17:55 UTC (permalink / raw)
  To: Burton, Ross; +Cc: McClintock Matthew-B29882, OE-core

On Wed, Sep 26, 2012 at 4:30 AM, Burton, Ross <ross.burton@intel.com> wrote:
> On 26 September 2012 00:11, Daniel Stone <daniel@fooishbar.org> wrote:
>>> The best fix is to just #define _GNU_SOURCE at the top of makekeys
>>> then, and push that upstream (mail patch to xorg-devel@lists.x.org).
>>
>> Actually, it isn't, as that breaks non-glibc badly.  glibc takes
>> _GNU_SOURCE to mean 'please add useful GNU extensions to this POSIX
>> wasteland', whereas BSD and/or Solaris take it to mean 'please make
>> this only GNU and don't use any other extensions at all'.  So we have
>> to do whatever AC_USE_SYSTEM_EXTENSIONS does, because that really is
>> the only thing that actually works.
>
> What do you mean non-glibc? :)
>
> Ignoring Minix as a build host (I think that's reasonable),
> AC_USE_SYSTEM_EXTENSIONS  defines _ALL_SOURCE _GNU_SOURCE
> _POSIX_PTHREAD_SEMANTICS _TANDEM_SOURCE, and does a compile-time
> sanity test of __EXTENSIONS__ (because it's possible that some
> combination of these defines make the system headers unusable on
> Solaris).
>
> This is annoying.  How about for oe-core we patch in -D_GNU_SOURCE to
> src/util/Makefile.am's CPPFLAGS definition and I'll discuss with
> xorg-dev for a proper fix?

Would this be OK for now in libx11.inc?

-export CFLAGS_FOR_BUILD = "${BUILD_CFLAGS}"
+export CFLAGS_FOR_BUILD = "${BUILD_CFLAGS} -D_GNU_SOURCE"

-M



^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [PATCH 1/2] libx11.inc: disable warnings that don't work on certain compilers
  2012-09-24 19:55 [PATCH 1/2] libx11.inc: disable warnings that don't work on certain compilers Matthew McClintock
  2012-09-24 19:55 ` [PATCH 2/2] libx11: fix nativesdk build on older distros Matthew McClintock
@ 2012-09-24 20:00 ` Martin Jansa
  2012-09-24 20:06   ` McClintock Matthew-B29882
       [not found]   ` <CAEsOVNfNgM0b508hovOLYTFe=4o7XDD8meZ37t3UM+sVY4WM8w@mail.gmail.com>
  1 sibling, 2 replies; 21+ messages in thread
From: Martin Jansa @ 2012-09-24 20:00 UTC (permalink / raw)
  To: Matthew McClintock; +Cc: openembedded-core

[-- Attachment #1: Type: text/plain, Size: 2386 bytes --]

On Mon, Sep 24, 2012 at 02:55:45PM -0500, Matthew McClintock wrote:
> Fixes these sorts of issues present on older gcc (CentOS 5.x in this case)
> 
> | cc1: error: unrecognized command line option "-Werror=implicit"
> | cc1: error: unrecognized command line option "-Werror=nonnull"
> | cc1: error: unrecognized command line option "-Werror=init-self"
> | cc1: error: unrecognized command line option "-Werror=main"
> | cc1: error: unrecognized command line option "-Werror=missing-braces"
> | cc1: error: unrecognized command line option "-Werror=sequence-point"
> | cc1: error: unrecognized command line option "-Werror=return-type"
> | cc1: error: unrecognized command line option "-Werror=trigraphs"
> | cc1: error: unrecognized command line option "-Werror=array-bounds"
> | cc1: error: unrecognized command line option "-Werror=write-strings"
> | cc1: error: unrecognized command line option "-Werror=address"
> | cc1: error: unrecognized command line option "-Werror=int-to-pointer-cast"
> | cc1: error: unrecognized command line option "-Werror=pointer-to-int-cast"

Shouldn't it be applied only for -native? version?

Cheers,

> 
> Signed-off-by: Matthew McClintock <msm@freescale.com>
> ---
>  meta/recipes-graphics/xorg-lib/libx11.inc |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-graphics/xorg-lib/libx11.inc b/meta/recipes-graphics/xorg-lib/libx11.inc
> index 3ecd9e5..0e99442 100644
> --- a/meta/recipes-graphics/xorg-lib/libx11.inc
> +++ b/meta/recipes-graphics/xorg-lib/libx11.inc
> @@ -11,7 +11,7 @@ inherit siteinfo
>  FILESPATH = "${FILE_DIRNAME}/libx11"
>  
>  PE = "1"
> -INC_PR = "r8"
> +INC_PR = "r9"
>  
>  PROVIDES = "virtual/libx11"
>  
> @@ -23,6 +23,7 @@ DEPENDS += "xproto xextproto xtrans libxcb kbproto inputproto"
>  DEPENDS += "xproto-native"
>  
>  EXTRA_OECONF += "--with-keysymdefdir=${STAGING_INCDIR}/X11/"
> +EXTRA_OEMAKE = '-e CWARNFLAGS=""'
>  
>  # Let people with incredibly archaic requirements enable Xcms and BigFont, but
>  # disable them by default.
> -- 
> 1.7.9.7
> 
> 
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [PATCH 1/2] libx11.inc: disable warnings that don't work on certain compilers
  2012-09-24 20:00 ` [PATCH 1/2] libx11.inc: disable warnings that don't work on certain compilers Martin Jansa
@ 2012-09-24 20:06   ` McClintock Matthew-B29882
  2012-09-24 20:52     ` Burton, Ross
       [not found]   ` <CAEsOVNfNgM0b508hovOLYTFe=4o7XDD8meZ37t3UM+sVY4WM8w@mail.gmail.com>
  1 sibling, 1 reply; 21+ messages in thread
From: McClintock Matthew-B29882 @ 2012-09-24 20:06 UTC (permalink / raw)
  To: Martin Jansa; +Cc: openembedded-core@lists.openembedded.org

On Mon, Sep 24, 2012 at 3:00 PM, Martin Jansa <martin.jansa@gmail.com> wrote:
> On Mon, Sep 24, 2012 at 02:55:45PM -0500, Matthew McClintock wrote:
>> Fixes these sorts of issues present on older gcc (CentOS 5.x in this case)
>>
>> | cc1: error: unrecognized command line option "-Werror=implicit"
>> | cc1: error: unrecognized command line option "-Werror=nonnull"
>> | cc1: error: unrecognized command line option "-Werror=init-self"
>> | cc1: error: unrecognized command line option "-Werror=main"
>> | cc1: error: unrecognized command line option "-Werror=missing-braces"
>> | cc1: error: unrecognized command line option "-Werror=sequence-point"
>> | cc1: error: unrecognized command line option "-Werror=return-type"
>> | cc1: error: unrecognized command line option "-Werror=trigraphs"
>> | cc1: error: unrecognized command line option "-Werror=array-bounds"
>> | cc1: error: unrecognized command line option "-Werror=write-strings"
>> | cc1: error: unrecognized command line option "-Werror=address"
>> | cc1: error: unrecognized command line option "-Werror=int-to-pointer-cast"
>> | cc1: error: unrecognized command line option "-Werror=pointer-to-int-cast"
>
> Shouldn't it be applied only for -native? version?

That's reasonable. But, suppressing warnings to compile logs also did
not seem to matter much since we don't go line by line on warnings in
compile logs (does anyone?). I'll go with the consensus though.

-M

>
> Cheers,
>
>>
>> Signed-off-by: Matthew McClintock <msm@freescale.com>
>> ---
>>  meta/recipes-graphics/xorg-lib/libx11.inc |    3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-graphics/xorg-lib/libx11.inc b/meta/recipes-graphics/xorg-lib/libx11.inc
>> index 3ecd9e5..0e99442 100644
>> --- a/meta/recipes-graphics/xorg-lib/libx11.inc
>> +++ b/meta/recipes-graphics/xorg-lib/libx11.inc
>> @@ -11,7 +11,7 @@ inherit siteinfo
>>  FILESPATH = "${FILE_DIRNAME}/libx11"
>>
>>  PE = "1"
>> -INC_PR = "r8"
>> +INC_PR = "r9"
>>
>>  PROVIDES = "virtual/libx11"
>>
>> @@ -23,6 +23,7 @@ DEPENDS += "xproto xextproto xtrans libxcb kbproto inputproto"
>>  DEPENDS += "xproto-native"
>>
>>  EXTRA_OECONF += "--with-keysymdefdir=${STAGING_INCDIR}/X11/"
>> +EXTRA_OEMAKE = '-e CWARNFLAGS=""'
>>
>>  # Let people with incredibly archaic requirements enable Xcms and BigFont, but
>>  # disable them by default.
>> --
>> 1.7.9.7
>>
>>
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
> --
> Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>



^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [PATCH 1/2] libx11.inc: disable warnings that don't work on certain compilers
  2012-09-24 20:06   ` McClintock Matthew-B29882
@ 2012-09-24 20:52     ` Burton, Ross
  2012-09-24 22:55       ` McClintock Matthew-B29882
  0 siblings, 1 reply; 21+ messages in thread
From: Burton, Ross @ 2012-09-24 20:52 UTC (permalink / raw)
  To: McClintock Matthew-B29882
  Cc: Martin Jansa, openembedded-core@lists.openembedded.org

On 24 September 2012 21:06, McClintock Matthew-B29882
<B29882@freescale.com> wrote:
>> Shouldn't it be applied only for -native? version?
>
> That's reasonable. But, suppressing warnings to compile logs also did
> not seem to matter much since we don't go line by line on warnings in
> compile logs (does anyone?). I'll go with the consensus though.

I'd prefer this to be a -native only thing too.

Ross



^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [PATCH 1/2] libx11.inc: disable warnings that don't work on certain compilers
  2012-09-24 20:52     ` Burton, Ross
@ 2012-09-24 22:55       ` McClintock Matthew-B29882
  0 siblings, 0 replies; 21+ messages in thread
From: McClintock Matthew-B29882 @ 2012-09-24 22:55 UTC (permalink / raw)
  To: Burton, Ross
  Cc: McClintock Matthew-B29882, Martin Jansa,
	openembedded-core@lists.openembedded.org

On Mon, Sep 24, 2012 at 3:52 PM, Burton, Ross <ross.burton@intel.com> wrote:
> On 24 September 2012 21:06, McClintock Matthew-B29882
> <B29882@freescale.com> wrote:
>>> Shouldn't it be applied only for -native? version?
>>
>> That's reasonable. But, suppressing warnings to compile logs also did
>> not seem to matter much since we don't go line by line on warnings in
>> compile logs (does anyone?). I'll go with the consensus though.
>
> I'd prefer this to be a -native only thing too.

I think the CWARNFLAGS needs to be on all the though (native,
nativesdk, etc), '-e' can go away entirely.

-M

>
> Ross
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core



^ permalink raw reply	[flat|nested] 21+ messages in thread

[parent not found: <CAEsOVNfNgM0b508hovOLYTFe=4o7XDD8meZ37t3UM+sVY4WM8w@mail.gmail.com>]

* Re: [PATCH 1/2] libx11.inc: disable warnings that don't work on certain compilers
       [not found]   ` <CAEsOVNfNgM0b508hovOLYTFe=4o7XDD8meZ37t3UM+sVY4WM8w@mail.gmail.com>
@ 2012-09-24 20:43     ` McClintock Matthew-B29882
  2012-09-24 21:07       ` Chris Larson
  0 siblings, 1 reply; 21+ messages in thread
From: McClintock Matthew-B29882 @ 2012-09-24 20:43 UTC (permalink / raw)
  To: Martin Jansa; +Cc: openembedded-core@lists.openembedded.org

On Mon, Sep 24, 2012 at 3:06 PM, Matthew McClintock <msm@freescale.com> wrote:
> On Mon, Sep 24, 2012 at 3:00 PM, Martin Jansa <martin.jansa@gmail.com> wrote:
>> On Mon, Sep 24, 2012 at 02:55:45PM -0500, Matthew McClintock wrote:
>>> Fixes these sorts of issues present on older gcc (CentOS 5.x in this case)
>>>
>>> | cc1: error: unrecognized command line option "-Werror=implicit"
>>> | cc1: error: unrecognized command line option "-Werror=nonnull"
>>> | cc1: error: unrecognized command line option "-Werror=init-self"
>>> | cc1: error: unrecognized command line option "-Werror=main"
>>> | cc1: error: unrecognized command line option "-Werror=missing-braces"
>>> | cc1: error: unrecognized command line option "-Werror=sequence-point"
>>> | cc1: error: unrecognized command line option "-Werror=return-type"
>>> | cc1: error: unrecognized command line option "-Werror=trigraphs"
>>> | cc1: error: unrecognized command line option "-Werror=array-bounds"
>>> | cc1: error: unrecognized command line option "-Werror=write-strings"
>>> | cc1: error: unrecognized command line option "-Werror=address"
>>> | cc1: error: unrecognized command line option "-Werror=int-to-pointer-cast"
>>> | cc1: error: unrecognized command line option "-Werror=pointer-to-int-cast"
>>
>> Shouldn't it be applied only for -native? version?
>
> That's reasonable. But, suppressing warnings to compile logs also did
> not seem to matter much since we don't go line by line on warnings in
> compile logs (does anyone?). I'll go with the consensus though.

Actually, this makes sense now because I'm seeing issues with
non-nativesdk packages with the '-e' I've added... thought I build
tested that... ;(

-M

>
> -M
>
>>
>> Cheers,
>>
>>>
>>> Signed-off-by: Matthew McClintock <msm@freescale.com>
>>> ---
>>>  meta/recipes-graphics/xorg-lib/libx11.inc |    3 ++-
>>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/meta/recipes-graphics/xorg-lib/libx11.inc b/meta/recipes-graphics/xorg-lib/libx11.inc
>>> index 3ecd9e5..0e99442 100644
>>> --- a/meta/recipes-graphics/xorg-lib/libx11.inc
>>> +++ b/meta/recipes-graphics/xorg-lib/libx11.inc
>>> @@ -11,7 +11,7 @@ inherit siteinfo
>>>  FILESPATH = "${FILE_DIRNAME}/libx11"
>>>
>>>  PE = "1"
>>> -INC_PR = "r8"
>>> +INC_PR = "r9"
>>>
>>>  PROVIDES = "virtual/libx11"
>>>
>>> @@ -23,6 +23,7 @@ DEPENDS += "xproto xextproto xtrans libxcb kbproto inputproto"
>>>  DEPENDS += "xproto-native"
>>>
>>>  EXTRA_OECONF += "--with-keysymdefdir=${STAGING_INCDIR}/X11/"
>>> +EXTRA_OEMAKE = '-e CWARNFLAGS=""'
>>>
>>>  # Let people with incredibly archaic requirements enable Xcms and BigFont, but
>>>  # disable them by default.
>>> --
>>> 1.7.9.7
>>>
>>>
>>>
>>> _______________________________________________
>>> Openembedded-core mailing list
>>> Openembedded-core@lists.openembedded.org
>>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>>
>> --
>> Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>>



^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [PATCH 1/2] libx11.inc: disable warnings that don't work on certain compilers
  2012-09-24 20:43     ` McClintock Matthew-B29882
@ 2012-09-24 21:07       ` Chris Larson
  2012-09-24 22:31         ` McClintock Matthew-B29882
  0 siblings, 1 reply; 21+ messages in thread
From: Chris Larson @ 2012-09-24 21:07 UTC (permalink / raw)
  To: McClintock Matthew-B29882
  Cc: Martin Jansa, openembedded-core@lists.openembedded.org

On Mon, Sep 24, 2012 at 1:43 PM, McClintock Matthew-B29882
<B29882@freescale.com> wrote:
> On Mon, Sep 24, 2012 at 3:06 PM, Matthew McClintock <msm@freescale.com> wrote:
>> On Mon, Sep 24, 2012 at 3:00 PM, Martin Jansa <martin.jansa@gmail.com> wrote:
>>> On Mon, Sep 24, 2012 at 02:55:45PM -0500, Matthew McClintock wrote:
>>>> Fixes these sorts of issues present on older gcc (CentOS 5.x in this case)
>>>>
>>>> | cc1: error: unrecognized command line option "-Werror=implicit"
>>>> | cc1: error: unrecognized command line option "-Werror=nonnull"
>>>> | cc1: error: unrecognized command line option "-Werror=init-self"
>>>> | cc1: error: unrecognized command line option "-Werror=main"
>>>> | cc1: error: unrecognized command line option "-Werror=missing-braces"
>>>> | cc1: error: unrecognized command line option "-Werror=sequence-point"
>>>> | cc1: error: unrecognized command line option "-Werror=return-type"
>>>> | cc1: error: unrecognized command line option "-Werror=trigraphs"
>>>> | cc1: error: unrecognized command line option "-Werror=array-bounds"
>>>> | cc1: error: unrecognized command line option "-Werror=write-strings"
>>>> | cc1: error: unrecognized command line option "-Werror=address"
>>>> | cc1: error: unrecognized command line option "-Werror=int-to-pointer-cast"
>>>> | cc1: error: unrecognized command line option "-Werror=pointer-to-int-cast"
>>>
>>> Shouldn't it be applied only for -native? version?
>>
>> That's reasonable. But, suppressing warnings to compile logs also did
>> not seem to matter much since we don't go line by line on warnings in
>> compile logs (does anyone?). I'll go with the consensus though.
>
> Actually, this makes sense now because I'm seeing issues with
> non-nativesdk packages with the '-e' I've added... thought I build
> tested that... ;(

Why is -e being added? It's almost always better to add the vars you
need explicitly, imo. I wish we could change the default EXTRA_OEMAKE
to drop it, personally. It can cause odd unintended consequences.
-- 
Christopher Larson



^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [PATCH 1/2] libx11.inc: disable warnings that don't work on certain compilers
  2012-09-24 21:07       ` Chris Larson
@ 2012-09-24 22:31         ` McClintock Matthew-B29882
  0 siblings, 0 replies; 21+ messages in thread
From: McClintock Matthew-B29882 @ 2012-09-24 22:31 UTC (permalink / raw)
  To: Chris Larson
  Cc: McClintock Matthew-B29882, Martin Jansa,
	openembedded-core@lists.openembedded.org

On Mon, Sep 24, 2012 at 4:07 PM, Chris Larson <clarson@kergoth.com> wrote:
> On Mon, Sep 24, 2012 at 1:43 PM, McClintock Matthew-B29882
> <B29882@freescale.com> wrote:
>> On Mon, Sep 24, 2012 at 3:06 PM, Matthew McClintock <msm@freescale.com> wrote:
>>> On Mon, Sep 24, 2012 at 3:00 PM, Martin Jansa <martin.jansa@gmail.com> wrote:
>>>> On Mon, Sep 24, 2012 at 02:55:45PM -0500, Matthew McClintock wrote:
>>>>> Fixes these sorts of issues present on older gcc (CentOS 5.x in this case)
>>>>>
>>>>> | cc1: error: unrecognized command line option "-Werror=implicit"
>>>>> | cc1: error: unrecognized command line option "-Werror=nonnull"
>>>>> | cc1: error: unrecognized command line option "-Werror=init-self"
>>>>> | cc1: error: unrecognized command line option "-Werror=main"
>>>>> | cc1: error: unrecognized command line option "-Werror=missing-braces"
>>>>> | cc1: error: unrecognized command line option "-Werror=sequence-point"
>>>>> | cc1: error: unrecognized command line option "-Werror=return-type"
>>>>> | cc1: error: unrecognized command line option "-Werror=trigraphs"
>>>>> | cc1: error: unrecognized command line option "-Werror=array-bounds"
>>>>> | cc1: error: unrecognized command line option "-Werror=write-strings"
>>>>> | cc1: error: unrecognized command line option "-Werror=address"
>>>>> | cc1: error: unrecognized command line option "-Werror=int-to-pointer-cast"
>>>>> | cc1: error: unrecognized command line option "-Werror=pointer-to-int-cast"
>>>>
>>>> Shouldn't it be applied only for -native? version?
>>>
>>> That's reasonable. But, suppressing warnings to compile logs also did
>>> not seem to matter much since we don't go line by line on warnings in
>>> compile logs (does anyone?). I'll go with the consensus though.
>>
>> Actually, this makes sense now because I'm seeing issues with
>> non-nativesdk packages with the '-e' I've added... thought I build
>> tested that... ;(
>
> Why is -e being added? It's almost always better to add the vars you
> need explicitly, imo. I wish we could change the default EXTRA_OEMAKE
> to drop it, personally. It can cause odd unintended consequences.

I think this was a holdover from trying to fix the issue fixed by
patch 2/2. I don't think it belogs - I was working on this Friday and
forgot everything today ;)

-M

> --
> Christopher Larson
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core



^ permalink raw reply	[flat|nested] 21+ messages in thread

end of thread, other threads:[~2012-09-26 18:08 UTC | newest]

Thread overview: 21+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-24 19:55 [PATCH 1/2] libx11.inc: disable warnings that don't work on certain compilers Matthew McClintock
2012-09-24 19:55 ` [PATCH 2/2] libx11: fix nativesdk build on older distros Matthew McClintock
2012-09-24 20:13   ` McClintock Matthew-B29882
2012-09-24 21:08     ` Chris Larson
2012-09-24 22:28       ` McClintock Matthew-B29882
2012-09-24 21:52   ` Saul Wold
2012-09-24 22:28     ` McClintock Matthew-B29882
     [not found]   ` <CAJTo0LYe6LuFQJS_36PYVsjwnp=N9J-XuiFVMntBi76qt+i4aw@mail.gmail.com>
     [not found]     ` <70CC66F5C30A414DADDA6973E4CA391A6A6CE2@039-SN1MPN1-001.039d.mgd.msft.net>
2012-09-25 16:48       ` Burton, Ross
2012-09-25 17:38         ` McClintock Matthew-B29882
     [not found]         ` <CAEsOVNfCLUhhpM91OBLC_paOXzsoS6PMeVXdp2xSnajqGuBcyg@mail.gmail.com>
2012-09-25 18:55           ` McClintock Matthew-B29882
2012-09-25 19:09             ` Burton, Ross
2012-09-25 23:11               ` Daniel Stone
2012-09-26  9:30                 ` Burton, Ross
2012-09-26 17:55                   ` McClintock Matthew-B29882
2012-09-24 20:00 ` [PATCH 1/2] libx11.inc: disable warnings that don't work on certain compilers Martin Jansa
2012-09-24 20:06   ` McClintock Matthew-B29882
2012-09-24 20:52     ` Burton, Ross
2012-09-24 22:55       ` McClintock Matthew-B29882
     [not found]   ` <CAEsOVNfNgM0b508hovOLYTFe=4o7XDD8meZ37t3UM+sVY4WM8w@mail.gmail.com>
2012-09-24 20:43     ` McClintock Matthew-B29882
2012-09-24 21:07       ` Chris Larson
2012-09-24 22:31         ` McClintock Matthew-B29882

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.