From: Jeff Garzik <jgarzik@pobox.com>
To: "Tony Hung - PTT 洪瑞嶸" <tony.hung@tw.promise.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ahci: add a boot option to enable promise ahci
Date: Mon, 24 Sep 2012 23:05:18 -0400 [thread overview]
Message-ID: <50611F6E.8000607@pobox.com> (raw)
In-Reply-To: <1AF0FA078A5A3541A8A8019D26081C2E88DCE6D976@ptt-ex02.promise.com.tw>
On 09/23/2012 10:34 PM, Tony Hung - PTT 洪瑞嶸 wrote:
> linux-3.2.0/drivers/ata/ahci.c: In function 'hptiop_host_request_callback':
>
> Use min_t(size_t, ...) to fix.
>
> Signed-off-by: Tony Hung <tony.hung@tw.promise.com>
> ---
>
> diff --git a/linux-3.2.0/drivers/ata/ahci.c b/linux-3.2.0/drivers/ata/ahci.c
> --- a/linux-3.2.0/drivers/ata/ahci.c 2012-08-29 13:40:26.046851693 +0800
> +++ b/linux-3.2.0/drivers/ata/ahci.c 2012-08-30 17:23:10.207838960 +0800
> @@ -430,6 +430,9 @@ static int marvell_enable = 1;
> module_param(marvell_enable, int, 0644);
> MODULE_PARM_DESC(marvell_enable, "Marvell SATA via AHCI (1 = enabled)");
>
> +static int promise_enable;
> +module_param(promise_enable, int, 0644);
> +MODULE_PARM_DESC(promise_enable, "Promise SATA via AHCI (1 = enabled)");
>
> static void ahci_pci_save_initial_config(struct pci_dev *pdev,
> struct ahci_host_priv *hpriv)
> @@ -1049,6 +1052,16 @@ static int ahci_init_one(struct pci_dev
> if (pdev->vendor == PCI_VENDOR_ID_MARVELL && !marvell_enable)
> return -ENODEV;
>
> + /*
> + * In RAID mode, Promise software RAID need to replace
> + * original AHCI module, but if AHCI driver build-in kernel,
> + * Promise AHCI module need a boot option to disable it
> + */
> + if (promise_enable &&
> + ((pdev->class >> 8) == PCI_CLASS_STORAGE_RAID) &&
> + (pdev->vendor == PCI_VENDOR_ID_ATI ||
> + pdev->vendor == PCI_VENDOR_ID_AMD))
> + return -ENODEV;
We need the patch for the Promise Software RAID driver, to accept this...
Jeff
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Garzik <jgarzik@pobox.com>
To: "Tony Hung - PTT 洪瑞嶸" <tony.hung@tw.promise.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ahci: add a boot option to enable promise ahci
Date: Mon, 24 Sep 2012 23:05:18 -0400 [thread overview]
Message-ID: <50611F6E.8000607@pobox.com> (raw)
In-Reply-To: <1AF0FA078A5A3541A8A8019D26081C2E88DCE6D976@ptt-ex02.promise.com.tw>
On 09/23/2012 10:34 PM, Tony Hung - PTT 洪瑞嶸 wrote:
> linux-3.2.0/drivers/ata/ahci.c: In function 'hptiop_host_request_callback':
>
> Use min_t(size_t, ...) to fix.
>
> Signed-off-by: Tony Hung <tony.hung@tw.promise.com>
> ---
>
> diff --git a/linux-3.2.0/drivers/ata/ahci.c b/linux-3.2.0/drivers/ata/ahci.c
> --- a/linux-3.2.0/drivers/ata/ahci.c 2012-08-29 13:40:26.046851693 +0800
> +++ b/linux-3.2.0/drivers/ata/ahci.c 2012-08-30 17:23:10.207838960 +0800
> @@ -430,6 +430,9 @@ static int marvell_enable = 1;
> module_param(marvell_enable, int, 0644);
> MODULE_PARM_DESC(marvell_enable, "Marvell SATA via AHCI (1 = enabled)");
>
> +static int promise_enable;
> +module_param(promise_enable, int, 0644);
> +MODULE_PARM_DESC(promise_enable, "Promise SATA via AHCI (1 = enabled)");
>
> static void ahci_pci_save_initial_config(struct pci_dev *pdev,
> struct ahci_host_priv *hpriv)
> @@ -1049,6 +1052,16 @@ static int ahci_init_one(struct pci_dev
> if (pdev->vendor == PCI_VENDOR_ID_MARVELL && !marvell_enable)
> return -ENODEV;
>
> + /*
> + * In RAID mode, Promise software RAID need to replace
> + * original AHCI module, but if AHCI driver build-in kernel,
> + * Promise AHCI module need a boot option to disable it
> + */
> + if (promise_enable &&
> + ((pdev->class >> 8) == PCI_CLASS_STORAGE_RAID) &&
> + (pdev->vendor == PCI_VENDOR_ID_ATI ||
> + pdev->vendor == PCI_VENDOR_ID_AMD))
> + return -ENODEV;
We need the patch for the Promise Software RAID driver, to accept this...
Jeff
next prev parent reply other threads:[~2012-09-25 3:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-24 2:34 [PATCH] ahci: add a boot option to enable promise ahci Tony Hung - PTT 洪瑞嶸
2012-09-24 2:34 ` Tony Hung - PTT 洪瑞嶸
2012-09-25 3:05 ` Jeff Garzik [this message]
2012-09-25 3:05 ` Jeff Garzik
2012-09-25 5:40 ` Tony Hung - PTT 洪瑞嶸
2012-09-25 5:40 ` Tony Hung - PTT 洪瑞嶸
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50611F6E.8000607@pobox.com \
--to=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=tony.hung@tw.promise.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.