From: Yegor Yefremov <yegor_sub1@visionsystems.de>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: yegorslists@googlemail.com, linux-omap@vger.kernel.org,
Dejan Gacnik <dejan.gacnik@gmail.com>,
linux-arm-kernel@lists.infradead.org,
Tony Lindgren <tony@atomide.com>
Subject: Re: [PATCH v2] arm: make FORCE_MAX_ZONEORDER configurable for TI AM33XX
Date: Tue, 25 Sep 2012 10:46:34 +0200 [thread overview]
Message-ID: <50616F6A.80100@visionsystems.de> (raw)
In-Reply-To: <20120925083245.GH31374@n2100.arm.linux.org.uk>
On 25.09.2012 10:32, Russell King - ARM Linux wrote:
> On Tue, Sep 25, 2012 at 10:26:30AM +0200, yegorslists@googlemail.com wrote:
>> From: Yegor Yefremov <yegorslists@googlemail.com>
>>
>> FORCE_MAX_ZONEORDER of 12 is needed to allocation more than 4MB
>> of consistent DMA memory (da8xx frame buffer driver).
>
> Okay, so the patch description says "This needs to be 12 on this platform".
>
>> config FORCE_MAX_ZONEORDER
>> - int "Maximum zone order" if ARCH_SHMOBILE
>> - range 11 64 if ARCH_SHMOBILE
>> + int "Maximum zone order" if ARCH_SHMOBILE || SOC_AM33XX
>> + range 11 64 if ARCH_SHMOBILE || SOC_AM33XX
>
> but you leave it up to the user to select something that may not be
> suitable. Wouldn't _just_ adding:
>
> default "12" if SOC_AM33XX
>
> after the "range", and making no other changes be good enough and match
> what the patch description says?
You're right. As we don't allocate anything, but increase the possible size, it shouldn't break anything. Tony is it O.K. with you?
Patch sent.
Yegor
WARNING: multiple messages have this Message-ID (diff)
From: yegor_sub1@visionsystems.de (Yegor Yefremov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] arm: make FORCE_MAX_ZONEORDER configurable for TI AM33XX
Date: Tue, 25 Sep 2012 10:46:34 +0200 [thread overview]
Message-ID: <50616F6A.80100@visionsystems.de> (raw)
In-Reply-To: <20120925083245.GH31374@n2100.arm.linux.org.uk>
On 25.09.2012 10:32, Russell King - ARM Linux wrote:
> On Tue, Sep 25, 2012 at 10:26:30AM +0200, yegorslists at googlemail.com wrote:
>> From: Yegor Yefremov <yegorslists@googlemail.com>
>>
>> FORCE_MAX_ZONEORDER of 12 is needed to allocation more than 4MB
>> of consistent DMA memory (da8xx frame buffer driver).
>
> Okay, so the patch description says "This needs to be 12 on this platform".
>
>> config FORCE_MAX_ZONEORDER
>> - int "Maximum zone order" if ARCH_SHMOBILE
>> - range 11 64 if ARCH_SHMOBILE
>> + int "Maximum zone order" if ARCH_SHMOBILE || SOC_AM33XX
>> + range 11 64 if ARCH_SHMOBILE || SOC_AM33XX
>
> but you leave it up to the user to select something that may not be
> suitable. Wouldn't _just_ adding:
>
> default "12" if SOC_AM33XX
>
> after the "range", and making no other changes be good enough and match
> what the patch description says?
You're right. As we don't allocate anything, but increase the possible size, it shouldn't break anything. Tony is it O.K. with you?
Patch sent.
Yegor
next prev parent reply other threads:[~2012-09-25 8:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-25 8:26 [PATCH v2] arm: make FORCE_MAX_ZONEORDER configurable for TI AM33XX yegorslists
2012-09-25 8:26 ` yegorslists at googlemail.com
2012-09-25 8:32 ` Russell King - ARM Linux
2012-09-25 8:32 ` Russell King - ARM Linux
2012-09-25 8:46 ` Yegor Yefremov [this message]
2012-09-25 8:46 ` Yegor Yefremov
2012-09-25 15:27 ` Tony Lindgren
2012-09-25 15:27 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50616F6A.80100@visionsystems.de \
--to=yegor_sub1@visionsystems.de \
--cc=dejan.gacnik@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=tony@atomide.com \
--cc=yegorslists@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.