From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: Fabio Porcedda <fabio.porcedda@gmail.com>,
<devicetree-discuss@lists.ozlabs.org>
Cc: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>,
Wim Van Sebroeck <wim@iguana.be>,
<linux-watchdog@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
Andrew Victor <linux@maxim.org.za>
Subject: Re: [PATCH v3 1/2] watchdog: at91sam9_wdt: add device tree support
Date: Tue, 25 Sep 2012 12:00:30 +0200 [thread overview]
Message-ID: <506180BE.6000603@atmel.com> (raw)
In-Reply-To: <CAHkwnC_=i7mEv99xU6HcFpEfC6eeumcZDWrBq2_qdv=rDf3E1g@mail.gmail.com>
On 09/25/2012 11:45 AM, Fabio Porcedda :
> On Tue, Sep 25, 2012 at 10:10 AM, Jean-Christophe PLAGNIOL-VILLARD
> <plagnioj@jcrosoft.com> wrote:
>> On 09:28 Tue 25 Sep , Fabio Porcedda wrote:
>>> Tested on an at91sam9260 board (evk-pro3)
>>>
>>> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
>>> ---
>>> .../devicetree/bindings/watchdog/atmel-wdt.txt | 19 +++++++++++++++++++
>>> drivers/watchdog/at91sam9_wdt.c | 21 +++++++++++++++++++++
>>> 2 files changed, 40 insertions(+)
>>> create mode 100644 Documentation/devicetree/bindings/watchdog/atmel-wdt.txt
>>>
>>> diff --git a/Documentation/devicetree/bindings/watchdog/atmel-wdt.txt b/Documentation/devicetree/bindings/watchdog/atmel-wdt.txt
>>> new file mode 100644
>>> index 0000000..724fad1
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/watchdog/atmel-wdt.txt
>>> @@ -0,0 +1,19 @@
>>> +* Atmel Watchdog Timers
>>> +
>>> +** at91sam9-wdt
>>> +
>>> +Required properties:
>>> +- compatible: must be "atmel,at91sam9-wdt".
>>> +- reg: physical base address of the controller and length of memory mapped
>>> + region.
>>> +
>>> +Optional properties:
>>> +- heartbeat: contains the watchdog heartbeats in seconds.
>>> +
>>> +Example:
>>> +
>>> + watchdog@fffffd40 {
>>> + compatible = "atmel,at91sam9-wdt";
>> for the secind time atmel,at91sam9260-watchdog
>
> Ok, i will fix this.
>
>> you need to put the first soc that use it in the compatible
>>> + reg = <0xfffffd40 0x10>;
>>> + heartbeat = <10>;
>> need put second in the property name so need to read the doc
>
> I didn't found any example about a property with "second" in the name.
> Which It's best "heartbeat-seconds", "heartbeat-sec" or "heartbeat-s" ?
I think that, as it is indicated in the documentation, we should not
worry too much about that... but "heartbeat" and "heartbeat-s" is ok
with me.
Maybe people @ devicetree-discuss have an advice for this?
Bye,
--
Nicolas Ferre
WARNING: multiple messages have this Message-ID (diff)
From: nicolas.ferre@atmel.com (Nicolas Ferre)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/2] watchdog: at91sam9_wdt: add device tree support
Date: Tue, 25 Sep 2012 12:00:30 +0200 [thread overview]
Message-ID: <506180BE.6000603@atmel.com> (raw)
In-Reply-To: <CAHkwnC_=i7mEv99xU6HcFpEfC6eeumcZDWrBq2_qdv=rDf3E1g@mail.gmail.com>
On 09/25/2012 11:45 AM, Fabio Porcedda :
> On Tue, Sep 25, 2012 at 10:10 AM, Jean-Christophe PLAGNIOL-VILLARD
> <plagnioj@jcrosoft.com> wrote:
>> On 09:28 Tue 25 Sep , Fabio Porcedda wrote:
>>> Tested on an at91sam9260 board (evk-pro3)
>>>
>>> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
>>> ---
>>> .../devicetree/bindings/watchdog/atmel-wdt.txt | 19 +++++++++++++++++++
>>> drivers/watchdog/at91sam9_wdt.c | 21 +++++++++++++++++++++
>>> 2 files changed, 40 insertions(+)
>>> create mode 100644 Documentation/devicetree/bindings/watchdog/atmel-wdt.txt
>>>
>>> diff --git a/Documentation/devicetree/bindings/watchdog/atmel-wdt.txt b/Documentation/devicetree/bindings/watchdog/atmel-wdt.txt
>>> new file mode 100644
>>> index 0000000..724fad1
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/watchdog/atmel-wdt.txt
>>> @@ -0,0 +1,19 @@
>>> +* Atmel Watchdog Timers
>>> +
>>> +** at91sam9-wdt
>>> +
>>> +Required properties:
>>> +- compatible: must be "atmel,at91sam9-wdt".
>>> +- reg: physical base address of the controller and length of memory mapped
>>> + region.
>>> +
>>> +Optional properties:
>>> +- heartbeat: contains the watchdog heartbeats in seconds.
>>> +
>>> +Example:
>>> +
>>> + watchdog at fffffd40 {
>>> + compatible = "atmel,at91sam9-wdt";
>> for the secind time atmel,at91sam9260-watchdog
>
> Ok, i will fix this.
>
>> you need to put the first soc that use it in the compatible
>>> + reg = <0xfffffd40 0x10>;
>>> + heartbeat = <10>;
>> need put second in the property name so need to read the doc
>
> I didn't found any example about a property with "second" in the name.
> Which It's best "heartbeat-seconds", "heartbeat-sec" or "heartbeat-s" ?
I think that, as it is indicated in the documentation, we should not
worry too much about that... but "heartbeat" and "heartbeat-s" is ok
with me.
Maybe people @ devicetree-discuss have an advice for this?
Bye,
--
Nicolas Ferre
WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Ferre <nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
To: Fabio Porcedda
<fabio.porcedda-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
Cc: Wim Van Sebroeck <wim-IQzOog9fTRqzQB+pC5nmwQ@public.gmane.org>,
linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Andrew Victor <linux-PelNFVqkFnVyf+4FbqDuWQ@public.gmane.org>
Subject: Re: [PATCH v3 1/2] watchdog: at91sam9_wdt: add device tree support
Date: Tue, 25 Sep 2012 12:00:30 +0200 [thread overview]
Message-ID: <506180BE.6000603@atmel.com> (raw)
In-Reply-To: <CAHkwnC_=i7mEv99xU6HcFpEfC6eeumcZDWrBq2_qdv=rDf3E1g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On 09/25/2012 11:45 AM, Fabio Porcedda :
> On Tue, Sep 25, 2012 at 10:10 AM, Jean-Christophe PLAGNIOL-VILLARD
> <plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org> wrote:
>> On 09:28 Tue 25 Sep , Fabio Porcedda wrote:
>>> Tested on an at91sam9260 board (evk-pro3)
>>>
>>> Signed-off-by: Fabio Porcedda <fabio.porcedda-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>>> ---
>>> .../devicetree/bindings/watchdog/atmel-wdt.txt | 19 +++++++++++++++++++
>>> drivers/watchdog/at91sam9_wdt.c | 21 +++++++++++++++++++++
>>> 2 files changed, 40 insertions(+)
>>> create mode 100644 Documentation/devicetree/bindings/watchdog/atmel-wdt.txt
>>>
>>> diff --git a/Documentation/devicetree/bindings/watchdog/atmel-wdt.txt b/Documentation/devicetree/bindings/watchdog/atmel-wdt.txt
>>> new file mode 100644
>>> index 0000000..724fad1
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/watchdog/atmel-wdt.txt
>>> @@ -0,0 +1,19 @@
>>> +* Atmel Watchdog Timers
>>> +
>>> +** at91sam9-wdt
>>> +
>>> +Required properties:
>>> +- compatible: must be "atmel,at91sam9-wdt".
>>> +- reg: physical base address of the controller and length of memory mapped
>>> + region.
>>> +
>>> +Optional properties:
>>> +- heartbeat: contains the watchdog heartbeats in seconds.
>>> +
>>> +Example:
>>> +
>>> + watchdog@fffffd40 {
>>> + compatible = "atmel,at91sam9-wdt";
>> for the secind time atmel,at91sam9260-watchdog
>
> Ok, i will fix this.
>
>> you need to put the first soc that use it in the compatible
>>> + reg = <0xfffffd40 0x10>;
>>> + heartbeat = <10>;
>> need put second in the property name so need to read the doc
>
> I didn't found any example about a property with "second" in the name.
> Which It's best "heartbeat-seconds", "heartbeat-sec" or "heartbeat-s" ?
I think that, as it is indicated in the documentation, we should not
worry too much about that... but "heartbeat" and "heartbeat-s" is ok
with me.
Maybe people @ devicetree-discuss have an advice for this?
Bye,
--
Nicolas Ferre
next prev parent reply other threads:[~2012-09-25 10:00 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-25 7:28 [PATCH v3 0/2] watchdog: at91sam9_wdt: add device tree support Fabio Porcedda
2012-09-25 7:28 ` Fabio Porcedda
2012-09-25 7:28 ` Fabio Porcedda
2012-09-25 7:28 ` [PATCH v3 1/2] " Fabio Porcedda
2012-09-25 7:28 ` Fabio Porcedda
2012-09-25 7:28 ` Fabio Porcedda
2012-09-25 8:10 ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-25 8:10 ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-25 8:10 ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-25 9:45 ` Fabio Porcedda
2012-09-25 9:45 ` Fabio Porcedda
2012-09-25 9:45 ` Fabio Porcedda
2012-09-25 10:00 ` Nicolas Ferre [this message]
2012-09-25 10:00 ` Nicolas Ferre
2012-09-25 10:00 ` Nicolas Ferre
2012-09-25 10:49 ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-25 10:49 ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-25 10:49 ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-26 14:53 ` Fabio Porcedda
2012-09-26 14:53 ` Fabio Porcedda
2012-09-26 14:53 ` Fabio Porcedda
2012-09-25 9:40 ` Nicolas Ferre
2012-09-25 9:40 ` Nicolas Ferre
2012-09-25 9:40 ` Nicolas Ferre
2012-09-25 7:28 ` [PATCH v3 2/2] ARM: at91: add at91sam9_wdt driver to at91sam926x, at91sam9g45 Fabio Porcedda
2012-09-25 7:28 ` Fabio Porcedda
2012-09-25 7:28 ` Fabio Porcedda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=506180BE.6000603@atmel.com \
--to=nicolas.ferre@atmel.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=fabio.porcedda@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@maxim.org.za \
--cc=plagnioj@jcrosoft.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.